You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/11 17:56:59 UTC
[GitHub] [spark] dongjoon-hyun commented on issue #24902: [SPARK-28093][SQL]
Fix TRIM/LTRIM/RTRIM function parameter order issue
dongjoon-hyun commented on issue #24902: [SPARK-28093][SQL] Fix TRIM/LTRIM/RTRIM function parameter order issue
URL: https://github.com/apache/spark/pull/24902#issuecomment-584768114
@cloud-fan . SQL Syntax and function is not the same. Why do we need to follow that?
> More importantly, the SQL standard does define the TRIM syntax as TRIM ( [ characters FROM ] string ), and I think this is the thing we should follow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org