You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/10/29 09:09:30 UTC

[GitHub] [skywalking-java] wu-sheng commented on pull request #60: [Enhance]For trace CompletableFuture thenApply or thenAccept

wu-sheng commented on pull request #60:
URL: https://github.com/apache/skywalking-java/pull/60#issuecomment-954579713


   Generally, this is fine to add.
   
   There are several things you need to update and verify your feature.
   1. Document should be updated about toolkit and use case.
   2. Plugin test scenario should be updated, https://github.com/apache/skywalking-java/tree/main/test/plugin/scenarios/apm-toolkit-trace-scenario
   3. Changes.md in the root should be updated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org