[GitHub] [lucene] alessandrobenedetti commented on pull request #12169: Introduced the Word2VecSynonymFilter

["alessandrobenedetti (via GitHub)" <gi...@apache.org>]

alessandrobenedetti commented on PR #12169:
URL: https://github.com/apache/lucene/pull/12169#issuecomment-1463774563

   I'll leave the BoostAttribute discussion for another time as I don't have access to the code right now, but javaDocs or not, it seems extremely suspicious to have a public class that shouldn't be used, it smells bad practice, quite frankly.
   
   Regarding the "should this be a token filter or something else", I don't see any particular difference with the regular Synonym token filter ( it's just a difference way of providing synonyms from a machine learned model rather than the explicit file).
   The boost side of things (which should be optional) is designed for the query time usage only (if I remember correctly we don't have any kind of indexing time boost anymore nor there was an index time per term boost at all).
   Not much difference from the weighted synonyms approach. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org