You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by Adrian Cumiskey <ad...@gmail.com> on 2008/05/13 10:55:58 UTC

8 Unit Tests Broken

Hi all,

When merging across, I discovered that my fresh checked out sandbox of trunk is showing 8 unit tests 
broken at the moment (mostly in the layout engine).  We shouldn't really commit any code that breaks 
unit tests, any chance we could try and fix these? :)

Adrian.

Re: 8 Unit Tests Broken

Posted by Andreas Delmelle <an...@telenet.be>.
FWIW:

On May 13, 2008, at 15:24, Vincent Hennebert wrote:
>     SEVERE: Could not create block pointers. FOText w/o Block  
> ancestor.
> The first word scares me a bit ;-)

No need to fear any longer. ;-)

Deactivated this error message for ignorable white-space in the  
meantime. The only time this error message will appear now, is  
preceding a ValidationException, since that means that the fo:wrapper  
contains significant text (i.e. non-white-space or preserved white- 
space) and its parent does not allow it.


Cheers

Andreas

Re: 8 Unit Tests Broken

Posted by Andreas Delmelle <an...@telenet.be>.
On May 13, 2008, at 16:01, Andreas Delmelle wrote:
>
> Before the changes I made, this sequence would also result in an  
> Inline area, which would cause a ClassCastException during the  
> addAreas() phase.
> Instead, the check in FlowLM was put there to filter the  
> InlineKnuthSequence out, and signal an error/warning if the  
> fo:wrapper was a descendant of the fo:flow.


Note to self: when I fix the WrapperLM's element-generation, the  
check should no longer be necessary. The only item that may result in  
inline-areas, and at the same time be a descendant of the fo:flow, is  
a fo:wrapper. Text under the fo:flow will be ignored (behavior may be  
revisited at some point), fo:inline (or something equivalent) will  
lead to a ValidationException at parse-time.


Re: 8 Unit Tests Broken

Posted by Andreas Delmelle <an...@telenet.be>.
On May 13, 2008, at 15:24, Vincent Hennebert wrote:
>>
>> FWIW: The test should pass now. I'm not 100% certain whether the  
>> change
>> is correct, but the element-list we get has the box we're looking  
>> for at
>> position 3 (index 2), so I simply skipped the first two elements  
>> in the
>> list...
>
> I can’t help but think that something’s going wrong here. Was the test
> just modified so that it passes again, or does it really reflect the
> changes made in the code?

Both. What is probably still incomplete, is that the fo:wrapper  
generates a dummy InlineKnuthSequence, so that its id survives until  
area-tree generation.

Before the changes I made, this sequence would also result in an  
Inline area, which would cause a ClassCastException during the  
addAreas() phase.
Instead, the check in FlowLM was put there to filter the  
InlineKnuthSequence out, and signal an error/warning if the  
fo:wrapper was a descendant of the fo:flow.

>     SEVERE: inline area not allowed under flow - ignoring

By ignoring the area, id references to the fo:wrapper were useless.

ATM, the inline-sequence remains. The position is properly wrapped by  
the parent LM, due to the small change to  
BlockStackingLM.wrapPositionElements(), which can now also handle  
elements that are sequences themselves.

> Are those 2 new elements at the beginning of
> the list now to be expected?

I did expect /some/ change. Seeing this inline-sequence in the  
meantime already got me looking into also overriding  
WrapperLM.getNextKnuthElements(), to generate a proper block-box in  
those cases, but the checks in the testcase would remain the same as  
they are now.

> Also, the wrapper_block.xml testcase now
> gives the following message twice:
>     SEVERE: Could not create block pointers. FOText w/o Block  
> ancestor.

I'll look into this as well. Probably a result of white-spaces that  
are unnecessarily preserved.

> I don’t want to sound too much negative, I don’t really follow the
> changes you’ve been doing in this area, but I’m slighty concerned. My
> point simply is that if there’s something I don’t fully understand,  
> I’d
> rather not touch it.

No problem. You're obviously right about being cautious. OTOH, if you  
never touch it, you'll never fully understand it... ;-)


Cheers


Andreas

Re: 8 Unit Tests Broken

Posted by Vincent Hennebert <vi...@anyware-tech.com>.
Andreas Delmelle wrote:
> On May 13, 2008, at 13:44, Andreas Delmelle wrote:
>> On May 13, 2008, at 13:18, Adrian Cumiskey wrote:
>>> The following test still fails as part of the LayoutEngineTestSuite :-
>>>
>>> wrapper_block.xml    Error    Expected w=14400 at position 0 but got:
>>> 0 (element-list category=breaker)
>>>
>>> java.lang.RuntimeException: Expected w=14400 at position 0 but got: 0
>>> (element-list category=breaker)
>>
>> Ouch! I had put the check in question in comment here :S
>>
>> Forgot to get back to this, since the other checks for this test all
>> passed. It is related to the fact that an fo:wrapper now generates a
>> Block instead of an Inline area, if it appears as a child of the
>> fo:flow or a fo:block-container. (see also: r654111)
>>
>> I'll change the check (as soon as I figure out what the current
>> expected result should be...)
>
> FWIW: The test should pass now. I'm not 100% certain whether the change
> is correct, but the element-list we get has the box we're looking for at
> position 3 (index 2), so I simply skipped the first two elements in the
> list...

I can’t help but think that something’s going wrong here. Was the test
just modified so that it passes again, or does it really reflect the
changes made in the code? Are those 2 new elements at the beginning of
the list now to be expected? Also, the wrapper_block.xml testcase now
gives the following message twice:
    SEVERE: Could not create block pointers. FOText w/o Block ancestor.
The first word scares me a bit ;-)
Granted, before the change there was the following issue:
    SEVERE: inline area not allowed under flow - ignoring
So something has definitely evolved, but I’d love to be re-assured that
it’s for the better...

I don’t want to sound too much negative, I don’t really follow the
changes you’ve been doing in this area, but I’m slighty concerned. My
point simply is that if there’s something I don’t fully understand, I’d
rather not touch it.


> Issue is related to the change in FlowLM:
>
> @@ -75,7 +76,8 @@
>
> -            if (curLM instanceof InlineLevelLayoutManager) {
> +            if (!(curLM instanceof WrapperLayoutManager)
> +                && curLM instanceof InlineLevelLayoutManager) {
>
> This check was once added to avoid ClassCastExceptions, IIRC, but since
> the validation of fo:wrappers containing inline-content now happens at
> parse-time, the FlowLM does not need to check this anymore. This
> apparently does result in extra elements in the breaker's element-list...
>
>
>
> Cheers
>
> Andreas

Thanks,
Vincent


-- 
Vincent Hennebert                            Anyware Technologies
http://people.apache.org/~vhennebert         http://www.anyware-tech.com
Apache FOP Committer                         FOP Development/Consulting

Re: 8 Unit Tests Broken

Posted by Andreas Delmelle <an...@telenet.be>.
On May 13, 2008, at 13:44, Andreas Delmelle wrote:
> On May 13, 2008, at 13:18, Adrian Cumiskey wrote:
>> The following test still fails as part of the  
>> LayoutEngineTestSuite :-
>>
>> wrapper_block.xml	Error	Expected w=14400 at position 0 but got: 0  
>> (element-list category=breaker)
>>
>> java.lang.RuntimeException: Expected w=14400 at position 0 but  
>> got: 0 (element-list category=breaker)
>
> Ouch! I had put the check in question in comment here :S
>
> Forgot to get back to this, since the other checks for this test  
> all passed. It is related to the fact that an fo:wrapper now  
> generates a Block instead of an Inline area, if it appears as a  
> child of the fo:flow or a fo:block-container. (see also: r654111)
>
> I'll change the check (as soon as I figure out what the current  
> expected result should be...)

FWIW: The test should pass now. I'm not 100% certain whether the  
change is correct, but the element-list we get has the box we're  
looking for at position 3 (index 2), so I simply skipped the first  
two elements in the list...

Issue is related to the change in FlowLM:

@@ -75,7 +76,8 @@

-            if (curLM instanceof InlineLevelLayoutManager) {
+            if (!(curLM instanceof WrapperLayoutManager)
+                && curLM instanceof InlineLevelLayoutManager) {

This check was once added to avoid ClassCastExceptions, IIRC, but  
since the validation of fo:wrappers containing inline-content now  
happens at parse-time, the FlowLM does not need to check this  
anymore. This apparently does result in extra elements in the  
breaker's element-list...



Cheers

Andreas

Re: 8 Unit Tests Broken

Posted by Andreas Delmelle <an...@telenet.be>.
On May 13, 2008, at 13:18, Adrian Cumiskey wrote:
> The following test still fails as part of the LayoutEngineTestSuite :-
>
> wrapper_block.xml	Error	Expected w=14400 at position 0 but got: 0  
> (element-list category=breaker)
>
> java.lang.RuntimeException: Expected w=14400 at position 0 but got:  
> 0 (element-list category=breaker)

Ouch! I had put the check in question in comment here :S

Forgot to get back to this, since the other checks for this test all  
passed. It is related to the fact that an fo:wrapper now generates a  
Block instead of an Inline area, if it appears as a child of the  
fo:flow or a fo:block-container. (see also: r654111)

I'll change the check (as soon as I figure out what the current  
expected result should be...)


Cheers

Andreas

Re: 8 Unit Tests Broken

Posted by Adrian Cumiskey <ad...@gmail.com>.
The following test still fails as part of the LayoutEngineTestSuite :-

wrapper_block.xml	Error	Expected w=14400 at position 0 but got: 0 (element-list category=breaker)

java.lang.RuntimeException: Expected w=14400 at position 0 but got: 0 (element-list category=breaker)
at org.apache.fop.layoutengine.ElementListCheck.fail(ElementListCheck.java:222)
at org.apache.fop.layoutengine.ElementListCheck.check(ElementListCheck.java:87)
at org.apache.fop.layoutengine.LayoutEngineTester.checkAll(LayoutEngineTester.java:235)
at org.apache.fop.layoutengine.LayoutEngineTester.runTest(LayoutEngineTester.java:182)
at 
org.apache.fop.layoutengine.LayoutEngineTestSuite$LayoutEngineTestCase.testMain(LayoutEngineTestSuite.java:219)
at org.apache.fop.layoutengine.LayoutEngineTestSuite$1.runTest(LayoutEngineTestSuite.java:193)

Adrian.


Andreas Delmelle wrote:
> On May 13, 2008, at 12:20, Andreas Delmelle wrote:
>> On May 13, 2008, at 11:59, Andreas Delmelle wrote:
>>>>
>>>> background-position-shorthand-test.fo    Error 
>>>> file:/home/acumiskey/workspace/tru/test/fotree/testcases/background-position-shorthand-test.fo 
>>>> Property 'background-position-vertical' expected to evaluate to 
>>>> '0mpt' but got '0.0%' (test:assert in fo:block at line #53, column #79)
>>>>
>>>> java.lang.IllegalStateException: 
>>>> file:/home/acumiskey/workspace/tru/test/fotree/testcases/background-position-shorthand-test.fo 
>>>>
>>>> Property 'background-position-vertical' expected to evaluate to 
>>>> '0mpt' but got '0.0%'
>>>> (test:assert in fo:block at line #53, column #79)
>>>
>>>
>>> This one, I'm not sure, yet. Needs further investigation... I'll get 
>>> back on this one.
>>
>> Must have something to do with caching CommonBorderPaddingBackground. 
>> No idea why it is suddenly using 0%. This should (obviously) resolve 
>> to a FixedLength of 0mpt...
> 
> Decided to force the default zero value for both properties (and the 
> shorthand) to absolute lengths (0pt) instead of percentages (0%). This 
> makes the test pass again, and should be better for memory-consumption.
> 
> So, trunk should be stable again.
> 
> Apologies for the inconvenience.
> 
> Cheers
> 
> Andreas
> 


Re: 8 Unit Tests Broken

Posted by Andreas Delmelle <an...@telenet.be>.
On May 13, 2008, at 12:20, Andreas Delmelle wrote:
> On May 13, 2008, at 11:59, Andreas Delmelle wrote:
>>>
>>> background-position-shorthand-test.fo	Error file:/home/acumiskey/ 
>>> workspace/tru/test/fotree/testcases/background-position-shorthand- 
>>> test.fo Property 'background-position-vertical' expected to  
>>> evaluate to '0mpt' but got '0.0%' (test:assert in fo:block at  
>>> line #53, column #79)
>>>
>>> java.lang.IllegalStateException: file:/home/acumiskey/workspace/ 
>>> tru/test/fotree/testcases/background-position-shorthand-test.fo
>>> Property 'background-position-vertical' expected to evaluate to  
>>> '0mpt' but got '0.0%'
>>> (test:assert in fo:block at line #53, column #79)
>>
>>
>> This one, I'm not sure, yet. Needs further investigation... I'll  
>> get back on this one.
>
> Must have something to do with caching  
> CommonBorderPaddingBackground. No idea why it is suddenly using 0%.  
> This should (obviously) resolve to a FixedLength of 0mpt...

Decided to force the default zero value for both properties (and the  
shorthand) to absolute lengths (0pt) instead of percentages (0%).  
This makes the test pass again, and should be better for memory- 
consumption.

So, trunk should be stable again.

Apologies for the inconvenience.

Cheers

Andreas

Re: 8 Unit Tests Broken

Posted by Andreas Delmelle <an...@telenet.be>.
On May 13, 2008, at 11:59, Andreas Delmelle wrote:
>>
>> background-position-shorthand-test.fo	Error file:/home/acumiskey/ 
>> workspace/tru/test/fotree/testcases/background-position-shorthand- 
>> test.fo Property 'background-position-vertical' expected to  
>> evaluate to '0mpt' but got '0.0%' (test:assert in fo:block at line  
>> #53, column #79)
>>
>> java.lang.IllegalStateException: file:/home/acumiskey/workspace/ 
>> tru/test/fotree/testcases/background-position-shorthand-test.fo
>> Property 'background-position-vertical' expected to evaluate to  
>> '0mpt' but got '0.0%'
>> (test:assert in fo:block at line #53, column #79)
>
>
> This one, I'm not sure, yet. Needs further investigation... I'll  
> get back on this one.

Must have something to do with caching CommonBorderPaddingBackground.  
No idea why it is suddenly using 0%. This should (obviously) resolve  
to a FixedLength of 0mpt...

I'll keep looking.

Can you confirm that this is also the only test failing on your end  
(after r655500)?

Thanks!


Cheers

Andreas

Re: 8 Unit Tests Broken

Posted by Andreas Delmelle <an...@telenet.be>.
On May 13, 2008, at 11:39, Adrian Cumiskey wrote:
> Hi Andreas,
>
> Without more thorough investigation, at a guess I would say it  
> looks like the new id generation stuff may be contributing to some  
> of the test failures (see NullPointerExceptions).  Here are the  
> test failures...

Yep, reverting that change already resolves the NPEs (committed in  
the meantime), but...

> FOTreeTestSuite :-
>
> background-position-shorthand-test.fo	Error file:/home/acumiskey/ 
> workspace/tru/test/fotree/testcases/background-position-shorthand- 
> test.fo Property 'background-position-vertical' expected to  
> evaluate to '0mpt' but got '0.0%' (test:assert in fo:block at line  
> #53, column #79)
>
> java.lang.IllegalStateException: file:/home/acumiskey/workspace/tru/ 
> test/fotree/testcases/background-position-shorthand-test.fo
> Property 'background-position-vertical' expected to evaluate to  
> '0mpt' but got '0.0%'
> (test:assert in fo:block at line #53, column #79)


This one, I'm not sure, yet. Needs further investigation... I'll get  
back on this one.



Cheers

Andreas


Re: 8 Unit Tests Broken

Posted by Adrian Cumiskey <ad...@gmail.com>.
Hi Andreas,

Without more thorough investigation, at a guess I would say it looks like the new id generation 
stuff may be contributing to some of the test failures (see NullPointerExceptions).  Here are the 
test failures...


FOTreeTestSuite :-

background-position-shorthand-test.fo	Error 
file:/home/acumiskey/workspace/tru/test/fotree/testcases/background-position-shorthand-test.fo 
Property 'background-position-vertical' expected to evaluate to '0mpt' but got '0.0%' (test:assert 
in fo:block at line #53, column #79)

java.lang.IllegalStateException: 
file:/home/acumiskey/workspace/tru/test/fotree/testcases/background-position-shorthand-test.fo
Property 'background-position-vertical' expected to evaluate to '0mpt' but got '0.0%'
(test:assert in fo:block at line #53, column #79)

at org.apache.fop.fotreetest.ext.AssertElement.processNode(AssertElement.java:103)
at org.apache.fop.fo.FOTreeBuilder$MainFOHandler.startElement(FOTreeBuilder.java:278)
at org.apache.fop.fo.FOTreeBuilder.startElement(FOTreeBuilder.java:168)
at org.xml.sax.helpers.XMLFilterImpl.startElement(XMLFilterImpl.java:575)
at org.apache.xerces.parsers.AbstractSAXParser.startElement(Unknown Source)
at org.apache.xerces.parsers.AbstractXMLDocumentParser.emptyElement(Unknown Source)
at org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanStartElement(Unknown Source)
at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown 
Source)
at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown Source)
at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source)
at org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown Source)
at org.xml.sax.helpers.XMLFilterImpl.parse(XMLFilterImpl.java:371)
at org.xml.sax.helpers.XMLFilterImpl.parse(XMLFilterImpl.java:389)
at org.apache.fop.fotreetest.FOTreeTester.runTest(FOTreeTester.java:82)
at org.apache.fop.fotreetest.FOTreeTestSuite$FOTreeTestCase.testMain(FOTreeTestSuite.java:144)
at org.apache.fop.fotreetest.FOTreeTestSuite$1.runTest(FOTreeTestSuite.java:110)


LayoutEngineTestSuite :-

footnote_bug37880.xml	Error	Expected XPath expression to evaluate to 'true', but got 'false' (XPath: 
//footnote/block[2]/@bpd > 0)

java.lang.RuntimeException: Expected XPath expression to evaluate to 'true', but got 'false' (XPath: 
//footnote/block[2]/@bpd > 0)
at org.apache.fop.layoutengine.TrueCheck.check(TrueCheck.java:73)
at org.apache.fop.layoutengine.LayoutEngineTester.checkAll(LayoutEngineTester.java:235)
at org.apache.fop.layoutengine.LayoutEngineTester.runTest(LayoutEngineTester.java:182)
at 
org.apache.fop.layoutengine.LayoutEngineTestSuite$LayoutEngineTestCase.testMain(LayoutEngineTestSuite.java:219)
at org.apache.fop.layoutengine.LayoutEngineTestSuite$1.runTest(LayoutEngineTestSuite.java:193)
	0.017

footnote_footnote-separator.xml	Error	Expected XPath expression to evaluate to '0', but got '14400' 
(XPath: //pageViewport[3]/page/regionViewport/regionBody/mainReference/span/flow/block[last()]/@bpd)

java.lang.RuntimeException: Expected XPath expression to evaluate to '0', but got '14400' (XPath: 
//pageViewport[3]/page/regionViewport/regionBody/mainReference/span/flow/block[last()]/@bpd)
at org.apache.fop.layoutengine.EvalCheck.check(EvalCheck.java:83)
at org.apache.fop.layoutengine.LayoutEngineTester.checkAll(LayoutEngineTester.java:235)
at org.apache.fop.layoutengine.LayoutEngineTester.runTest(LayoutEngineTester.java:182)
at 
org.apache.fop.layoutengine.LayoutEngineTestSuite$LayoutEngineTestCase.testMain(LayoutEngineTestSuite.java:219)
at org.apache.fop.layoutengine.LayoutEngineTestSuite$1.runTest(LayoutEngineTestSuite.java:193)
	0.079


region_side_space-resolution.xml	Error	Requested element list not found

java.lang.ArrayIndexOutOfBoundsException: Requested element list not found
at org.apache.fop.layoutengine.ElementListCheck.findElementList(ElementListCheck.java:244)
at org.apache.fop.layoutengine.ElementListCheck.check(ElementListCheck.java:67)
at org.apache.fop.layoutengine.LayoutEngineTester.checkAll(LayoutEngineTester.java:235)
at org.apache.fop.layoutengine.LayoutEngineTester.runTest(LayoutEngineTester.java:182)
at 
org.apache.fop.layoutengine.LayoutEngineTestSuite$LayoutEngineTestCase.testMain(LayoutEngineTestSuite.java:219)
at org.apache.fop.layoutengine.LayoutEngineTestSuite$1.runTest(LayoutEngineTestSuite.java:193)
	0.018


title_empty.xml	Error	java.lang.NullPointerException

; SystemID: file:///home/acumiskey/workspace/tru/test/layoutengine/testcase2fo.xsl; Line#: 35; 
Column#: 60
javax.xml.transform.TransformerException: java.lang.NullPointerException
at org.apache.xalan.transformer.TransformerImpl.executeChildTemplates(TransformerImpl.java:2344)
at org.apache.xalan.templates.ElemCopy.execute(ElemCopy.java:162)
at org.apache.xalan.templates.ElemApplyTemplates.transformSelectedNodes(ElemApplyTemplates.java:425)
at org.apache.xalan.templates.ElemApplyTemplates.execute(ElemApplyTemplates.java:216)
at org.apache.xalan.templates.ElemApplyTemplates.transformSelectedNodes(ElemApplyTemplates.java:425)
at org.apache.xalan.templates.ElemApplyTemplates.execute(ElemApplyTemplates.java:216)
at org.apache.xalan.transformer.TransformerImpl.executeChildTemplates(TransformerImpl.java:2339)
at org.apache.xalan.transformer.TransformerImpl.applyTemplateToNode(TransformerImpl.java:2160)
at org.apache.xalan.transformer.TransformerImpl.transformNode(TransformerImpl.java:1213)
at org.apache.xalan.transformer.TransformerImpl.transform(TransformerImpl.java:668)
at org.apache.xalan.transformer.TransformerImpl.transform(TransformerImpl.java:1129)
at org.apache.xalan.transformer.TransformerImpl.transform(TransformerImpl.java:1107)
at org.apache.fop.layoutengine.LayoutEngineTester.runTest(LayoutEngineTester.java:171)
at 
org.apache.fop.layoutengine.LayoutEngineTestSuite$LayoutEngineTestCase.testMain(LayoutEngineTestSuite.java:219)
at org.apache.fop.layoutengine.LayoutEngineTestSuite$1.runTest(LayoutEngineTestSuite.java:193)
Caused by: java.lang.NullPointerException
at 
org.apache.fop.layoutmgr.AbstractPageSequenceLayoutManager.addIDToPage(AbstractPageSequenceLayoutManager.java:156)
at org.apache.fop.layoutmgr.AbstractLayoutManager.addId(AbstractLayoutManager.java:370)
at org.apache.fop.layoutmgr.inline.InlineLayoutManager.addAreas(InlineLayoutManager.java:413)
at org.apache.fop.layoutmgr.inline.ContentLayoutManager.fillArea(ContentLayoutManager.java:156)
at org.apache.fop.layoutmgr.inline.ContentLayoutManager.(ContentLayoutManager.java:98)
at org.apache.fop.layoutmgr.LayoutManagerMapping.makeContentLayoutManager(LayoutManagerMapping.java:201)
at org.apache.fop.layoutmgr.PageSequenceLayoutManager.activateLayout(PageSequenceLayoutManager.java:84)
at org.apache.fop.area.AreaTreeHandler.endPageSequence(AreaTreeHandler.java:234)
at org.apache.fop.fo.pagination.PageSequence.endOfNode(PageSequence.java:120)
at org.apache.fop.fo.FOTreeBuilder$MainFOHandler.endElement(FOTreeBuilder.java:332)
at org.apache.fop.fo.FOTreeBuilder.endElement(FOTreeBuilder.java:174)
at org.apache.xalan.transformer.ResultTreeHandler.endElement(ResultTreeHandler.java:309)
at org.apache.xalan.templates.ElemCopy.execute(ElemCopy.java:166)
at org.apache.xalan.templates.ElemApplyTemplates.transformSelectedNodes(ElemApplyTemplates.java:425)
at org.apache.xalan.templates.ElemApplyTemplates.execute(ElemApplyTemplates.java:216)
at org.apache.xalan.transformer.TransformerImpl.executeChildTemplates(TransformerImpl.java:2339)
---------
java.lang.NullPointerException
at 
org.apache.fop.layoutmgr.AbstractPageSequenceLayoutManager.addIDToPage(AbstractPageSequenceLayoutManager.java:156)
at org.apache.fop.layoutmgr.AbstractLayoutManager.addId(AbstractLayoutManager.java:370)
at org.apache.fop.layoutmgr.inline.InlineLayoutManager.addAreas(InlineLayoutManager.java:413)
at org.apache.fop.layoutmgr.inline.ContentLayoutManager.fillArea(ContentLayoutManager.java:156)
at org.apache.fop.layoutmgr.inline.ContentLayoutManager.(ContentLayoutManager.java:98)
at org.apache.fop.layoutmgr.LayoutManagerMapping.makeContentLayoutManager(LayoutManagerMapping.java:201)
at org.apache.fop.layoutmgr.PageSequenceLayoutManager.activateLayout(PageSequenceLayoutManager.java:84)
at org.apache.fop.area.AreaTreeHandler.endPageSequence(AreaTreeHandler.java:234)
at org.apache.fop.fo.pagination.PageSequence.endOfNode(PageSequence.java:120)
at org.apache.fop.fo.FOTreeBuilder$MainFOHandler.endElement(FOTreeBuilder.java:332)
at org.apache.fop.fo.FOTreeBuilder.endElement(FOTreeBuilder.java:174)
at org.apache.xalan.transformer.ResultTreeHandler.endElement(ResultTreeHandler.java:309)
at org.apache.xalan.templates.ElemCopy.execute(ElemCopy.java:166)
at org.apache.xalan.templates.ElemApplyTemplates.transformSelectedNodes(ElemApplyTemplates.java:425)
at org.apache.xalan.templates.ElemApplyTemplates.execute(ElemApplyTemplates.java:216)
at org.apache.xalan.transformer.TransformerImpl.executeChildTemplates(TransformerImpl.java:2339)
at org.apache.xalan.templates.ElemCopy.execute(ElemCopy.java:162)
at org.apache.xalan.templates.ElemApplyTemplates.transformSelectedNodes(ElemApplyTemplates.java:425)
at org.apache.xalan.templates.ElemApplyTemplates.execute(ElemApplyTemplates.java:216)
at org.apache.xalan.templates.ElemApplyTemplates.transformSelectedNodes(ElemApplyTemplates.java:425)
at org.apache.xalan.templates.ElemApplyTemplates.execute(ElemApplyTemplates.java:216)
at org.apache.xalan.transformer.TransformerImpl.executeChildTemplates(TransformerImpl.java:2339)
at org.apache.xalan.transformer.TransformerImpl.applyTemplateToNode(TransformerImpl.java:2160)
at org.apache.xalan.transformer.TransformerImpl.transformNode(TransformerImpl.java:1213)
at org.apache.xalan.transformer.TransformerImpl.transform(TransformerImpl.java:668)
at org.apache.xalan.transformer.TransformerImpl.transform(TransformerImpl.java:1129)
at org.apache.xalan.transformer.TransformerImpl.transform(TransformerImpl.java:1107)
at org.apache.fop.layoutengine.LayoutEngineTester.runTest(LayoutEngineTester.java:171)
at 
org.apache.fop.layoutengine.LayoutEngineTestSuite$LayoutEngineTestCase.testMain(LayoutEngineTestSuite.java:219)
at org.apache.fop.layoutengine.LayoutEngineTestSuite$1.runTest(LayoutEngineTestSuite.java:193)
	0.011


title_linefeed-treatment.xml	Error	java.lang.NullPointerException

; SystemID: file:///home/acumiskey/workspace/tru/test/layoutengine/testcase2fo.xsl; Line#: 35; 
Column#: 60
javax.xml.transform.TransformerException: java.lang.NullPointerException
at org.apache.xalan.transformer.TransformerImpl.executeChildTemplates(TransformerImpl.java:2344)
at org.apache.xalan.templates.ElemCopy.execute(ElemCopy.java:162)
at org.apache.xalan.templates.ElemApplyTemplates.transformSelectedNodes(ElemApplyTemplates.java:425)
at org.apache.xalan.templates.ElemApplyTemplates.execute(ElemApplyTemplates.java:216)
at org.apache.xalan.templates.ElemApplyTemplates.transformSelectedNodes(ElemApplyTemplates.java:425)
at org.apache.xalan.templates.ElemApplyTemplates.execute(ElemApplyTemplates.java:216)
at org.apache.xalan.transformer.TransformerImpl.executeChildTemplates(TransformerImpl.java:2339)
at org.apache.xalan.transformer.TransformerImpl.applyTemplateToNode(TransformerImpl.java:2160)
at org.apache.xalan.transformer.TransformerImpl.transformNode(TransformerImpl.java:1213)
at org.apache.xalan.transformer.TransformerImpl.transform(TransformerImpl.java:668)
at org.apache.xalan.transformer.TransformerImpl.transform(TransformerImpl.java:1129)
at org.apache.xalan.transformer.TransformerImpl.transform(TransformerImpl.java:1107)
at org.apache.fop.layoutengine.LayoutEngineTester.runTest(LayoutEngineTester.java:171)
at 
org.apache.fop.layoutengine.LayoutEngineTestSuite$LayoutEngineTestCase.testMain(LayoutEngineTestSuite.java:219)
at org.apache.fop.layoutengine.LayoutEngineTestSuite$1.runTest(LayoutEngineTestSuite.java:193)
Caused by: java.lang.NullPointerException
at 
org.apache.fop.layoutmgr.AbstractPageSequenceLayoutManager.addIDToPage(AbstractPageSequenceLayoutManager.java:156)
at org.apache.fop.layoutmgr.AbstractLayoutManager.addId(AbstractLayoutManager.java:370)
at org.apache.fop.layoutmgr.inline.InlineLayoutManager.addAreas(InlineLayoutManager.java:413)
at org.apache.fop.layoutmgr.inline.ContentLayoutManager.fillArea(ContentLayoutManager.java:156)
at org.apache.fop.layoutmgr.inline.ContentLayoutManager.(ContentLayoutManager.java:98)
at org.apache.fop.layoutmgr.LayoutManagerMapping.makeContentLayoutManager(LayoutManagerMapping.java:201)
at org.apache.fop.layoutmgr.PageSequenceLayoutManager.activateLayout(PageSequenceLayoutManager.java:84)
at org.apache.fop.area.AreaTreeHandler.endPageSequence(AreaTreeHandler.java:234)
at org.apache.fop.fo.pagination.PageSequence.endOfNode(PageSequence.java:120)
at org.apache.fop.fo.FOTreeBuilder$MainFOHandler.endElement(FOTreeBuilder.java:332)
at org.apache.fop.fo.FOTreeBuilder.endElement(FOTreeBuilder.java:174)
at org.apache.xalan.transformer.ResultTreeHandler.endElement(ResultTreeHandler.java:309)
at org.apache.xalan.templates.ElemCopy.execute(ElemCopy.java:166)
at org.apache.xalan.templates.ElemApplyTemplates.transformSelectedNodes(ElemApplyTemplates.java:425)
at org.apache.xalan.templates.ElemApplyTemplates.execute(ElemApplyTemplates.java:216)
at org.apache.xalan.transformer.TransformerImpl.executeChildTemplates(TransformerImpl.java:2339)
---------
java.lang.NullPointerException
at 
org.apache.fop.layoutmgr.AbstractPageSequenceLayoutManager.addIDToPage(AbstractPageSequenceLayoutManager.java:156)
at org.apache.fop.layoutmgr.AbstractLayoutManager.addId(AbstractLayoutManager.java:370)
at org.apache.fop.layoutmgr.inline.InlineLayoutManager.addAreas(InlineLayoutManager.java:413)
at org.apache.fop.layoutmgr.inline.ContentLayoutManager.fillArea(ContentLayoutManager.java:156)
at org.apache.fop.layoutmgr.inline.ContentLayoutManager.(ContentLayoutManager.java:98)
at org.apache.fop.layoutmgr.LayoutManagerMapping.makeContentLayoutManager(LayoutManagerMapping.java:201)
at org.apache.fop.layoutmgr.PageSequenceLayoutManager.activateLayout(PageSequenceLayoutManager.java:84)
at org.apache.fop.area.AreaTreeHandler.endPageSequence(AreaTreeHandler.java:234)
at org.apache.fop.fo.pagination.PageSequence.endOfNode(PageSequence.java:120)
at org.apache.fop.fo.FOTreeBuilder$MainFOHandler.endElement(FOTreeBuilder.java:332)
at org.apache.fop.fo.FOTreeBuilder.endElement(FOTreeBuilder.java:174)
at org.apache.xalan.transformer.ResultTreeHandler.endElement(ResultTreeHandler.java:309)
at org.apache.xalan.templates.ElemCopy.execute(ElemCopy.java:166)
at org.apache.xalan.templates.ElemApplyTemplates.transformSelectedNodes(ElemApplyTemplates.java:425)
at org.apache.xalan.templates.ElemApplyTemplates.execute(ElemApplyTemplates.java:216)
at org.apache.xalan.transformer.TransformerImpl.executeChildTemplates(TransformerImpl.java:2339)
at org.apache.xalan.templates.ElemCopy.execute(ElemCopy.java:162)
at org.apache.xalan.templates.ElemApplyTemplates.transformSelectedNodes(ElemApplyTemplates.java:425)
at org.apache.xalan.templates.ElemApplyTemplates.execute(ElemApplyTemplates.java:216)
at org.apache.xalan.templates.ElemApplyTemplates.transformSelectedNodes(ElemApplyTemplates.java:425)
at org.apache.xalan.templates.ElemApplyTemplates.execute(ElemApplyTemplates.java:216)
at org.apache.xalan.transformer.TransformerImpl.executeChildTemplates(TransformerImpl.java:2339)
at org.apache.xalan.transformer.TransformerImpl.applyTemplateToNode(TransformerImpl.java:2160)
at org.apache.xalan.transformer.TransformerImpl.transformNode(TransformerImpl.java:1213)
at org.apache.xalan.transformer.TransformerImpl.transform(TransformerImpl.java:668)
at org.apache.xalan.transformer.TransformerImpl.transform(TransformerImpl.java:1129)
at org.apache.xalan.transformer.TransformerImpl.transform(TransformerImpl.java:1107)
at org.apache.fop.layoutengine.LayoutEngineTester.runTest(LayoutEngineTester.java:171)
at 
org.apache.fop.layoutengine.LayoutEngineTestSuite$LayoutEngineTestCase.testMain(LayoutEngineTestSuite.java:219)
at org.apache.fop.layoutengine.LayoutEngineTestSuite$1.runTest(LayoutEngineTestSuite.java:193)
	0.009


title_non-empty.xml	Error	java.lang.NullPointerException

; SystemID: file:///home/acumiskey/workspace/tru/test/layoutengine/testcase2fo.xsl; Line#: 35; 
Column#: 60
javax.xml.transform.TransformerException: java.lang.NullPointerException
at org.apache.xalan.transformer.TransformerImpl.executeChildTemplates(TransformerImpl.java:2344)
at org.apache.xalan.templates.ElemCopy.execute(ElemCopy.java:162)
at org.apache.xalan.templates.ElemApplyTemplates.transformSelectedNodes(ElemApplyTemplates.java:425)
at org.apache.xalan.templates.ElemApplyTemplates.execute(ElemApplyTemplates.java:216)
at org.apache.xalan.templates.ElemApplyTemplates.transformSelectedNodes(ElemApplyTemplates.java:425)
at org.apache.xalan.templates.ElemApplyTemplates.execute(ElemApplyTemplates.java:216)
at org.apache.xalan.transformer.TransformerImpl.executeChildTemplates(TransformerImpl.java:2339)
at org.apache.xalan.transformer.TransformerImpl.applyTemplateToNode(TransformerImpl.java:2160)
at org.apache.xalan.transformer.TransformerImpl.transformNode(TransformerImpl.java:1213)
at org.apache.xalan.transformer.TransformerImpl.transform(TransformerImpl.java:668)
at org.apache.xalan.transformer.TransformerImpl.transform(TransformerImpl.java:1129)
at org.apache.xalan.transformer.TransformerImpl.transform(TransformerImpl.java:1107)
at org.apache.fop.layoutengine.LayoutEngineTester.runTest(LayoutEngineTester.java:171)
at 
org.apache.fop.layoutengine.LayoutEngineTestSuite$LayoutEngineTestCase.testMain(LayoutEngineTestSuite.java:219)
at org.apache.fop.layoutengine.LayoutEngineTestSuite$1.runTest(LayoutEngineTestSuite.java:193)
Caused by: java.lang.NullPointerException
at 
org.apache.fop.layoutmgr.AbstractPageSequenceLayoutManager.addIDToPage(AbstractPageSequenceLayoutManager.java:156)
at org.apache.fop.layoutmgr.AbstractLayoutManager.addId(AbstractLayoutManager.java:370)
at org.apache.fop.layoutmgr.inline.InlineLayoutManager.addAreas(InlineLayoutManager.java:413)
at org.apache.fop.layoutmgr.inline.ContentLayoutManager.fillArea(ContentLayoutManager.java:156)
at org.apache.fop.layoutmgr.inline.ContentLayoutManager.(ContentLayoutManager.java:98)
at org.apache.fop.layoutmgr.LayoutManagerMapping.makeContentLayoutManager(LayoutManagerMapping.java:201)
at org.apache.fop.layoutmgr.PageSequenceLayoutManager.activateLayout(PageSequenceLayoutManager.java:84)
at org.apache.fop.area.AreaTreeHandler.endPageSequence(AreaTreeHandler.java:234)
at org.apache.fop.fo.pagination.PageSequence.endOfNode(PageSequence.java:120)
at org.apache.fop.fo.FOTreeBuilder$MainFOHandler.endElement(FOTreeBuilder.java:332)
at org.apache.fop.fo.FOTreeBuilder.endElement(FOTreeBuilder.java:174)
at org.apache.xalan.transformer.ResultTreeHandler.endElement(ResultTreeHandler.java:309)
at org.apache.xalan.templates.ElemCopy.execute(ElemCopy.java:166)
at org.apache.xalan.templates.ElemApplyTemplates.transformSelectedNodes(ElemApplyTemplates.java:425)
at org.apache.xalan.templates.ElemApplyTemplates.execute(ElemApplyTemplates.java:216)
at org.apache.xalan.transformer.TransformerImpl.executeChildTemplates(TransformerImpl.java:2339)
---------
java.lang.NullPointerException
at 
org.apache.fop.layoutmgr.AbstractPageSequenceLayoutManager.addIDToPage(AbstractPageSequenceLayoutManager.java:156)
at org.apache.fop.layoutmgr.AbstractLayoutManager.addId(AbstractLayoutManager.java:370)
at org.apache.fop.layoutmgr.inline.InlineLayoutManager.addAreas(InlineLayoutManager.java:413)
at org.apache.fop.layoutmgr.inline.ContentLayoutManager.fillArea(ContentLayoutManager.java:156)
at org.apache.fop.layoutmgr.inline.ContentLayoutManager.(ContentLayoutManager.java:98)
at org.apache.fop.layoutmgr.LayoutManagerMapping.makeContentLayoutManager(LayoutManagerMapping.java:201)
at org.apache.fop.layoutmgr.PageSequenceLayoutManager.activateLayout(PageSequenceLayoutManager.java:84)
at org.apache.fop.area.AreaTreeHandler.endPageSequence(AreaTreeHandler.java:234)
at org.apache.fop.fo.pagination.PageSequence.endOfNode(PageSequence.java:120)
at org.apache.fop.fo.FOTreeBuilder$MainFOHandler.endElement(FOTreeBuilder.java:332)
at org.apache.fop.fo.FOTreeBuilder.endElement(FOTreeBuilder.java:174)
at org.apache.xalan.transformer.ResultTreeHandler.endElement(ResultTreeHandler.java:309)
at org.apache.xalan.templates.ElemCopy.execute(ElemCopy.java:166)
at org.apache.xalan.templates.ElemApplyTemplates.transformSelectedNodes(ElemApplyTemplates.java:425)
at org.apache.xalan.templates.ElemApplyTemplates.execute(ElemApplyTemplates.java:216)
at org.apache.xalan.transformer.TransformerImpl.executeChildTemplates(TransformerImpl.java:2339)
at org.apache.xalan.templates.ElemCopy.execute(ElemCopy.java:162)
at org.apache.xalan.templates.ElemApplyTemplates.transformSelectedNodes(ElemApplyTemplates.java:425)
at org.apache.xalan.templates.ElemApplyTemplates.execute(ElemApplyTemplates.java:216)
at org.apache.xalan.templates.ElemApplyTemplates.transformSelectedNodes(ElemApplyTemplates.java:425)
at org.apache.xalan.templates.ElemApplyTemplates.execute(ElemApplyTemplates.java:216)
at org.apache.xalan.transformer.TransformerImpl.executeChildTemplates(TransformerImpl.java:2339)
at org.apache.xalan.transformer.TransformerImpl.applyTemplateToNode(TransformerImpl.java:2160)
at org.apache.xalan.transformer.TransformerImpl.transformNode(TransformerImpl.java:1213)
at org.apache.xalan.transformer.TransformerImpl.transform(TransformerImpl.java:668)
at org.apache.xalan.transformer.TransformerImpl.transform(TransformerImpl.java:1129)
at org.apache.xalan.transformer.TransformerImpl.transform(TransformerImpl.java:1107)
at org.apache.fop.layoutengine.LayoutEngineTester.runTest(LayoutEngineTester.java:171)
at 
org.apache.fop.layoutengine.LayoutEngineTestSuite$LayoutEngineTestCase.testMain(LayoutEngineTestSuite.java:219)
at org.apache.fop.layoutengine.LayoutEngineTestSuite$1.runTest(LayoutEngineTestSuite.java:193)
	0.014


wrapper_block.xml	Error	Expected w=14400 at position 0 but got: 0 (element-list category=breaker)

java.lang.RuntimeException: Expected w=14400 at position 0 but got: 0 (element-list category=breaker)
at org.apache.fop.layoutengine.ElementListCheck.fail(ElementListCheck.java:222)
at org.apache.fop.layoutengine.ElementListCheck.check(ElementListCheck.java:87)
at org.apache.fop.layoutengine.LayoutEngineTester.checkAll(LayoutEngineTester.java:235)
at org.apache.fop.layoutengine.LayoutEngineTester.runTest(LayoutEngineTester.java:182)
at 
org.apache.fop.layoutengine.LayoutEngineTestSuite$LayoutEngineTestCase.testMain(LayoutEngineTestSuite.java:219)
at org.apache.fop.layoutengine.LayoutEngineTestSuite$1.runTest(LayoutEngineTestSuite.java:193)




Andreas Delmelle wrote:
> On May 13, 2008, at 10:55, Adrian Cumiskey wrote:
> 
> Hi Adrian
> 
>> When merging across, I discovered that my fresh checked out sandbox of 
>> trunk is showing 8 unit tests broken at the moment (mostly in the 
>> layout engine).  We shouldn't really commit any code that breaks unit 
>> tests, any chance we could try and fix these? :)
> 
> Which tests are failing on your end exactly? I've updated my sandbox 
> yesterday evening, and all tests still passed... but that could also 
> mean that some of my local changes haven't found their way into the 
> repository yet.
> 
> If you tell me which ones, maybe that will ring a bell over here.
> 
> Apologies in advance (if it turns out to be my fault... again :/)
> 
> Cheers
> 
> Andreas
> 
> 


Re: 8 Unit Tests Broken

Posted by Andreas Delmelle <an...@telenet.be>.
On May 13, 2008, at 10:59, Andreas Delmelle wrote:
> On May 13, 2008, at 10:55, Adrian Cumiskey wrote:
>
> Which tests are failing on your end exactly? I've updated my  
> sandbox yesterday evening, and all tests still passed... but that  
> could also mean that some of my local changes haven't found their  
> way into the repository yet.

Just did a fresh checkout, and already found them... I'll start  
looking for the cause now, and will keep you informed.


Cheers

Andreas

Re: 8 Unit Tests Broken

Posted by Andreas Delmelle <an...@telenet.be>.
On May 13, 2008, at 10:55, Adrian Cumiskey wrote:

Hi Adrian

> When merging across, I discovered that my fresh checked out sandbox  
> of trunk is showing 8 unit tests broken at the moment (mostly in  
> the layout engine).  We shouldn't really commit any code that  
> breaks unit tests, any chance we could try and fix these? :)

Which tests are failing on your end exactly? I've updated my sandbox  
yesterday evening, and all tests still passed... but that could also  
mean that some of my local changes haven't found their way into the  
repository yet.

If you tell me which ones, maybe that will ring a bell over here.

Apologies in advance (if it turns out to be my fault... again :/)

Cheers

Andreas