You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Jonathan Young (JIRA)" <ji...@apache.org> on 2010/09/08 21:49:33 UTC

[jira] Commented: (MAHOUT-497) Matrix get/set causes allocation (?!)

    [ https://issues.apache.org/jira/browse/MAHOUT-497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907381#action_12907381 ] 

Jonathan Young commented on MAHOUT-497:
---------------------------------------

Are you planning on creating the integer array once, by adding int[] cardinality to AbstractMatrix, or did you have another solution in mind?

> Matrix get/set causes allocation (?!)
> -------------------------------------
>
>                 Key: MAHOUT-497
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-497
>             Project: Mahout
>          Issue Type: Bug
>            Reporter: Ted Dunning
>
> Matrix get and set check the array bounds.  But checking the array bounds calls size.  But size allocates a small integer
> array.
> This is evil and KILLs performance.
> The first fix is to avoid this in SGD based classifiers.  Second will be a real change to the matrix routines to avoid the allocation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.