You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Phil Steitz <ph...@gmail.com> on 2010/11/26 18:14:33 UTC
Re: svn commit: r1039315 - in /commons/proper/math/trunk/src:
main/java/org/apache/commons/math/linear/RealVector.java site/xdoc/changes.xml
The deprecations below are in the wrong source tree. They need to be
applied to the 2.x branch and unless it is just as a signal to those
building (dangerously) from trunk, I do not see the point of deprecating in
the 3.0 branch.
I am -0 on applying these to the 3.0 branch, since the code should be
removed before release (i.e., the code should simply be removed in the 3.0
branch) and -1 on applying them to 3.0 without first applying to 2.x.
Please either apply to 2.x or revert.
Phil
On Fri, Nov 26, 2010 at 6:27 AM, <er...@apache.org> wrote:
> Author: erans
> Date: Fri Nov 26 11:27:49 2010
> New Revision: 1039315
>
> URL: http://svn.apache.org/viewvc?rev=1039315&view=rev
> Log:
> MATH-430
> Deprecated redundant methods in "RealVector" and "AbstractRealVector" (in
> package "linear").
>
> Modified:
>
> commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/RealVector.java
> commons/proper/math/trunk/src/site/xdoc/changes.xml
>
> Modified:
> commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/RealVector.java
> URL:
> http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/RealVector.java?rev=1039315&r1=1039314&r2=1039315&view=diff
>
> ==============================================================================
> ---
> commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/RealVector.java
> (original)
> +++
> commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/RealVector.java
> Fri Nov 26 11:27:49 2010
> @@ -250,6 +250,10 @@ public interface RealVector {
> *
> * @param d Operator value.
> * @return a mapped copy of the vector.
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #map(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapPow(double d);
>
> @@ -259,6 +263,10 @@ public interface RealVector {
> *
> * @param d Operator value.
> * @return the mapped vector.
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #mapToSelf(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapPowToSelf(double d);
>
> @@ -266,6 +274,10 @@ public interface RealVector {
> * Map the {@link Math#exp(double)} function to each entry.
> *
> * @return a mapped copy of the vector.
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #map(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapExp();
>
> @@ -274,12 +286,20 @@ public interface RealVector {
> * The instance is changed in-place.
> *
> * @return the mapped vector.
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #mapToSelf(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapExpToSelf();
>
> /**
> * Map the {@link Math#expm1(double)} function to each entry.
> * @return a vector containing the result of applying the function to
> each entry
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #map(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapExpm1();
>
> @@ -287,12 +307,20 @@ public interface RealVector {
> * Map the {@link Math#expm1(double)} function to each entry.
> * <p>The instance <strong>is</strong> changed by this method.</p>
> * @return for convenience, return this
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #mapToSelf(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapExpm1ToSelf();
>
> /**
> * Map the {@link Math#log(double)} function to each entry.
> * @return a vector containing the result of applying the function to
> each entry
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #map(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapLog();
>
> @@ -300,12 +328,20 @@ public interface RealVector {
> * Map the {@link Math#log(double)} function to each entry.
> * <p>The instance <strong>is</strong> changed by this method.</p>
> * @return for convenience, return this
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #mapToSelf(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapLogToSelf();
>
> /**
> * Map the {@link Math#log10(double)} function to each entry.
> * @return a vector containing the result of applying the function to
> each entry
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #map(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapLog10();
>
> @@ -313,12 +349,20 @@ public interface RealVector {
> * Map the {@link Math#log10(double)} function to each entry.
> * <p>The instance <strong>is</strong> changed by this method.</p>
> * @return for convenience, return this
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #mapToSelf(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapLog10ToSelf();
>
> /**
> * Map the {@link Math#log1p(double)} function to each entry.
> * @return a vector containing the result of applying the function to
> each entry
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #map(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapLog1p();
>
> @@ -326,12 +370,20 @@ public interface RealVector {
> * Map the {@link Math#log1p(double)} function to each entry.
> * <p>The instance <strong>is</strong> changed by this method.</p>
> * @return for convenience, return this
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #mapToSelf(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapLog1pToSelf();
>
> /**
> * Map the {@link Math#cosh(double)} function to each entry.
> * @return a vector containing the result of applying the function to
> each entry
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #map(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapCosh();
>
> @@ -339,12 +391,20 @@ public interface RealVector {
> * Map the {@link Math#cosh(double)} function to each entry.
> * <p>The instance <strong>is</strong> changed by this method.</p>
> * @return for convenience, return this
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #mapToSelf(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapCoshToSelf();
>
> /**
> * Map the {@link Math#sinh(double)} function to each entry.
> * @return a vector containing the result of applying the function to
> each entry
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #map(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapSinh();
>
> @@ -352,12 +412,20 @@ public interface RealVector {
> * Map the {@link Math#sinh(double)} function to each entry.
> * <p>The instance <strong>is</strong> changed by this method.</p>
> * @return for convenience, return this
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #mapToSelf(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapSinhToSelf();
>
> /**
> * Map the {@link Math#tanh(double)} function to each entry.
> * @return a vector containing the result of applying the function to
> each entry
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #map(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapTanh();
>
> @@ -365,12 +433,20 @@ public interface RealVector {
> * Map the {@link Math#tanh(double)} function to each entry.
> * <p>The instance <strong>is</strong> changed by this method.</p>
> * @return for convenience, return this
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #mapToSelf(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapTanhToSelf();
>
> /**
> * Map the {@link Math#cos(double)} function to each entry.
> * @return a vector containing the result of applying the function to
> each entry
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #map(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapCos();
>
> @@ -378,12 +454,20 @@ public interface RealVector {
> * Map the {@link Math#cos(double)} function to each entry.
> * <p>The instance <strong>is</strong> changed by this method.</p>
> * @return for convenience, return this
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #mapToSelf(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapCosToSelf();
>
> /**
> * Map the {@link Math#sin(double)} function to each entry.
> * @return a vector containing the result of applying the function to
> each entry
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #map(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapSin();
>
> @@ -391,12 +475,20 @@ public interface RealVector {
> * Map the {@link Math#sin(double)} function to each entry.
> * <p>The instance <strong>is</strong> changed by this method.</p>
> * @return for convenience, return this
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #mapToSelf(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapSinToSelf();
>
> /**
> * Map the {@link Math#tan(double)} function to each entry.
> * @return a vector containing the result of applying the function to
> each entry
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #map(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapTan();
>
> @@ -404,12 +496,20 @@ public interface RealVector {
> * Map the {@link Math#tan(double)} function to each entry.
> * <p>The instance <strong>is</strong> changed by this method.</p>
> * @return for convenience, return this
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #mapToSelf(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapTanToSelf();
>
> /**
> * Map the {@link Math#acos(double)} function to each entry.
> * @return a vector containing the result of applying the function to
> each entry
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #map(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapAcos();
>
> @@ -417,12 +517,20 @@ public interface RealVector {
> * Map the {@link Math#acos(double)} function to each entry.
> * <p>The instance <strong>is</strong> changed by this method.</p>
> * @return for convenience, return this
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #mapToSelf(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapAcosToSelf();
>
> /**
> * Map the {@link Math#asin(double)} function to each entry.
> * @return a vector containing the result of applying the function to
> each entry
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #map(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapAsin();
>
> @@ -430,12 +538,20 @@ public interface RealVector {
> * Map the {@link Math#asin(double)} function to each entry.
> * <p>The instance <strong>is</strong> changed by this method.</p>
> * @return for convenience, return this
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #mapToSelf(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapAsinToSelf();
>
> /**
> * Map the {@link Math#atan(double)} function to each entry.
> * @return a vector containing the result of applying the function to
> each entry
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #map(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapAtan();
>
> @@ -443,12 +559,20 @@ public interface RealVector {
> * Map the {@link Math#atan(double)} function to each entry.
> * <p>The instance <strong>is</strong> changed by this method.</p>
> * @return for convenience, return this
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #mapToSelf(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapAtanToSelf();
>
> /**
> * Map the 1/x function to each entry.
> * @return a vector containing the result of applying the function to
> each entry
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #map(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapInv();
>
> @@ -456,12 +580,20 @@ public interface RealVector {
> * Map the 1/x function to each entry.
> * <p>The instance <strong>is</strong> changed by this method.</p>
> * @return for convenience, return this
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #mapToSelf(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapInvToSelf();
>
> /**
> * Map the {@link Math#abs(double)} function to each entry.
> * @return a vector containing the result of applying the function to
> each entry
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #map(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapAbs();
>
> @@ -469,12 +601,20 @@ public interface RealVector {
> * Map the {@link Math#abs(double)} function to each entry.
> * <p>The instance <strong>is</strong> changed by this method.</p>
> * @return for convenience, return this
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #mapToSelf(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapAbsToSelf();
>
> /**
> * Map the {@link Math#sqrt(double)} function to each entry.
> * @return a vector containing the result of applying the function to
> each entry
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #map(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapSqrt();
>
> @@ -482,12 +622,20 @@ public interface RealVector {
> * Map the {@link Math#sqrt(double)} function to each entry.
> * <p>The instance <strong>is</strong> changed by this method.</p>
> * @return for convenience, return this
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #mapToSelf(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapSqrtToSelf();
>
> /**
> * Map the {@link Math#cbrt(double)} function to each entry.
> * @return a vector containing the result of applying the function to
> each entry
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #map(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapCbrt();
>
> @@ -495,12 +643,20 @@ public interface RealVector {
> * Map the {@link Math#cbrt(double)} function to each entry.
> * <p>The instance <strong>is</strong> changed by this method.</p>
> * @return for convenience, return this
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #mapToSelf(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapCbrtToSelf();
>
> /**
> * Map the {@link Math#ceil(double)} function to each entry.
> * @return a vector containing the result of applying the function to
> each entry
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #map(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapCeil();
>
> @@ -508,12 +664,20 @@ public interface RealVector {
> * Map the {@link Math#ceil(double)} function to each entry.
> * <p>The instance <strong>is</strong> changed by this method.</p>
> * @return for convenience, return this
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #mapToSelf(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapCeilToSelf();
>
> /**
> * Map the {@link Math#floor(double)} function to each entry.
> * @return a vector containing the result of applying the function to
> each entry
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #map(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapFloor();
>
> @@ -521,12 +685,20 @@ public interface RealVector {
> * Map the {@link Math#floor(double)} function to each entry.
> * <p>The instance <strong>is</strong> changed by this method.</p>
> * @return for convenience, return this
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #mapToSelf(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapFloorToSelf();
>
> /**
> * Map the {@link Math#rint(double)} function to each entry.
> * @return a vector containing the result of applying the function to
> each entry
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #map(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapRint();
>
> @@ -534,12 +706,20 @@ public interface RealVector {
> * Map the {@link Math#rint(double)} function to each entry.
> * <p>The instance <strong>is</strong> changed by this method.</p>
> * @return for convenience, return this
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #mapToSelf(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapRintToSelf();
>
> /**
> * Map the {@link Math#signum(double)} function to each entry.
> * @return a vector containing the result of applying the function to
> each entry
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #map(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapSignum();
>
> @@ -547,12 +727,20 @@ public interface RealVector {
> * Map the {@link Math#signum(double)} function to each entry.
> * <p>The instance <strong>is</strong> changed by this method.</p>
> * @return for convenience, return this
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #mapToSelf(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapSignumToSelf();
>
> /**
> * Map the {@link Math#ulp(double)} function to each entry.
> * @return a vector containing the result of applying the function to
> each entry
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #map(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapUlp();
>
> @@ -560,6 +748,10 @@ public interface RealVector {
> * Map the {@link Math#ulp(double)} function to each entry.
> * <p>The instance <strong>is</strong> changed by this method.</p>
> * @return for convenience, return this
> + * @deprecated in 2.2 (to be removed in 3.0). Please use
> + * {@link #mapToSelf(UnivariateRealFunction)} directly with
> + * the function classes in package
> + * {@link org.apache.commons.math.analysis.function}.
> */
> RealVector mapUlpToSelf();
>
>
> Modified: commons/proper/math/trunk/src/site/xdoc/changes.xml
> URL:
> http://svn.apache.org/viewvc/commons/proper/math/trunk/src/site/xdoc/changes.xml?rev=1039315&r1=1039314&r2=1039315&view=diff
>
> ==============================================================================
> --- commons/proper/math/trunk/src/site/xdoc/changes.xml (original)
> +++ commons/proper/math/trunk/src/site/xdoc/changes.xml Fri Nov 26 11:27:49
> 2010
> @@ -52,8 +52,15 @@ The <action> type attribute can be add,u
> If the output is not quite correct, check for invisible trailing
> spaces!
> -->
> <release version="3.0" date="TBD" description="TBD">
> + <action dev="erans" type="update" issue="MATH-430">
> + Replaced "ComposableFunction" and "BinaryFunction" (in package
> "analysis")
> + by a set of utilities in the new class "FunctionUtils" together
> with
> + independent function objects in the new "analysis.function"
> package.
> + Removed redundant "mapXxx" and "mapXxxToSelf" methods in
> "RealVector" and
> + "AbstractRealVector" (in package "linear").
> + </action>
> <action dev="erans" type="update" issue="MATH-439">
> - Refacoring of the "analysis.solvers" package.
> + Refactoring of the "analysis.solvers" package.
> </action>
> <action dev="luc" type="fix" issue="MATH-380">
> Removed the ode.jacobians package.
>
>
>
Re: svn commit: r1039315 - in /commons/proper/math/trunk/src:
main/java/org/apache/commons/math/linear/RealVector.java site/xdoc/changes.xml
Posted by Phil Steitz <ph...@gmail.com>.
On Fri, Nov 26, 2010 at 4:38 PM, Gilles Sadowski <
gilles@harfang.homelinux.org> wrote:
> > > > The deprecations below are in the wrong source tree. They need to
> be
> > > > applied to the 2.x branch and unless it is just as a signal to those
> > > > building (dangerously) from trunk, I do not see the point of
> deprecating
> > > in
> > > > the 3.0 branch.
> > >
> > > This was done on purpose, in order to have one revision containing the
> > > deprecation message before actually removing the code.
> > > That way, someone can possibly get the files with the deprecation tags
> > > and copy them over to the 2.x branch.
> > >
> >
> > So these are new files added only to the 3.0 branch? In that case, no
> need
> > to deprecate as they have never been released. But looking carefully at
> > the commit, I can see these are at least mostly 2.1 methods, so they
> > *should* be deprecated in the 2.x branch.
>
> Of course, the "RealVector" existed. Why would I deprecate new code???
>
> Granted, the methods to be removed should be deprecated, but I take
> "should"
> as "Ideally, if I had the time, I would do it".
>
> > >
> > > > I am -0 on applying these to the 3.0 branch, since the code should be
> > > > removed before release (i.e., the code should simply be removed in
> the
> > > 3.0
> > > > branch) and -1 on applying them to 3.0 without first applying to 2.x.
> > > > Please either apply to 2.x or revert.
> > >
> > > Revert what?
> > >
> >
> > I meant revert the commit.
>
> OK, I don't follow; but I surely hope that you didn't mean that we should
> keep the deprecated classes in 3.0.
>
> >
> > >
> > > I'll copy the files as suggested above, but the information in there
> will
> > > be
> > > inconsistent (e.g. the replacement classes are *not* in the branch).
> >
> >
> > In that case, there is no need to deprecate in either branch, but in at
> > least most cases in this commit, the deprecated methods exist in 2.1,
> which
> > means they should be deprecated in the 2.2 release.
>
> The first part of this sentence, I don't get either.
>
> > > Luc
> > > already said that it was a nightmare to keep the branches in sync. [I
> do
> > > not
> > > have time for that. I mean: I do not have time for that.]
> > > Luc also indicated that 2.2 will/should be considered as a maintenance
> > > release: Users will be able to stick with 2.2 or upgrade to 3.0, but
> will
> > > not be able able to make all their code compatible with 3.0 while
> running
> > > on
> > > 2.2.
> > >
> >
> > I agree with that. We have also agreed that we should try as best we can
> to
> > deprecate the methods and classes that are going to be removed in 3.0.
> It
> > makes no sense to do those deprecations in the 3.0 source tree without
> > applying them to the 2.x branch as that is the branch that will form the
> > basis for the release that should contain the deprecations. If you have
> no
> > time to do the deprecations in the proper branch, then don't waste time
> > doing them in the 3.0 branch. It will be even more confusing to users
> when
> > they mysteriously vanish when you subsequently remove the code in the 3.0
> > branch and Luc or I miss the clean up in preparing the 2.2 release.
> >
> > Lets agree to either fully deprecate as we remove things of just remove
> code
> > and leave the cleanup to the lucky RM for 2.2.
>
> OK. I'm sorry that I misinterpreted your insistence on "micro-commits". I
> thought that you'd find it useful to have reference (through the commit log
> email) indicating that some methods X were deprecated in revision Y (and
> moreover, that revision Y contains only that particular change, and
> furthemore that the deprecation message indicates what replaces the
> deprecated code).
>
> Now, if you are satisfied with a terse '@deprecated' in the 2.2 branch and
> an immediate disappearance in 3.0, that's prefectly fine with me; that
> makes
> more sense and less work.
>
>
Sorry, that's what I meant and I misunderstood what you were saying above
about new code - you were referring to the replacement methods. Sorry I
misunderstood. In any case, I still think it only makes sense to deprecate
in a release prior to the one that removes the code, so I would say yes,
just remove the code in 3.0 and try to do the deprecations in 2.2. In some
cases, the message can only say the method is going to be removed.
Phil
>
> Gilles
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: svn commit: r1039315 - in /commons/proper/math/trunk/src:
main/java/org/apache/commons/math/linear/RealVector.java
site/xdoc/changes.xml
Posted by Gilles Sadowski <gi...@harfang.homelinux.org>.
> > > The deprecations below are in the wrong source tree. They need to be
> > > applied to the 2.x branch and unless it is just as a signal to those
> > > building (dangerously) from trunk, I do not see the point of deprecating
> > in
> > > the 3.0 branch.
> >
> > This was done on purpose, in order to have one revision containing the
> > deprecation message before actually removing the code.
> > That way, someone can possibly get the files with the deprecation tags
> > and copy them over to the 2.x branch.
> >
>
> So these are new files added only to the 3.0 branch? In that case, no need
> to deprecate as they have never been released. But looking carefully at
> the commit, I can see these are at least mostly 2.1 methods, so they
> *should* be deprecated in the 2.x branch.
Of course, the "RealVector" existed. Why would I deprecate new code???
Granted, the methods to be removed should be deprecated, but I take "should"
as "Ideally, if I had the time, I would do it".
> >
> > > I am -0 on applying these to the 3.0 branch, since the code should be
> > > removed before release (i.e., the code should simply be removed in the
> > 3.0
> > > branch) and -1 on applying them to 3.0 without first applying to 2.x.
> > > Please either apply to 2.x or revert.
> >
> > Revert what?
> >
>
> I meant revert the commit.
OK, I don't follow; but I surely hope that you didn't mean that we should
keep the deprecated classes in 3.0.
>
> >
> > I'll copy the files as suggested above, but the information in there will
> > be
> > inconsistent (e.g. the replacement classes are *not* in the branch).
>
>
> In that case, there is no need to deprecate in either branch, but in at
> least most cases in this commit, the deprecated methods exist in 2.1, which
> means they should be deprecated in the 2.2 release.
The first part of this sentence, I don't get either.
> > Luc
> > already said that it was a nightmare to keep the branches in sync. [I do
> > not
> > have time for that. I mean: I do not have time for that.]
> > Luc also indicated that 2.2 will/should be considered as a maintenance
> > release: Users will be able to stick with 2.2 or upgrade to 3.0, but will
> > not be able able to make all their code compatible with 3.0 while running
> > on
> > 2.2.
> >
>
> I agree with that. We have also agreed that we should try as best we can to
> deprecate the methods and classes that are going to be removed in 3.0. It
> makes no sense to do those deprecations in the 3.0 source tree without
> applying them to the 2.x branch as that is the branch that will form the
> basis for the release that should contain the deprecations. If you have no
> time to do the deprecations in the proper branch, then don't waste time
> doing them in the 3.0 branch. It will be even more confusing to users when
> they mysteriously vanish when you subsequently remove the code in the 3.0
> branch and Luc or I miss the clean up in preparing the 2.2 release.
>
> Lets agree to either fully deprecate as we remove things of just remove code
> and leave the cleanup to the lucky RM for 2.2.
OK. I'm sorry that I misinterpreted your insistence on "micro-commits". I
thought that you'd find it useful to have reference (through the commit log
email) indicating that some methods X were deprecated in revision Y (and
moreover, that revision Y contains only that particular change, and
furthemore that the deprecation message indicates what replaces the
deprecated code).
Now, if you are satisfied with a terse '@deprecated' in the 2.2 branch and
an immediate disappearance in 3.0, that's prefectly fine with me; that makes
more sense and less work.
Gilles
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1039315 - in /commons/proper/math/trunk/src:
main/java/org/apache/commons/math/linear/RealVector.java site/xdoc/changes.xml
Posted by Phil Steitz <ph...@gmail.com>.
On Fri, Nov 26, 2010 at 12:49 PM, Gilles Sadowski <
gilles@harfang.homelinux.org> wrote:
> On Fri, Nov 26, 2010 at 12:14:33PM -0500, Phil Steitz wrote:
> > The deprecations below are in the wrong source tree. They need to be
> > applied to the 2.x branch and unless it is just as a signal to those
> > building (dangerously) from trunk, I do not see the point of deprecating
> in
> > the 3.0 branch.
>
> This was done on purpose, in order to have one revision containing the
> deprecation message before actually removing the code.
> That way, someone can possibly get the files with the deprecation tags
> and copy them over to the 2.x branch.
>
So these are new files added only to the 3.0 branch? In that case, no need
to deprecate as they have never been released. But looking carefully at
the commit, I can see these are at least mostly 2.1 methods, so they
*should* be deprecated in the 2.x branch.
>
> > I am -0 on applying these to the 3.0 branch, since the code should be
> > removed before release (i.e., the code should simply be removed in the
> 3.0
> > branch) and -1 on applying them to 3.0 without first applying to 2.x.
> > Please either apply to 2.x or revert.
>
> Revert what?
>
I meant revert the commit.
>
> I'll copy the files as suggested above, but the information in there will
> be
> inconsistent (e.g. the replacement classes are *not* in the branch).
In that case, there is no need to deprecate in either branch, but in at
least most cases in this commit, the deprecated methods exist in 2.1, which
means they should be deprecated in the 2.2 release.
Luc
> already said that it was a nightmare to keep the branches in sync. [I do
> not
> have time for that. I mean: I do not have time for that.]
> Luc also indicated that 2.2 will/should be considered as a maintenance
> release: Users will be able to stick with 2.2 or upgrade to 3.0, but will
> not be able able to make all their code compatible with 3.0 while running
> on
> 2.2.
>
I agree with that. We have also agreed that we should try as best we can to
deprecate the methods and classes that are going to be removed in 3.0. It
makes no sense to do those deprecations in the 3.0 source tree without
applying them to the 2.x branch as that is the branch that will form the
basis for the release that should contain the deprecations. If you have no
time to do the deprecations in the proper branch, then don't waste time
doing them in the 3.0 branch. It will be even more confusing to users when
they mysteriously vanish when you subsequently remove the code in the 3.0
branch and Luc or I miss the clean up in preparing the 2.2 release.
Lets agree to either fully deprecate as we remove things of just remove code
and leave the cleanup to the lucky RM for 2.2.
Phil
>
>
> Gilles
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: svn commit: r1039315 - in /commons/proper/math/trunk/src:
main/java/org/apache/commons/math/linear/RealVector.java
site/xdoc/changes.xml
Posted by Gilles Sadowski <gi...@harfang.homelinux.org>.
On Fri, Nov 26, 2010 at 12:14:33PM -0500, Phil Steitz wrote:
> The deprecations below are in the wrong source tree. They need to be
> applied to the 2.x branch and unless it is just as a signal to those
> building (dangerously) from trunk, I do not see the point of deprecating in
> the 3.0 branch.
This was done on purpose, in order to have one revision containing the
deprecation message before actually removing the code.
That way, someone can possibly get the files with the deprecation tags
and copy them over to the 2.x branch.
> I am -0 on applying these to the 3.0 branch, since the code should be
> removed before release (i.e., the code should simply be removed in the 3.0
> branch) and -1 on applying them to 3.0 without first applying to 2.x.
> Please either apply to 2.x or revert.
Revert what?
I'll copy the files as suggested above, but the information in there will be
inconsistent (e.g. the replacement classes are *not* in the branch). Luc
already said that it was a nightmare to keep the branches in sync. [I do not
have time for that. I mean: I do not have time for that.]
Luc also indicated that 2.2 will/should be considered as a maintenance
release: Users will be able to stick with 2.2 or upgrade to 3.0, but will
not be able able to make all their code compatible with 3.0 while running on
2.2.
Gilles
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org