You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openmeetings.apache.org by Maxim Solodovnik <so...@gmail.com> on 2020/05/11 12:28:27 UTC
Re: [openmeetings] 01/01: OPENMEETINGS-2347 Fix to apply width based
on sidebar same as in room.
Hello Sebastian,
this change is useless
the exact same variable is already defined
https://github.com/apache/openmeetings/blob/master/openmeetings-web/src/main/webapp/css/raw-variables.css#L47
please revert your change
Thanks :)
On Sun, 10 May 2020 at 06:46, <se...@apache.org> wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> sebawagner pushed a commit to branch
> feature/OPENMEETINGS-2347-fix-recording-ui-cut-files-when-nested
> in repository https://gitbox.apache.org/repos/asf/openmeetings.git
>
> commit 6a37b42aa5736026dba553e20f3e544210dc095a
> Author: Sebastian Wagner <se...@apache.org>
> AuthorDate: Sun May 10 11:46:11 2020 +1200
>
> OPENMEETINGS-2347 Fix to apply width based on sidebar same as in room.
> ---
> openmeetings-web/src/main/webapp/css/raw-variables.css | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/openmeetings-web/src/main/webapp/css/raw-variables.css
> b/openmeetings-web/src/main/webapp/css/raw-variables.css
> index 55b38dc..eac09f9 100644
> --- a/openmeetings-web/src/main/webapp/css/raw-variables.css
> +++ b/openmeetings-web/src/main/webapp/css/raw-variables.css
> @@ -4,6 +4,7 @@ body {
> --menu-height: 36px;
> --level-color: #ADFF2F;
> --rooms-header-height: 70px;
> + --room-sidebar-width: 315px;
> --tabs-height: 45px;
> --buffer-size: 4px;
> --menu-zindex: 10000000;
>
>
--
Best regards,
Maxim
Re: [openmeetings] 01/01: OPENMEETINGS-2347 Fix to apply width based
on sidebar same as in room.
Posted by Maxim Solodovnik <so...@gmail.com>.
Just saw the PR
this issue shouldn't be fixed like this
code duplications are bad
since variable is no more for room only
it should be
1) renamed
2) moved to `body` (NOT copied)
something like this
On Mon, 11 May 2020 at 19:28, Maxim Solodovnik <so...@gmail.com> wrote:
> Hello Sebastian,
>
> this change is useless
> the exact same variable is already defined
> https://github.com/apache/openmeetings/blob/master/openmeetings-web/src/main/webapp/css/raw-variables.css#L47
>
> please revert your change
>
> Thanks :)
>
> On Sun, 10 May 2020 at 06:46, <se...@apache.org> wrote:
>
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> sebawagner pushed a commit to branch
>> feature/OPENMEETINGS-2347-fix-recording-ui-cut-files-when-nested
>> in repository https://gitbox.apache.org/repos/asf/openmeetings.git
>>
>> commit 6a37b42aa5736026dba553e20f3e544210dc095a
>> Author: Sebastian Wagner <se...@apache.org>
>> AuthorDate: Sun May 10 11:46:11 2020 +1200
>>
>> OPENMEETINGS-2347 Fix to apply width based on sidebar same as in room.
>> ---
>> openmeetings-web/src/main/webapp/css/raw-variables.css | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/openmeetings-web/src/main/webapp/css/raw-variables.css
>> b/openmeetings-web/src/main/webapp/css/raw-variables.css
>> index 55b38dc..eac09f9 100644
>> --- a/openmeetings-web/src/main/webapp/css/raw-variables.css
>> +++ b/openmeetings-web/src/main/webapp/css/raw-variables.css
>> @@ -4,6 +4,7 @@ body {
>> --menu-height: 36px;
>> --level-color: #ADFF2F;
>> --rooms-header-height: 70px;
>> + --room-sidebar-width: 315px;
>> --tabs-height: 45px;
>> --buffer-size: 4px;
>> --menu-zindex: 10000000;
>>
>>
>
> --
> Best regards,
> Maxim
>
--
Best regards,
Maxim