[GitHub] [doris] platoneko commented on a diff in pull request #16767: [improvement](filecache) split file cache into sharding directories

["platoneko (via GitHub)" <gi...@apache.org>]

platoneko commented on code in PR #16767:
URL: https://github.com/apache/doris/pull/16767#discussion_r1107093171


##########
be/src/io/cache/block/block_file_cache.cpp:
##########
@@ -32,6 +32,9 @@ namespace fs = std::filesystem;
 namespace doris {
 namespace io {
 
+const std::string IFileCache::FILE_CACHE_VERSION = "2.0";
+const int IFileCache::KEY_PREFIX_LENGTH = 3;

Review Comment:
   `const` -> `constexpr` is better



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org