[GitHub] [spark] juliuszsompolski commented on pull request #42910: [SPARK-45133][CONNECT][TESTS][FOLLOWUP] Add test that queries transition to FINISHED

["juliuszsompolski (via GitHub)" <gi...@apache.org>]

juliuszsompolski commented on PR #42910:
URL: https://github.com/apache/spark/pull/42910#issuecomment-1719182176

   @jdesjean hm, I guess for this thing, it would be possible to test in SparkServiceSuite...
   The difference between this and SparkServiceSuite is that this uses a real client sending requests via RPCs to the server, while SparkServiceSuite is creating mock requests, and calling the server side RPC handlers directly with these request...
   
   > However, it seems difficult because executePlan is blocking.
   
   This is no longer true with reattachable execute (reattachable execute gets the RPC stream be handled by another thread), so theoretically this could be used. Even without reattachable execute, it could just launch it in a future.
   I'll take a look, you're right that it might fit better there.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org