[GitHub] [accumulo] ctubbsii commented on pull request #2834: Provide getProperties method on Configuration that does not filter

[GitBox <gi...@apache.org>]

ctubbsii commented on PR #2834:
URL: https://github.com/apache/accumulo/pull/2834#issuecomment-1208342963

   > It's being used in `AccumuloConfiguration.get(String)` and `AccumuloConfiguration.iterator`
   
   That was a big code change for such a small convenience, I think. It doesn't save from having to iterate over the properties in `AccumuloConfiguration.get(String)` case, either. And, in the `AccumuloConfiguration.iterator` case, I think there's a bug, because `getProperties(entries)` there now seems equivalent to `getProperties(entries, x -> false);` instead of `getProperties(entries, x -> true);`.
   
   In the best case scenario, it seems we're avoiding constructing a Predicate in two places in internal code in favor of constructing a varargs arrays instead. I'm not sure that's better in terms of performance, and there's a lot more code to get the job done. Overall, I don't think this change was better than what was there before.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org