You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sqoop.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2011/11/17 19:41:51 UTC

[jira] [Commented] (SQOOP-393) Class SqoopOptions was not properly moved

    [ https://issues.apache.org/jira/browse/SQOOP-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152201#comment-13152201 ] 

jiraposter@reviews.apache.org commented on SQOOP-393:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2874/
-----------------------------------------------------------

Review request for Sqoop and Arvind Prabhakar.


Summary
-------

I've moved the functionality like we did with other classes.


This addresses bug SQOOP-393.
    https://issues.apache.org/jira/browse/SQOOP-393


Diffs
-----

  /src/java/com/cloudera/sqoop/SqoopOptions.java 1201319 
  /src/java/org/apache/sqoop/SqoopOptions.java 1201319 

Diff: https://reviews.apache.org/r/2874/diff


Testing
-------

I've passed basic tests.


Thanks,

Jarek


                
> Class SqoopOptions was not properly moved
> -----------------------------------------
>
>                 Key: SQOOP-393
>                 URL: https://issues.apache.org/jira/browse/SQOOP-393
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.4.0-incubating
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>
> Currently SqoopOptions classes in both namespaces (com.cloudera.sqoop and org.apache.sqoop) have the same implementation (looks like file copy with just few changes). We did not moved the functionality to org.apache.sqoop and set up inheritance to com.cloudera.sqoop namespace as we did with other classes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira