You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/20 08:50:48 UTC
[GitHub] [flink] ysn2233 opened a new pull request #12726: [FLINK-14938][Connectors / ElasticSearch] Fix ConcurrentModificationException when Flink elasticsearch failure handler re-add indexrequest
ysn2233 opened a new pull request #12726:
URL: https://github.com/apache/flink/pull/12726
## What is the purpose of the change
Fix to avoid ConcurrentModificationException when Flink elasticsearch failure handler re-add indexrequest
## Brief change log
- Use ConcurrentLinkedQueue to maintain bufferRequests in BufferingNoOpRequestIndexer instead of List
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12726: [FLINK-14938][Connectors / ElasticSearch] Fix ConcurrentModificationException when Flink elasticsearch failure handler re-add indexrequest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12726:
URL: https://github.com/apache/flink/pull/12726#issuecomment-646966672
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "deb6e05232bf7acdd8b12d1d901f61bfed4a9b31",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3859",
"triggerID" : "deb6e05232bf7acdd8b12d1d901f61bfed4a9b31",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* deb6e05232bf7acdd8b12d1d901f61bfed4a9b31 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3859)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12726: [FLINK-14938][Connectors / ElasticSearch] Fix ConcurrentModificationException when Flink elasticsearch failure handler re-add indexrequest
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12726:
URL: https://github.com/apache/flink/pull/12726#issuecomment-646966672
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "deb6e05232bf7acdd8b12d1d901f61bfed4a9b31",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "deb6e05232bf7acdd8b12d1d901f61bfed4a9b31",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* deb6e05232bf7acdd8b12d1d901f61bfed4a9b31 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #12726: [FLINK-14938][Connectors / ElasticSearch] Fix ConcurrentModificationException when Flink elasticsearch failure handler re-add indexrequest
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12726:
URL: https://github.com/apache/flink/pull/12726#issuecomment-648712852
Thanks a lot for your fix! I merged 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ysn2233 commented on pull request #12726: [FLINK-14938][Connectors / ElasticSearch] Fix ConcurrentModificationException when Flink elasticsearch failure handler re-add indexrequest
Posted by GitBox <gi...@apache.org>.
ysn2233 commented on pull request #12726:
URL: https://github.com/apache/flink/pull/12726#issuecomment-648556586
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha closed pull request #12726: [FLINK-14938][Connectors / ElasticSearch] Fix ConcurrentModificationException when Flink elasticsearch failure handler re-add indexrequest
Posted by GitBox <gi...@apache.org>.
aljoscha closed pull request #12726:
URL: https://github.com/apache/flink/pull/12726
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ysn2233 removed a comment on pull request #12726: [FLINK-14938][Connectors / ElasticSearch] Fix ConcurrentModificationException when Flink elasticsearch failure handler re-add indexrequest
Posted by GitBox <gi...@apache.org>.
ysn2233 removed a comment on pull request #12726:
URL: https://github.com/apache/flink/pull/12726#issuecomment-648169158
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #12726: [FLINK-14938][Connectors / ElasticSearch] Fix ConcurrentModificationException when Flink elasticsearch failure handler re-add indexrequest
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12726:
URL: https://github.com/apache/flink/pull/12726#issuecomment-647621155
The build fails because of unused imports, could you please fix those.
Thanks for discovering this problem! I think the design is not optimal here because it can happen that during a batch we add more failed requests to the buffer. Ideally, we would have designed the sink in such a way that we can do things without a concurrent queue. However, I think with the current design it's ok to change it to a concurrent queue here.
Side node: I'm not 100 % sure this sink works correctly because of the many concurrent things going on. Not saying that there are problems, just that I don't know. 😅
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ysn2233 commented on pull request #12726: [FLINK-14938][Connectors / ElasticSearch] Fix ConcurrentModificationException when Flink elasticsearch failure handler re-add indexrequest
Posted by GitBox <gi...@apache.org>.
ysn2233 commented on pull request #12726:
URL: https://github.com/apache/flink/pull/12726#issuecomment-648670623
It's strange that CI test fails and the re-run command does not work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ysn2233 commented on pull request #12726: [FLINK-14938][Connectors / ElasticSearch] Fix ConcurrentModificationException when Flink elasticsearch failure handler re-add indexrequest
Posted by GitBox <gi...@apache.org>.
ysn2233 commented on pull request #12726:
URL: https://github.com/apache/flink/pull/12726#issuecomment-648169158
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #12726: [FLINK-14938][Connectors / ElasticSearch] Fix ConcurrentModificationException when Flink elasticsearch failure handler re-add indexrequest
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12726:
URL: https://github.com/apache/flink/pull/12726#issuecomment-648094983
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12726: [FLINK-14938][Connectors / ElasticSearch] Fix ConcurrentModificationException when Flink elasticsearch failure handler re-add indexrequest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12726:
URL: https://github.com/apache/flink/pull/12726#issuecomment-646966672
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "deb6e05232bf7acdd8b12d1d901f61bfed4a9b31",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3859",
"triggerID" : "deb6e05232bf7acdd8b12d1d901f61bfed4a9b31",
"triggerType" : "PUSH"
}, {
"hash" : "b62b537805ff8e3115bfaee1a5eb29c1b01cb447",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3933",
"triggerID" : "b62b537805ff8e3115bfaee1a5eb29c1b01cb447",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* deb6e05232bf7acdd8b12d1d901f61bfed4a9b31 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3859)
* b62b537805ff8e3115bfaee1a5eb29c1b01cb447 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3933)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12726: [FLINK-14938][Connectors / ElasticSearch] Fix ConcurrentModificationException when Flink elasticsearch failure handler re-add indexrequest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12726:
URL: https://github.com/apache/flink/pull/12726#issuecomment-646966672
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "deb6e05232bf7acdd8b12d1d901f61bfed4a9b31",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3859",
"triggerID" : "deb6e05232bf7acdd8b12d1d901f61bfed4a9b31",
"triggerType" : "PUSH"
}, {
"hash" : "b62b537805ff8e3115bfaee1a5eb29c1b01cb447",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b62b537805ff8e3115bfaee1a5eb29c1b01cb447",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* deb6e05232bf7acdd8b12d1d901f61bfed4a9b31 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3859)
* b62b537805ff8e3115bfaee1a5eb29c1b01cb447 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12726: [FLINK-14938][Connectors / ElasticSearch] Fix ConcurrentModificationException when Flink elasticsearch failure handler re-add indexrequest
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12726:
URL: https://github.com/apache/flink/pull/12726#issuecomment-646964960
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit deb6e05232bf7acdd8b12d1d901f61bfed4a9b31 (Sat Jun 20 08:53:04 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12726: [FLINK-14938][Connectors / ElasticSearch] Fix ConcurrentModificationException when Flink elasticsearch failure handler re-add indexrequest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12726:
URL: https://github.com/apache/flink/pull/12726#issuecomment-646966672
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "deb6e05232bf7acdd8b12d1d901f61bfed4a9b31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3859",
"triggerID" : "deb6e05232bf7acdd8b12d1d901f61bfed4a9b31",
"triggerType" : "PUSH"
}, {
"hash" : "b62b537805ff8e3115bfaee1a5eb29c1b01cb447",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3933",
"triggerID" : "b62b537805ff8e3115bfaee1a5eb29c1b01cb447",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b62b537805ff8e3115bfaee1a5eb29c1b01cb447 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3933)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #12726: [FLINK-14938][Connectors / ElasticSearch] Fix ConcurrentModificationException when Flink elasticsearch failure handler re-add indexrequest
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12726:
URL: https://github.com/apache/flink/pull/12726#issuecomment-648676566
No worries, I ran this on my Azure account: https://dev.azure.com/aljoschakrettek/Flink/_build/results?buildId=253&view=results
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org