[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #2597: [Bug] Modifications should be disabled when building a project (#2596)

["wolfboys (via GitHub)" <gi...@apache.org>]

wolfboys commented on code in PR #2597:
URL: https://github.com/apache/incubator-streampark/pull/2597#discussion_r1163606706


##########
streampark-console/streampark-console-webapp/src/views/flink/project/components/ListItem.vue:
##########
@@ -89,13 +89,18 @@
             </a-button>
           </a-popconfirm>
         </a-tooltip>
+        <a-tooltip :title="t('flink.project.operationTips.updateProject')">

Review Comment:
   We need to judge whether the buildState of the current job is building, if building, disable edit button or edit button not display, else it is allowed to update



##########
streampark-console/streampark-console-webapp/src/views/flink/project/components/ListItem.vue:
##########
@@ -89,13 +89,18 @@
             </a-button>
           </a-popconfirm>
         </a-tooltip>
+        <a-tooltip :title="t('flink.project.operationTips.updateProject')">
+          <a-button v-auth="'project:update'" @click="handleEdit" shape="circle" class="ml-8px">
+            <EditOutlined />
+          </a-button>
+        </a-tooltip>
       </template>
 
-      <a-tooltip :title="t('flink.project.operationTips.updateProject')">
-        <a-button v-auth="'project:update'" @click="handleEdit" shape="circle" class="ml-8px">
-          <EditOutlined />
-        </a-button>
-      </a-tooltip>
+<!--      <a-tooltip :title="t('flink.project.operationTips.updateProject')">-->

Review Comment:
   What's this？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org