You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/26 12:57:18 UTC
[GitHub] [airflow] potiuk opened a new pull request #21126: Test local reusable workflows
potiuk opened a new pull request #21126:
URL: https://github.com/apache/airflow/pull/21126
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #21126: Test local reusable workflows
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #21126:
URL: https://github.com/apache/airflow/pull/21126#discussion_r792622726
##########
File path: .github/workflows/ci.yml
##########
@@ -247,20 +247,14 @@ jobs:
steps.selective-checks.outputs.default-branch == 'main'
run-new-breeze-tests:
+ uses: ./.github/workflows/setup-environment.yml
Review comment:
This does not work... :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21126: Test local reusable workflows
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21126:
URL: https://github.com/apache/airflow/pull/21126#issuecomment-1022185425
HEy @ashb @TobKed dragged my attention that yesterday GitHub released https://github.blog/changelog/2022-01-25-github-actions-reusable-workflows-can-be-referenced-locally/
I had hopes (instead of anchor support) - unfirtunately you cannot connect "steps" and "reusable workflow" in one job :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #21126: Test local reusable workflows
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #21126:
URL: https://github.com/apache/airflow/pull/21126#issuecomment-1022185425
HEy @ashb - @TobKed dragged my attention that yesterday GitHub released https://github.blog/changelog/2022-01-25-github-actions-reusable-workflows-can-be-referenced-locally/
I had hopes (instead of anchor support) - unfirtunately you cannot connect "steps" and "reusable workflow" in one job :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #21126: Test local reusable workflows
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #21126:
URL: https://github.com/apache/airflow/pull/21126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #21126: Test local reusable workflows
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #21126:
URL: https://github.com/apache/airflow/pull/21126#discussion_r792622343
##########
File path: .github/workflows/setup-environment.yml
##########
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+---
+on: # yamllint disable-line rule:truthy
+ workflow_call:
+ input:
+ runs-on:
+ required: true
+ type: string
+jobs:
+ prepare_environment:
+ runs-on: ${{ inputs.runs-on }}
+ steps:
+ - uses: actions/checkout@v2
+ with:
+ persist-credentials: false
+ - uses: actions/setup-python@v2
+ with:
+ python-version: ${{ needs.build-info.outputs.defaultPythonVersion }}
+ cache: 'pip'
+ cache-dependency-path: ./dev/breeze/setup*
+ - run: python -m pip install --editable ./dev/breeze/
Review comment:
That does not work :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org