[jira] [Commented] (TAJO-1464) Add ORCFileScanner to read ORCFile table

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAJO-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14623715#comment-14623715 ] 

ASF GitHub Bot commented on TAJO-1464:
--------------------------------------

Github user blrunner commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/579#discussion_r34420046
  
    --- Diff: tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/orc/OrcScanner.java ---
    @@ -0,0 +1,257 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.tajo.storage.orc;
    +
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.fs.FSDataInputStream;
    +import org.apache.hadoop.fs.FileSystem;
    +import org.apache.hadoop.fs.Path;
    +import org.apache.tajo.catalog.Schema;
    +import org.apache.tajo.catalog.TableMeta;
    +import org.apache.tajo.common.TajoDataTypes;
    +import org.apache.tajo.conf.TajoConf;
    +import org.apache.tajo.datum.*;
    +import org.apache.tajo.exception.UnsupportedException;
    +import org.apache.tajo.plan.expr.EvalNode;
    +import org.apache.tajo.storage.FileScanner;
    +import org.apache.tajo.storage.Tuple;
    +import org.apache.tajo.storage.VTuple;
    +import org.apache.tajo.storage.fragment.Fragment;
    +import com.facebook.presto.orc.*;
    +import com.facebook.presto.orc.metadata.ColumnStatistics;
    +import com.facebook.presto.orc.metadata.OrcMetadataReader;
    +import org.apache.tajo.storage.thirdparty.orc.HdfsOrcDataSource;
    +import org.apache.tajo.util.datetime.DateTimeUtil;
    +import org.joda.time.DateTimeZone;
    +
    +import java.io.IOException;
    +import java.util.HashSet;
    +import java.util.Map;
    +import java.util.Set;
    +
    +/**
    + * OrcScanner for reading ORC files
    + */
    +public class OrcScanner extends FileScanner {
    --- End diff --
    
    How about renaming it ORCScanner? Currently, the scanner for RCFile is named RCScanner.


> Add ORCFileScanner to read ORCFile table
> ----------------------------------------
>
>                 Key: TAJO-1464
>                 URL: https://issues.apache.org/jira/browse/TAJO-1464
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: Storage
>    Affects Versions: 0.10.0
>            Reporter: Dongjoon Hyun
>            Assignee: Jongyoung Park
>             Fix For: 0.11.0
>
>         Attachments: TAJO-1464.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)