You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Jarek Gawor (JIRA)" <ji...@apache.org> on 2008/08/26 22:38:46 UTC

[jira] Created: (CXF-1766) handler chain wildcard matching does not quite work

handler chain wildcard matching does not quite work
---------------------------------------------------

                 Key: CXF-1766
                 URL: https://issues.apache.org/jira/browse/CXF-1766
             Project: CXF
          Issue Type: Bug
          Components: JAX-WS Runtime
    Affects Versions: 2.1.3, 2.2
            Reporter: Jarek Gawor


In AnnotationHandlerChainBuilder the following wildcard check is done:

        if (localPart.contains("*")) {
            //wildcard pattern matching
            return Pattern.matches(localPart, comp.getLocalPart());
        ...

So, for example if localPart is "foo*", this check will only return true if comp.getLocalPart() returns "foo" followed by any number of o's but will return false on anything else even if the string starts with "foo". According to the spec the "foo*" should match any string starting with "foo", e.g. "fooBar", "fooCXF", etc. Looks like the "*" in the localPart need to be first converted into appropriate regex - e.g. localPart = localPart.replace("*", ".*");


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CXF-1766) handler chain wildcard matching does not quite work

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp reassigned CXF-1766:
--------------------------------

    Assignee: Daniel Kulp

> handler chain wildcard matching does not quite work
> ---------------------------------------------------
>
>                 Key: CXF-1766
>                 URL: https://issues.apache.org/jira/browse/CXF-1766
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-WS Runtime
>    Affects Versions: 2.1.3, 2.2
>            Reporter: Jarek Gawor
>            Assignee: Daniel Kulp
>
> In AnnotationHandlerChainBuilder the following wildcard check is done:
>         if (localPart.contains("*")) {
>             //wildcard pattern matching
>             return Pattern.matches(localPart, comp.getLocalPart());
>         ...
> So, for example if localPart is "foo*", this check will only return true if comp.getLocalPart() returns "foo" followed by any number of o's but will return false on anything else even if the string starts with "foo". According to the spec the "foo*" should match any string starting with "foo", e.g. "fooBar", "fooCXF", etc. Looks like the "*" in the localPart need to be first converted into appropriate regex - e.g. localPart = localPart.replace("*", ".*");

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CXF-1766) handler chain wildcard matching does not quite work

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp resolved CXF-1766.
------------------------------

       Resolution: Fixed
    Fix Version/s: 2.2.1
                   2.1.5

> handler chain wildcard matching does not quite work
> ---------------------------------------------------
>
>                 Key: CXF-1766
>                 URL: https://issues.apache.org/jira/browse/CXF-1766
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-WS Runtime
>    Affects Versions: 2.1.3, 2.2
>            Reporter: Jarek Gawor
>            Assignee: Daniel Kulp
>             Fix For: 2.1.5, 2.2.1
>
>
> In AnnotationHandlerChainBuilder the following wildcard check is done:
>         if (localPart.contains("*")) {
>             //wildcard pattern matching
>             return Pattern.matches(localPart, comp.getLocalPart());
>         ...
> So, for example if localPart is "foo*", this check will only return true if comp.getLocalPart() returns "foo" followed by any number of o's but will return false on anything else even if the string starts with "foo". According to the spec the "foo*" should match any string starting with "foo", e.g. "fooBar", "fooCXF", etc. Looks like the "*" in the localPart need to be first converted into appropriate regex - e.g. localPart = localPart.replace("*", ".*");

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.