You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/06 14:33:01 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1374: gpio: extend gpio_pintype_e for pulldown/up and opendrain

xiaoxiang781216 commented on a change in pull request #1374:
URL: https://github.com/apache/incubator-nuttx/pull/1374#discussion_r450263394



##########
File path: include/nuttx/ioexpander/gpio.h
##########
@@ -100,8 +100,11 @@
 
 enum gpio_pintype_e
 {
-  GPIO_INPUT_PIN = 0,
-  GPIO_OUTPUT_PIN,
+  GPIO_INPUT_PIN = 0, /* float */
+  GPIO_INPUT_PIN_PULLUP,
+  GPIO_INPUT_PIN_PULLDOWN,
+  GPIO_OUTPUT_PIN, /* push-pull */
+  GPIO_OUTPUT_PIN_OPENDRAIN,

Review comment:
       Need update drivers/ioexpander/gpio_lower_half.c too. And I don't see the related defintion in include/nuttx/ioexpander/ioexpander.h, should we add them and translate gpio call to ioexpander call?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org