[GitHub] [airflow] potiuk edited a comment on issue #17489: Helm chart converts ' ' to '+' in passwords (and username)

[GitBox <gi...@apache.org>]

potiuk edited a comment on issue #17489:
URL: https://github.com/apache/airflow/issues/17489#issuecomment-899730815


   > If the above are true and if the argument is that the use of the helm chart should be 'intuitively' or 'naturally' the way Airflow does things (I'm extrapolating from your statement that kube should bend to Airflow), then it seems that the chart should be structured to look as close to Airflow directly as possible.
   
   You are extrapolating a bit more than what I wrote. Your assumptions do not take into account the audiences. I never said "human" providing the URL. I said "Secret" providing URL to Airflow. There is one more step between Human entering configuration and Secret Keeping it. The reason why you have it in helm chart, is because the Helm chart is for "Humans" to configure, while the "Secrets" is for "airflow" to consume. and for "Kubernetes" to store.  
   
   What the helm chart does - It takes "user" input and converts it (on the flight) to "URL" format that is stored in "Secret" if you look under the hood. I cannot imagine "human" by hand providing "Secret". This is established practice in K8S that you prepare Kubernetes Resources (including secrets) via some kind of templating engine (usually Go-templating based) to make it easier for  "Human" to provide the right values. This is what Helm Chart is doing and it uses the filters to convert the values.
   
   Similarly in Airflow we provide a tool: https://airflow.apache.org/docs/apache-airflow/stable/howto/connection.html#generating-a-connection-uri which allows Human to generate the URI to use by providing all the values separately.
   
   Same princilple. pretty consistently applied across the board.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org