You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/10/26 08:18:19 UTC

[GitHub] [iotdb] HTHou opened a new pull request #1860: [IOTDB-716] add lz4 doc

HTHou opened a new pull request #1860:
URL: https://github.com/apache/iotdb/pull/1860


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] samperson1997 commented on a change in pull request #1860: [IOTDB-716] add lz4 doc and support compression=lz4 statement

Posted by GitBox <gi...@apache.org>.
samperson1997 commented on a change in pull request #1860:
URL: https://github.com/apache/iotdb/pull/1860#discussion_r511883856



##########
File path: docs/SystemDesign/TsFile/Format.md
##########
@@ -55,6 +55,7 @@
 - **Compressing Type Hardcode**
   - 0: UNCOMPRESSED
   - 1: SNAPPY
+  - 7: LZ4

Review comment:
       Why `7`? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] HTHou commented on a change in pull request #1860: [IOTDB-716] add lz4 doc and support compression=lz4 statement

Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #1860:
URL: https://github.com/apache/iotdb/pull/1860#discussion_r511940926



##########
File path: docs/SystemDesign/TsFile/Format.md
##########
@@ -55,6 +55,7 @@
 - **Compressing Type Hardcode**
   - 0: UNCOMPRESSED
   - 1: SNAPPY
+  - 7: LZ4

Review comment:
       <img width="654" alt="Screen Shot 2020-10-26 at 9 00 39 PM" src="https://user-images.githubusercontent.com/25913899/97175339-53b4ed00-17ce-11eb-9b1a-4be90c5bf330.png">
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] HTHou merged pull request #1860: [IOTDB-716] add lz4 doc and support compression=lz4 statement

Posted by GitBox <gi...@apache.org>.
HTHou merged pull request #1860:
URL: https://github.com/apache/iotdb/pull/1860


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org