You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "felipecrv (via GitHub)" <gi...@apache.org> on 2025/07/25 14:22:18 UTC
[PR] chore(go/adbc/pkg): Run make regeneate to keep generated code in sync with templates [arrow-adbc]
felipecrv opened a new pull request, #3202:
URL: https://github.com/apache/arrow-adbc/pull/3202
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(go/adbc/pkg): Run make regeneate to keep generated code in sync with templates [arrow-adbc]
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on code in PR #3202:
URL: https://github.com/apache/arrow-adbc/pull/3202#discussion_r2231274601
##########
go/adbc/pkg/flightsql/init.go:
##########
@@ -32,5 +32,5 @@ import "C"
//export FlightSQLDriverInit
func FlightSQLDriverInit(version C.int, rawDriver *C.void, err *C.struct_AdbcError) C.AdbcStatusCode {
// For backwards compatibility
- return AdbcDriverFlightsqlInit(version, rawDriver, err)
+ return AdbcDriverFlightSQLInit(version, rawDriver, err)
Review Comment:
@zeroshade do I have to update mentions of the `AdbcDriverFlightsqlInit` string in other drivers?
```
$ git grep --name-only AdbcDriverFlightsqlInit
c/driver/flightsql/sqlite_flightsql_test.cc
c/include/arrow-adbc/driver/flightsql.h
c/integration/static_test/main.c
csharp/src/Drivers/Interop/FlightSql/FlightSqlDriverLoader.cs
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(go/adbc/pkg): Run make regeneate to keep generated code in sync with templates [arrow-adbc]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #3202:
URL: https://github.com/apache/arrow-adbc/pull/3202#discussion_r2231317987
##########
go/adbc/pkg/flightsql/init.go:
##########
@@ -32,5 +32,5 @@ import "C"
//export FlightSQLDriverInit
func FlightSQLDriverInit(version C.int, rawDriver *C.void, err *C.struct_AdbcError) C.AdbcStatusCode {
// For backwards compatibility
- return AdbcDriverFlightsqlInit(version, rawDriver, err)
+ return AdbcDriverFlightSQLInit(version, rawDriver, err)
Review Comment:
yea, the generation should be fixed so that it doesn't change `driver.go` to `AdbcDriverFlightSQLInit` and keeps it as `AdbcDriverFlightsqlInit` which is what is failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(go/adbc/pkg): Run make regeneate to keep generated code in sync with templates [arrow-adbc]
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on code in PR #3202:
URL: https://github.com/apache/arrow-adbc/pull/3202#discussion_r2231355597
##########
go/adbc/pkg/flightsql/init.go:
##########
@@ -32,5 +32,5 @@ import "C"
//export FlightSQLDriverInit
func FlightSQLDriverInit(version C.int, rawDriver *C.void, err *C.struct_AdbcError) C.AdbcStatusCode {
// For backwards compatibility
- return AdbcDriverFlightsqlInit(version, rawDriver, err)
+ return AdbcDriverFlightSQLInit(version, rawDriver, err)
Review Comment:
The 3 spellings of SQL:
- `SQL`
- `sql`
- `Sql`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(go/adbc/pkg): Run make regeneate to keep generated code in sync with templates [arrow-adbc]
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on code in PR #3202:
URL: https://github.com/apache/arrow-adbc/pull/3202#discussion_r2231281855
##########
go/adbc/pkg/flightsql/init.go:
##########
@@ -32,5 +32,5 @@ import "C"
//export FlightSQLDriverInit
func FlightSQLDriverInit(version C.int, rawDriver *C.void, err *C.struct_AdbcError) C.AdbcStatusCode {
// For backwards compatibility
- return AdbcDriverFlightsqlInit(version, rawDriver, err)
+ return AdbcDriverFlightSQLInit(version, rawDriver, err)
Review Comment:
Well... C# interop tests tell me yes :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(go/adbc/pkg): Run make regeneate to keep generated code in sync with templates [arrow-adbc]
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on code in PR #3202:
URL: https://github.com/apache/arrow-adbc/pull/3202#discussion_r2231376404
##########
go/adbc/pkg/flightsql/utils.c:
##########
@@ -431,16 +431,10 @@ AdbcStatusCode AdbcStatementSetOptionInt(struct AdbcStatement* statement,
ADBC_EXPORT
AdbcStatusCode AdbcDriverInit(int version, void* driver, struct AdbcError* error) {
- return AdbcDriverFlightsqlInit(version, driver, error);
+ return AdbcDriverFlightSQLInit(version, driver, error);
}
#endif // ADBC_NO_COMMON_ENTRYPOINTS
-ADBC_EXPORT
-AdbcStatusCode FlightSqlDriverInit(int version, void* driver, struct AdbcError* error) {
- // For backwards compatibility
- return AdbcDriverFlightsqlInit(version, driver, error);
-}
-
Review Comment:
The changes to `init.go` were needed to compensate for this removal of code that was manually added to this auto-generated C file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(go/adbc/pkg): Run make regenerate to keep generated code in sync with templates [arrow-adbc]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #3202:
URL: https://github.com/apache/arrow-adbc/pull/3202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(go/adbc/pkg): Run make regeneate to keep generated code in sync with templates [arrow-adbc]
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on code in PR #3202:
URL: https://github.com/apache/arrow-adbc/pull/3202#discussion_r2231376404
##########
go/adbc/pkg/flightsql/utils.c:
##########
@@ -431,16 +431,10 @@ AdbcStatusCode AdbcStatementSetOptionInt(struct AdbcStatement* statement,
ADBC_EXPORT
AdbcStatusCode AdbcDriverInit(int version, void* driver, struct AdbcError* error) {
- return AdbcDriverFlightsqlInit(version, driver, error);
+ return AdbcDriverFlightSQLInit(version, driver, error);
}
#endif // ADBC_NO_COMMON_ENTRYPOINTS
-ADBC_EXPORT
-AdbcStatusCode FlightSqlDriverInit(int version, void* driver, struct AdbcError* error) {
- // For backwards compatibility
- return AdbcDriverFlightsqlInit(version, driver, error);
-}
-
Review Comment:
The changes to `init.go` were needed to compensate for this removal of code that was previously manually added to this auto-generated C file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org