You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by anuruddhal <gi...@git.apache.org> on 2015/09/15 06:39:39 UTC

[GitHub] stratos pull request: Making signup button available only when app...

GitHub user anuruddhal opened a pull request:

    https://github.com/apache/stratos/pull/464

    Making signup button available only when application is active

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anuruddhal/stratos stratos-4.1.x_deploy

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/stratos/pull/464.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #464
    
----
commit 03e62736e93c2770f11c8e609a37016ae60bbdbe
Author: anuruddhal <an...@gmail.com>
Date:   2015-09-14T06:05:55Z

    Adding validation to addApplicationSignup

commit 56d86560d6b23cfa1b77a562128ef1b47554d09f
Author: anuruddhal <an...@gmail.com>
Date:   2015-09-15T04:34:39Z

    Making signup button available only when application is active

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] stratos pull request: Making signup button available only when app...

Posted by anuruddhal <gi...@git.apache.org>.
Github user anuruddhal commented on a diff in the pull request:

    https://github.com/apache/stratos/pull/464#discussion_r39479093
  
    --- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/util/converter/ObjectConverter.java ---
    @@ -1147,15 +1151,18 @@ public static ApplicationBean convertStubApplicationContextToApplicationDefiniti
             if (applicationContext == null) {
                 return null;
             }
    -
    +        Application application = ApplicationManager.getApplications().getApplication(applicationContext.getApplicationId());
             ApplicationBean applicationDefinition = new ApplicationBean();
             applicationDefinition.setApplicationId(applicationContext.getApplicationId());
             applicationDefinition.setAlias(applicationContext.getAlias());
             applicationDefinition.setMultiTenant(applicationContext.getMultiTenant());
             applicationDefinition.setName(applicationContext.getName());
             applicationDefinition.setDescription(applicationContext.getDescription());
    -        applicationDefinition.setStatus(applicationContext.getStatus());
    -
    +        if (application.getStatus().name().equals(APPLICATION_STATUS_ACTIVE)) {
    --- End diff --
    
    Fixed with commit 3d44e8de5e74669c6344e5b24d0589badd838840


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] stratos pull request: Making signup button available only when app...

Posted by anuruddhal <gi...@git.apache.org>.
Github user anuruddhal closed the pull request at:

    https://github.com/apache/stratos/pull/464


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] stratos pull request: Making signup button available only when app...

Posted by imesh <gi...@git.apache.org>.
Github user imesh commented on the pull request:

    https://github.com/apache/stratos/pull/464#issuecomment-141796334
  
    It would be better to close pull requests once merged.
    Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] stratos pull request: Making signup button available only when app...

Posted by ravihansa3000 <gi...@git.apache.org>.
Github user ravihansa3000 commented on the pull request:

    https://github.com/apache/stratos/pull/464#issuecomment-140290000
  
    #464 is closed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] stratos pull request: Making signup button available only when app...

Posted by ravihansa3000 <gi...@git.apache.org>.
Github user ravihansa3000 commented on the pull request:

    https://github.com/apache/stratos/pull/464#issuecomment-140289947
  
    Merged in 08433049e6fbf026287a6159bb4098c9b0e413b5 and b22bb362dc1aa3ff27c8389b526bbb579ff0ddc8


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] stratos pull request: Making signup button available only when app...

Posted by swgkg <gi...@git.apache.org>.
Github user swgkg commented on a diff in the pull request:

    https://github.com/apache/stratos/pull/464#discussion_r39477594
  
    --- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/util/converter/ObjectConverter.java ---
    @@ -1147,15 +1151,18 @@ public static ApplicationBean convertStubApplicationContextToApplicationDefiniti
             if (applicationContext == null) {
                 return null;
             }
    -
    +        Application application = ApplicationManager.getApplications().getApplication(applicationContext.getApplicationId());
             ApplicationBean applicationDefinition = new ApplicationBean();
             applicationDefinition.setApplicationId(applicationContext.getApplicationId());
             applicationDefinition.setAlias(applicationContext.getAlias());
             applicationDefinition.setMultiTenant(applicationContext.getMultiTenant());
             applicationDefinition.setName(applicationContext.getName());
             applicationDefinition.setDescription(applicationContext.getDescription());
    -        applicationDefinition.setStatus(applicationContext.getStatus());
    -
    +        if (application.getStatus().name().equals(APPLICATION_STATUS_ACTIVE)) {
    --- End diff --
    
    Can't we reuse the ApplicationStatus enum without declaring the additional constant of APPLICATION_STATUS_ACTIVE?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---