You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by ma...@apache.org on 2015/10/30 01:01:54 UTC
incubator-reef git commit: [REEF-880] Make logged and actual wait
time consistent in Name Lookup classes
Repository: incubator-reef
Updated Branches:
refs/heads/master a348df538 -> 49b16128e
[REEF-880] Make logged and actual wait time consistent in Name Lookup classes
Replaced the actual wait time with the time that was logged, as that seems to make more sense.
Now wait time increases linearly with the number of retries done.
JIRA:
[REEF-880](https://issues.apache.org/jira/browse/REEF-880)
Pull request:
Closes #599
Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/49b16128
Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/49b16128
Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/49b16128
Branch: refs/heads/master
Commit: 49b16128ec9a55983c04fba77338277461a7d7de
Parents: a348df5
Author: Brian Cho <ch...@apache.org>
Authored: Thu Oct 29 10:45:16 2015 +0900
Committer: Mariia Mykhailova <ma...@apache.org>
Committed: Thu Oct 29 16:59:50 2015 -0700
----------------------------------------------------------------------
.../org/apache/reef/io/network/naming/LocalNameResolverImpl.java | 2 +-
.../java/org/apache/reef/io/network/naming/NameLookupClient.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/49b16128/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/LocalNameResolverImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/LocalNameResolverImpl.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/LocalNameResolverImpl.java
index 1aa3de7..82b99c1 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/LocalNameResolverImpl.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/LocalNameResolverImpl.java
@@ -112,7 +112,7 @@ public final class LocalNameResolverImpl implements NameResolver {
"Caught Naming Exception while looking up " + id
+ " with Name Server. Will retry " + retriesLeft
+ " time(s) after waiting for " + retTimeout + " msec.");
- Thread.sleep(retTimeout * retriesLeft);
+ Thread.sleep(retTimeout);
--retriesLeft;
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/49b16128/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameLookupClient.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameLookupClient.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameLookupClient.java
index 48e7121..6105ce1 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameLookupClient.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameLookupClient.java
@@ -252,7 +252,7 @@ public class NameLookupClient implements Stage, NamingLookup {
"Caught Naming Exception while looking up " + id
+ " with Name Server. Will retry " + retriesLeft
+ " time(s) after waiting for " + currentRetryTimeout + " msec.");
- Thread.sleep(currentRetryTimeout * retriesLeft);
+ Thread.sleep(currentRetryTimeout);
--retriesLeft;
}
}