You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by "Qiang Zhang (JIRA)" <ji...@apache.org> on 2017/03/07 08:30:32 UTC

[jira] [Created] (RANGER-1425) Remove some duplicate codes

Qiang Zhang created RANGER-1425:
-----------------------------------

             Summary: Remove some duplicate codes
                 Key: RANGER-1425
                 URL: https://issues.apache.org/jira/browse/RANGER-1425
             Project: Ranger
          Issue Type: Bug
          Components: admin
    Affects Versions: 1.0.0
            Reporter: Qiang Zhang
            Assignee: Qiang Zhang
             Fix For: 1.0.0


There are some duplicate codes in this path: ranger\security-admin\src\main\java\org\apache\ranger\biz\XUserMgr.java
                searchCriteria = new SearchCriteria();
		searchCriteria.addParam("groupId", id);
		VXPermMapList vXPermMapList = searchXPermMaps(searchCriteria);

		searchCriteria = new SearchCriteria();
		searchCriteria.addParam("groupId", id);
		VXAuditMapList vXAuditMapList = searchXAuditMaps(searchCriteria);


                searchCriteria = new SearchCriteria();
		searchCriteria.addParam("userId", id);
		VXPermMapList vXPermMapList = searchXPermMaps(searchCriteria);

		searchCriteria = new SearchCriteria();
		searchCriteria.addParam("userId", id);
		VXAuditMapList vXAuditMapList = searchXAuditMaps(searchCriteria);

We don't need to new this object twice.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)