You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/01/23 20:41:10 UTC

[PR] [SPARK-54942][PYTHON][TESTS][FOLLOWUP] Add tests for pa.Array.cast of nested/container types [spark]

Yicong-Huang opened a new pull request, #53939:
URL: https://github.com/apache/spark/pull/53939

   ### What changes were proposed in this pull request?
   
   Add `PyArrowNestedTypeCastTests` to test `pa.Array.cast()` for container types (`list`, `large_list`, `fixed_size_list`, `map`, `struct`) and their nested variants.
   
   - 11 test methods, 123 test cases total
   - Covers successful casts (e.g., list↔large_list, map→list<struct>)
   - Covers expected failures (e.g., list→map, container→scalar)
   
   ### Why are the changes needed?
   
   Part of [SPARK-54936](https://issues.apache.org/jira/browse/SPARK-54936) to monitor upstream PyArrow behavior changes. Detects breaking changes when upgrading PyArrow versions.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   `pytest python/pyspark/tests/upstream/pyarrow/test_pyarrow_array_cast.py::PyArrowNestedTypeCastTests -v`
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Yes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-54942][PYTHON][TESTS][FOLLOWUP] Add tests for pa.Array.cast of nested/container types [spark]

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #53939:
URL: https://github.com/apache/spark/pull/53939#issuecomment-3793014896

   merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-54942][PYTHON][TESTS][FOLLOWUP] Add tests for pa.Array.cast of nested/container types [spark]

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #53939: [SPARK-54942][PYTHON][TESTS][FOLLOWUP] Add tests for pa.Array.cast of nested/container types
URL: https://github.com/apache/spark/pull/53939


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-54942][PYTHON][TESTS][FOLLOWUP] Add tests for pa.Array.cast of nested/container types [spark]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #53939:
URL: https://github.com/apache/spark/pull/53939#issuecomment-3792316910

   ## JIRA Issue Information
   
   === Sub-task SPARK-54942 ===
   Summary: Add tests for pa.Array.cast with default arguments
   Assignee: Yicong Huang
   Status: Resolved
   Affected: ["4.2.0"]
   
   ---
   *This comment was automatically generated by GitHub Actions*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org