[GitHub] [incubator-brpc] gydong commented on a diff in pull request #2057: Optimize parallel channel request map method

[GitBox <gi...@apache.org>]

gydong commented on code in PR #2057:
URL: https://github.com/apache/incubator-brpc/pull/2057#discussion_r1058086480


##########
src/brpc/parallel_channel.h:
##########
@@ -94,10 +94,20 @@ struct SubCall {
 class CallMapper : public SharedObject {
 public:
     virtual SubCall Map(int channel_index/*starting from 0*/,
+		        int channel_count,
                         const google::protobuf::MethodDescriptor* method,
                         const google::protobuf::Message* request,
-                        google::protobuf::Message* response) = 0;
+                        google::protobuf::Message* response) {
+        return Map(channel_index, method, request, response);    
+    }
+
 protected:
+    // TODO: Remove this backward compatibility method.
+    virtual SubCall Map(int channel_index/*starting from 0*/,
+                        const google::protobuf::MethodDescriptor* method,
+                        const google::protobuf::Message* request,
+                        google::protobuf::Message* response) = 0;

Review Comment:
   这个弃用版本还是纯虚函数的话，会不会不利于实现侧向新接口函数迁移？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org