You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2015/06/16 09:45:20 UTC
Review Request 35494: Added format for template declaration in the
styleguide.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35494/
-----------------------------------------------------------
Review request for mesos, Bernd Mathiske and Joerg Schad.
Bugs: MESOS-2705
https://issues.apache.org/jira/browse/MESOS-2705
Repository: mesos
Description
-------
The general rule to format templates is to declare them as:
```c++
template <typename T> // notice the space between template and <
class Foo {
…
};
```
However, the style is not documented anywhere nor it is inherited from the Google style guide.
Diffs
-----
docs/mesos-c++-style-guide.md 94107ed21c6f09349ce691f9f4d36b43bbbe809e
Diff: https://reviews.apache.org/r/35494/diff/
Testing
-------
Thanks,
Alexander Rojas
Re: Review Request 35494: Added format for template declaration in the
styleguide.
Posted by Michael Park <mc...@gmail.com>.
> On June 16, 2015, 11:21 a.m., Michael Park wrote:
> > docs/mesos-c++-style-guide.md, line 64
> > <https://reviews.apache.org/r/35494/diff/2/?file=985605#file985605line64>
> >
> > (1) `s/template/`template`/`
> > (2) `s/template <Args>/template <typename T>`
> > (3) `s/template<Args>/template<typename T>`
Yikes, the formatting didn't work there at all.
(1) Let's wrap 'template' in '`'.
(2) `s/template <Args>/template <typename T>/`
(3) `s/template<Args>/template<typename T>/`
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35494/#review88054
-----------------------------------------------------------
On June 16, 2015, 8:17 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35494/
> -----------------------------------------------------------
>
> (Updated June 16, 2015, 8:17 a.m.)
>
>
> Review request for mesos, Bernd Mathiske and Joerg Schad.
>
>
> Bugs: MESOS-2705
> https://issues.apache.org/jira/browse/MESOS-2705
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The general rule to format templates is to declare them as:
>
> ```c++
> template <typename T> // notice the space between template and <
> class Foo {
> …
> };
> ```
>
> However, the style is not documented anywhere nor it is inherited from the Google style guide.
>
>
> Diffs
> -----
>
> docs/mesos-c++-style-guide.md 94107ed21c6f09349ce691f9f4d36b43bbbe809e
>
> Diff: https://reviews.apache.org/r/35494/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 35494: Added format for template declaration in the
styleguide.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35494/#review88054
-----------------------------------------------------------
Ship it!
docs/mesos-c++-style-guide.md (line 64)
<https://reviews.apache.org/r/35494/#comment140453>
(1) `s/template/`template`/`
(2) `s/template <Args>/template <typename T>`
(3) `s/template<Args>/template<typename T>`
- Michael Park
On June 16, 2015, 8:17 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35494/
> -----------------------------------------------------------
>
> (Updated June 16, 2015, 8:17 a.m.)
>
>
> Review request for mesos, Bernd Mathiske and Joerg Schad.
>
>
> Bugs: MESOS-2705
> https://issues.apache.org/jira/browse/MESOS-2705
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The general rule to format templates is to declare them as:
>
> ```c++
> template <typename T> // notice the space between template and <
> class Foo {
> …
> };
> ```
>
> However, the style is not documented anywhere nor it is inherited from the Google style guide.
>
>
> Diffs
> -----
>
> docs/mesos-c++-style-guide.md 94107ed21c6f09349ce691f9f4d36b43bbbe809e
>
> Diff: https://reviews.apache.org/r/35494/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 35494: Added format for template declaration in the
styleguide.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35494/#review88181
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35494]
All tests passed.
- Mesos ReviewBot
On June 16, 2015, 11:27 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35494/
> -----------------------------------------------------------
>
> (Updated June 16, 2015, 11:27 a.m.)
>
>
> Review request for mesos, Bernd Mathiske and Joerg Schad.
>
>
> Bugs: MESOS-2705
> https://issues.apache.org/jira/browse/MESOS-2705
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The general rule to format templates is to declare them as:
>
> ```c++
> template <typename T> // notice the space between template and <
> class Foo {
> …
> };
> ```
>
> However, the style is not documented anywhere nor it is inherited from the Google style guide.
>
>
> Diffs
> -----
>
> docs/mesos-c++-style-guide.md 94107ed21c6f09349ce691f9f4d36b43bbbe809e
>
> Diff: https://reviews.apache.org/r/35494/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 35494: Added format for template declaration in the
styleguide.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35494/
-----------------------------------------------------------
(Updated June 16, 2015, 1:27 p.m.)
Review request for mesos, Bernd Mathiske and Joerg Schad.
Changes
-------
mpark's comments
Bugs: MESOS-2705
https://issues.apache.org/jira/browse/MESOS-2705
Repository: mesos
Description
-------
The general rule to format templates is to declare them as:
```c++
template <typename T> // notice the space between template and <
class Foo {
…
};
```
However, the style is not documented anywhere nor it is inherited from the Google style guide.
Diffs (updated)
-----
docs/mesos-c++-style-guide.md 94107ed21c6f09349ce691f9f4d36b43bbbe809e
Diff: https://reviews.apache.org/r/35494/diff/
Testing
-------
Thanks,
Alexander Rojas
Re: Review Request 35494: Added format for template declaration in the
styleguide.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35494/
-----------------------------------------------------------
(Updated June 16, 2015, 10:17 a.m.)
Review request for mesos, Bernd Mathiske and Joerg Schad.
Changes
-------
joerg's comments.
Bugs: MESOS-2705
https://issues.apache.org/jira/browse/MESOS-2705
Repository: mesos
Description
-------
The general rule to format templates is to declare them as:
```c++
template <typename T> // notice the space between template and <
class Foo {
…
};
```
However, the style is not documented anywhere nor it is inherited from the Google style guide.
Diffs (updated)
-----
docs/mesos-c++-style-guide.md 94107ed21c6f09349ce691f9f4d36b43bbbe809e
Diff: https://reviews.apache.org/r/35494/diff/
Testing
-------
Thanks,
Alexander Rojas
Re: Review Request 35494: Added format for template declaration in the
styleguide.
Posted by Till Toenshoff <to...@me.com>.
> On June 16, 2015, 8:13 a.m., Joerg Schad wrote:
> > Actually I would really like to understand why we do it this way. Most other code I know omits the space. Still, as this seems to be common practice...
That question should get raised on the JIRA to make things transparent.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35494/#review88039
-----------------------------------------------------------
On June 16, 2015, 8:17 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35494/
> -----------------------------------------------------------
>
> (Updated June 16, 2015, 8:17 a.m.)
>
>
> Review request for mesos, Bernd Mathiske and Joerg Schad.
>
>
> Bugs: MESOS-2705
> https://issues.apache.org/jira/browse/MESOS-2705
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The general rule to format templates is to declare them as:
>
> ```c++
> template <typename T> // notice the space between template and <
> class Foo {
> …
> };
> ```
>
> However, the style is not documented anywhere nor it is inherited from the Google style guide.
>
>
> Diffs
> -----
>
> docs/mesos-c++-style-guide.md 94107ed21c6f09349ce691f9f4d36b43bbbe809e
>
> Diff: https://reviews.apache.org/r/35494/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 35494: Added format for template declaration in the
styleguide.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35494/#review88039
-----------------------------------------------------------
Ship it!
Actually I would really like to understand why we do it this way. Most other code I know omits the space. Still, as this seems to be common practice...
docs/mesos-c++-style-guide.md (line 62)
<https://reviews.apache.org/r/35494/#comment140439>
Why is this under Class Format? Can't we have:
### Template
* Leave
- Joerg Schad
On June 16, 2015, 7:45 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35494/
> -----------------------------------------------------------
>
> (Updated June 16, 2015, 7:45 a.m.)
>
>
> Review request for mesos, Bernd Mathiske and Joerg Schad.
>
>
> Bugs: MESOS-2705
> https://issues.apache.org/jira/browse/MESOS-2705
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The general rule to format templates is to declare them as:
>
> ```c++
> template <typename T> // notice the space between template and <
> class Foo {
> …
> };
> ```
>
> However, the style is not documented anywhere nor it is inherited from the Google style guide.
>
>
> Diffs
> -----
>
> docs/mesos-c++-style-guide.md 94107ed21c6f09349ce691f9f4d36b43bbbe809e
>
> Diff: https://reviews.apache.org/r/35494/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Rojas
>
>