You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Christian Schulte (JIRA)" <ji...@codehaus.org> on 2006/11/01 17:54:51 UTC
[jira] Created: (MNG-2646) [PATCH]
MavenProjectBuilder.buildFromRepository(...) does not support profiles
[PATCH] MavenProjectBuilder.buildFromRepository(...) does not support profiles
------------------------------------------------------------------------------
Key: MNG-2646
URL: http://jira.codehaus.org/browse/MNG-2646
Project: Maven 2
Issue Type: Bug
Components: Profiles
Affects Versions: 2.0.4
Reporter: Christian Schulte
Attachments: profile.patch
Currently profiles are not injected into models retrieved from a repository. The attached patch was written against /tags/maven-2.0.4 and should apply cleanly. It adds a ProfileManager parameter to the corresponding MavenProjectBuilder.buildFromRepository(...) methods so that profiles are also injected into models build from a repository.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2646) [PATCH]
MavenProjectBuilder.buildFromRepository(...) does not support profiles
Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2646?page=all ]
Jason van Zyl updated MNG-2646:
-------------------------------
Fix Version/s: (was: 2.0.5)
2.1
Too much surgery required to do this cleanly in 2.0.x.
> [PATCH] MavenProjectBuilder.buildFromRepository(...) does not support profiles
> ------------------------------------------------------------------------------
>
> Key: MNG-2646
> URL: http://jira.codehaus.org/browse/MNG-2646
> Project: Maven 2
> Issue Type: Bug
> Components: Profiles
> Affects Versions: 2.0.4
> Reporter: Christian Schulte
> Fix For: 2.1
>
> Attachments: profile.patch
>
>
> Currently profiles are not injected into models retrieved from a repository. The attached patch was written against /tags/maven-2.0.4 and should apply cleanly. It adds a ProfileManager parameter to the corresponding MavenProjectBuilder.buildFromRepository(...) methods so that profiles are also injected into models build from a repository.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MNG-2646) [PATCH]
MavenProjectBuilder.buildFromRepository(...) does not support profiles
Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason van Zyl closed MNG-2646.
------------------------------
Resolution: Won't Fix
Upon looking at this it's not something we want to do. Profiles affect your builds and change the behavior of what you are building. Influencing dependent POMs as they are being read with your profiles makes the outcome fairly random.
> [PATCH] MavenProjectBuilder.buildFromRepository(...) does not support profiles
> ------------------------------------------------------------------------------
>
> Key: MNG-2646
> URL: http://jira.codehaus.org/browse/MNG-2646
> Project: Maven 2
> Issue Type: Bug
> Components: Profiles
> Affects Versions: 2.0.4
> Reporter: Christian Schulte
> Fix For: 2.1.x
>
> Attachments: profile.patch
>
>
> Currently profiles are not injected into models retrieved from a repository. The attached patch was written against /tags/maven-2.0.4 and should apply cleanly. It adds a ProfileManager parameter to the corresponding MavenProjectBuilder.buildFromRepository(...) methods so that profiles are also injected into models build from a repository.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2646) [PATCH]
MavenProjectBuilder.buildFromRepository(...) does not support profiles
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter updated MNG-2646:
------------------------------
Fix Version/s: (was: 2.1)
> [PATCH] MavenProjectBuilder.buildFromRepository(...) does not support profiles
> ------------------------------------------------------------------------------
>
> Key: MNG-2646
> URL: http://jira.codehaus.org/browse/MNG-2646
> Project: Maven 2
> Issue Type: Bug
> Components: Profiles
> Affects Versions: 2.0.4
> Reporter: Christian Schulte
> Attachments: profile.patch
>
>
> Currently profiles are not injected into models retrieved from a repository. The attached patch was written against /tags/maven-2.0.4 and should apply cleanly. It adds a ProfileManager parameter to the corresponding MavenProjectBuilder.buildFromRepository(...) methods so that profiles are also injected into models build from a repository.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2646) [PATCH]
MavenProjectBuilder.buildFromRepository(...) does not support profiles
Posted by "Kenney Westerhof (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2646?page=all ]
Kenney Westerhof updated MNG-2646:
----------------------------------
Fix Version/s: 2.0.5
> [PATCH] MavenProjectBuilder.buildFromRepository(...) does not support profiles
> ------------------------------------------------------------------------------
>
> Key: MNG-2646
> URL: http://jira.codehaus.org/browse/MNG-2646
> Project: Maven 2
> Issue Type: Bug
> Components: Profiles
> Affects Versions: 2.0.4
> Reporter: Christian Schulte
> Fix For: 2.0.5
>
> Attachments: profile.patch
>
>
> Currently profiles are not injected into models retrieved from a repository. The attached patch was written against /tags/maven-2.0.4 and should apply cleanly. It adds a ProfileManager parameter to the corresponding MavenProjectBuilder.buildFromRepository(...) methods so that profiles are also injected into models build from a repository.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2646) [PATCH]
MavenProjectBuilder.buildFromRepository(...) does not support profiles
Posted by "Christian Schulte (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_98201 ]
Christian Schulte commented on MNG-2646:
----------------------------------------
Can you please provide an example for having profiles supported for dependent POMs makes problems. Using profiles currently is the only option to influence POMs and that is exactly what I was trying to do (introduce some simple if-then logic to a POM also when used pre-built from a repository). I understand that influencing dependent POMs is not desired at all but don't get the exact reason why. Also I would need to know if I am using profiles in a way they are not meant to be used.
> [PATCH] MavenProjectBuilder.buildFromRepository(...) does not support profiles
> ------------------------------------------------------------------------------
>
> Key: MNG-2646
> URL: http://jira.codehaus.org/browse/MNG-2646
> Project: Maven 2
> Issue Type: Bug
> Components: Profiles
> Affects Versions: 2.0.4
> Reporter: Christian Schulte
> Fix For: 2.1.x
>
> Attachments: profile.patch
>
>
> Currently profiles are not injected into models retrieved from a repository. The attached patch was written against /tags/maven-2.0.4 and should apply cleanly. It adds a ProfileManager parameter to the corresponding MavenProjectBuilder.buildFromRepository(...) methods so that profiles are also injected into models build from a repository.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2646) [PATCH]
MavenProjectBuilder.buildFromRepository(...) does not support profiles
Posted by "Carlos Sanchez (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2646?page=comments#action_81737 ]
Carlos Sanchez commented on MNG-2646:
-------------------------------------
Comment about the patch, you're changing signature of public methods which is not acceptable, we have to maintain backwards compatibility. Deprecate and add new methods.
> [PATCH] MavenProjectBuilder.buildFromRepository(...) does not support profiles
> ------------------------------------------------------------------------------
>
> Key: MNG-2646
> URL: http://jira.codehaus.org/browse/MNG-2646
> Project: Maven 2
> Issue Type: Bug
> Components: Profiles
> Affects Versions: 2.0.4
> Reporter: Christian Schulte
> Fix For: 2.0.5
>
> Attachments: profile.patch
>
>
> Currently profiles are not injected into models retrieved from a repository. The attached patch was written against /tags/maven-2.0.4 and should apply cleanly. It adds a ProfileManager parameter to the corresponding MavenProjectBuilder.buildFromRepository(...) methods so that profiles are also injected into models build from a repository.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira