You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Austin Nobis (Code Review)" <ge...@cloudera.org> on 2019/05/03 20:00:06 UTC

[Impala-ASF-CR] IMPALA-8488: Hardcoded path in Ranger E2E test breaks for S3 

Austin Nobis has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13234


Change subject: IMPALA-8488: Hardcoded path in Ranger E2E test breaks for S3
......................................................................

IMPALA-8488: Hardcoded path in Ranger E2E test breaks for S3

A hardcoded path in test_ranger.py for URI testing was updated to
support S3, local, and HDFS as opposed to just HDFS.

Testing:
- Ran authorization E2E tests
- Ran all FE tests
- Ran test_ranger.py with S3

Change-Id: Ie2c021ce212f483a644fdab4e77ab95031066b14
---
M tests/authorization/test_ranger.py
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/13234/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie2c021ce212f483a644fdab4e77ab95031066b14
Gerrit-Change-Number: 13234
Gerrit-PatchSet: 1
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>

[Impala-ASF-CR] IMPALA-8488: Fix hardcoded path in Ranger E2E test on S3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13234 )

Change subject: IMPALA-8488: Fix hardcoded path in Ranger E2E test on S3
......................................................................

IMPALA-8488: Fix hardcoded path in Ranger E2E test on S3

A hardcoded path in test_ranger.py for URI testing was updated to
support S3, local, and HDFS as opposed to just HDFS.

Testing:
- Ran authorization E2E tests
- Ran all FE tests
- Ran test_ranger.py with S3

Change-Id: Ie2c021ce212f483a644fdab4e77ab95031066b14
Reviewed-on: http://gerrit.cloudera.org:8080/13234
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/authorization/test_ranger.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2c021ce212f483a644fdab4e77ab95031066b14
Gerrit-Change-Number: 13234
Gerrit-PatchSet: 4
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>

[Impala-ASF-CR] IMPALA-8488: Hardcoded path in Ranger E2E test breaks for S3

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13234 )

Change subject: IMPALA-8488: Hardcoded path in Ranger E2E test breaks for S3
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13234/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13234/1//COMMIT_MSG@7
PS1, Line 7: Hardcoded path in Ranger E2E test breaks for S3
nit: usually we try to say something like "Fix hardcoded path in Ranger E2E test on S3" instead of mentioning the issue


http://gerrit.cloudera.org:8080/#/c/13234/1/tests/authorization/test_ranger.py
File tests/authorization/test_ranger.py:

http://gerrit.cloudera.org:8080/#/c/13234/1/tests/authorization/test_ranger.py@262
PS1, Line 262: NAMENODE + uri
nit: "{0}{1}".format(NAMENODE, uri)



-- 
To view, visit http://gerrit.cloudera.org:8080/13234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c021ce212f483a644fdab4e77ab95031066b14
Gerrit-Change-Number: 13234
Gerrit-PatchSet: 1
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 May 2019 20:03:57 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8488: Fix hardcoded path in Ranger E2E test on S3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13234 )

Change subject: IMPALA-8488: Fix hardcoded path in Ranger E2E test on S3
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4159/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/13234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c021ce212f483a644fdab4e77ab95031066b14
Gerrit-Change-Number: 13234
Gerrit-PatchSet: 3
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 May 2019 16:56:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8488: Fix hardcoded path in Ranger E2E test on S3

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13234 )

Change subject: IMPALA-8488: Fix hardcoded path in Ranger E2E test on S3
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c021ce212f483a644fdab4e77ab95031066b14
Gerrit-Change-Number: 13234
Gerrit-PatchSet: 2
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 May 2019 16:56:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8488: Fix hardcoded path in Ranger E2E test on S3

Posted by "Austin Nobis (Code Review)" <ge...@cloudera.org>.
Austin Nobis has posted comments on this change. ( http://gerrit.cloudera.org:8080/13234 )

Change subject: IMPALA-8488: Fix hardcoded path in Ranger E2E test on S3
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13234/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13234/1//COMMIT_MSG@7
PS1, Line 7: Fix hardcoded path in Ranger E2E test on S3
> nit: usually we try to say something like "Fix hardcoded path in Ranger E2E
Done


http://gerrit.cloudera.org:8080/#/c/13234/1/tests/authorization/test_ranger.py
File tests/authorization/test_ranger.py:

http://gerrit.cloudera.org:8080/#/c/13234/1/tests/authorization/test_ranger.py@262
PS1, Line 262: "{0}{1}".forma
> nit: "{0}{1}".format(NAMENODE, uri)
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/13234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c021ce212f483a644fdab4e77ab95031066b14
Gerrit-Change-Number: 13234
Gerrit-PatchSet: 2
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 May 2019 16:33:45 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8488: Fix hardcoded path in Ranger E2E test on S3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13234 )

Change subject: IMPALA-8488: Fix hardcoded path in Ranger E2E test on S3
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c021ce212f483a644fdab4e77ab95031066b14
Gerrit-Change-Number: 13234
Gerrit-PatchSet: 3
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 May 2019 16:56:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8488: Fix hardcoded path in Ranger E2E test on S3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13234 )

Change subject: IMPALA-8488: Fix hardcoded path in Ranger E2E test on S3
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/3085/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c021ce212f483a644fdab4e77ab95031066b14
Gerrit-Change-Number: 13234
Gerrit-PatchSet: 2
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 May 2019 17:32:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8488: Hardcoded path in Ranger E2E test breaks for S3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13234 )

Change subject: IMPALA-8488: Hardcoded path in Ranger E2E test breaks for S3
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/3065/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c021ce212f483a644fdab4e77ab95031066b14
Gerrit-Change-Number: 13234
Gerrit-PatchSet: 1
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 May 2019 20:26:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8488: Fix hardcoded path in Ranger E2E test on S3

Posted by "Austin Nobis (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal, Fredy Wijaya, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13234

to look at the new patch set (#2).

Change subject: IMPALA-8488: Fix hardcoded path in Ranger E2E test on S3
......................................................................

IMPALA-8488: Fix hardcoded path in Ranger E2E test on S3

A hardcoded path in test_ranger.py for URI testing was updated to
support S3, local, and HDFS as opposed to just HDFS.

Testing:
- Ran authorization E2E tests
- Ran all FE tests
- Ran test_ranger.py with S3

Change-Id: Ie2c021ce212f483a644fdab4e77ab95031066b14
---
M tests/authorization/test_ranger.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/13234/2
-- 
To view, visit http://gerrit.cloudera.org:8080/13234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie2c021ce212f483a644fdab4e77ab95031066b14
Gerrit-Change-Number: 13234
Gerrit-PatchSet: 2
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>

[Impala-ASF-CR] IMPALA-8488: Fix hardcoded path in Ranger E2E test on S3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13234 )

Change subject: IMPALA-8488: Fix hardcoded path in Ranger E2E test on S3
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c021ce212f483a644fdab4e77ab95031066b14
Gerrit-Change-Number: 13234
Gerrit-PatchSet: 3
Gerrit-Owner: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 May 2019 22:03:38 +0000
Gerrit-HasComments: No