You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/12/13 21:05:30 UTC
[GitHub] [hbase] joshelser opened a new pull request #3941: HBASE-26557 Correct export to set log4j2.formatMsgNoLookups in HBASE_…
joshelser opened a new pull request #3941:
URL: https://github.com/apache/hbase/pull/3941
…OPTS
Tagging folks who reviewed the first time. The original change is ineffective and does not result in adding the property to the HBASE_OPTS environment variable
```
$ ./bin/start-hbase.sh
/Users/jelser/hbase300alpha2rc0/hbase300/hbase-3.0.0-alpha-2/bin/hbase-config.sh: line 167: export: `=': not a valid identifier
/Users/jelser/hbase300alpha2rc0/hbase300/hbase-3.0.0-alpha-2/bin/hbase-config.sh: line 167: export: ` -Dlog4j2.formatMsgNoLookups=true': not a valid identifier
/Users/jelser/hbase300alpha2rc0/hbase300/hbase-3.0.0-alpha-2/bin/hbase-config.sh: line 167: export: `=': not a valid identifier
/Users/jelser/hbase300alpha2rc0/hbase300/hbase-3.0.0-alpha-2/bin/hbase-config.sh: line 167: export: ` -Dlog4j2.formatMsgNoLookups=true': not a valid identifier
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #3941: HBASE-26557 Correct export to set log4j2.formatMsgNoLookups in HBASE_…
Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #3941:
URL: https://github.com/apache/hbase/pull/3941#issuecomment-993020482
Checked hbase-config.cmd, we do not have space for that file...
Thanks Josh for catching this.
Let me merge and generate a RC2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3941: HBASE-26557 Correct export to set log4j2.formatMsgNoLookups in HBASE_…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3941:
URL: https://github.com/apache/hbase/pull/3941#issuecomment-992916307
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 7m 3s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. |
| | | 8m 48s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3941/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3941 |
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux b6b31078a6e6 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 8bca21b47d |
| Max. process+thread count | 50 (vs. ulimit of 30000) |
| modules | C: . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3941/1/console |
| versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3941: HBASE-26557 Correct export to set log4j2.formatMsgNoLookups in HBASE_…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3941:
URL: https://github.com/apache/hbase/pull/3941#issuecomment-992981974
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 3s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
||| _ Other Tests _ |
| | | 2m 24s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3941/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3941 |
| Optional Tests | |
| uname | Linux 72ca31f8a774 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 8bca21b47d |
| Max. process+thread count | 41 (vs. ulimit of 30000) |
| modules | C: . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3941/2/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #3941: HBASE-26557 Correct export to set log4j2.formatMsgNoLookups in HBASE_…
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on pull request #3941:
URL: https://github.com/apache/hbase/pull/3941#issuecomment-992980646
Building again with debug enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3941: HBASE-26557 Correct export to set log4j2.formatMsgNoLookups in HBASE_…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3941:
URL: https://github.com/apache/hbase/pull/3941#issuecomment-992981834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] joshelser edited a comment on pull request #3941: HBASE-26557 Correct export to set log4j2.formatMsgNoLookups in HBASE_…
Posted by GitBox <gi...@apache.org>.
joshelser edited a comment on pull request #3941:
URL: https://github.com/apache/hbase/pull/3941#issuecomment-992940447
Great question. I just ran it through their online interpreter for shell check and it should have generated an error.
The nightly build doesn't seem to complain
```
23:25:33 ============================================================================
23:25:33 ============================================================================
23:25:33 shellcheck plugin: full
23:25:33 ============================================================================
23:25:33 ============================================================================
23:25:33
23:25:33
23:25:33 Running shellcheck against all suspected shell scripts
23:25:33 /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/output-general/precommit/test-patch.d/shellcheck.sh: line 118: warning: command substitution: ignored null byte in input
23:25:33 /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/output-general/precommit/test-patch.d/shellcheck.sh: line 118: warning: command substitution: ignored null byte in input
23:25:33 /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/output-general/precommit/test-patch.d/shellcheck.sh: line 118: warning: command substitution: ignored null byte in input
```
The nightly doesn't seem to think anything is wrong with it. The shellcheck specific output doesn't even mention hbase-config.sh.
https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/465/artifact/output-general/ meant to add this the first time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 merged pull request #3941: HBASE-26557 Correct export to set log4j2.formatMsgNoLookups in HBASE_…
Posted by GitBox <gi...@apache.org>.
Apache9 merged pull request #3941:
URL: https://github.com/apache/hbase/pull/3941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #3941: HBASE-26557 Correct export to set log4j2.formatMsgNoLookups in HBASE_…
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on pull request #3941:
URL: https://github.com/apache/hbase/pull/3941#issuecomment-992970238
> lgtm. why didn't shellcheck catch this on the original?
I came around to ask the exact same question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3941: HBASE-26557 Correct export to set log4j2.formatMsgNoLookups in HBASE_…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3941:
URL: https://github.com/apache/hbase/pull/3941#issuecomment-992911056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] joshelser commented on pull request #3941: HBASE-26557 Correct export to set log4j2.formatMsgNoLookups in HBASE_…
Posted by GitBox <gi...@apache.org>.
joshelser commented on pull request #3941:
URL: https://github.com/apache/hbase/pull/3941#issuecomment-992940447
Great question. I just ran it through their online interpreter for shell check and it should have generated an error.
The nightly build doesn't seem to complain
```
23:25:33 ============================================================================
23:25:33 ============================================================================
23:25:33 shellcheck plugin: full
23:25:33 ============================================================================
23:25:33 ============================================================================
23:25:33
23:25:33
23:25:33 Running shellcheck against all suspected shell scripts
23:25:33 /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/output-general/precommit/test-patch.d/shellcheck.sh: line 118: warning: command substitution: ignored null byte in input
23:25:33 /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/output-general/precommit/test-patch.d/shellcheck.sh: line 118: warning: command substitution: ignored null byte in input
23:25:33 /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/output-general/precommit/test-patch.d/shellcheck.sh: line 118: warning: command substitution: ignored null byte in input
```
The nightly doesn't seem to think anything is wrong with it. The shellcheck specific output doesn't even mention hbase-config.sh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #3941: HBASE-26557 Correct export to set log4j2.formatMsgNoLookups in HBASE_…
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on pull request #3941:
URL: https://github.com/apache/hbase/pull/3941#issuecomment-992993238
```
...
[2021-12-13T22:47:22.954Z] [Mon Dec 13 22:47:23 UTC 2021 DEBUG]: Importing /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3941/yetus-general-check/output/precommit/test-patch.d/shellcheck.sh
[2021-12-13T22:47:22.954Z] [Mon Dec 13 22:47:23 UTC 2021 DEBUG]: Testing if shellcheck has been enabled by user
[2021-12-13T22:47:22.954Z] [Mon Dec 13 22:47:23 UTC 2021 DEBUG]: Post-parsing: shellcheck enabled
[2021-12-13T22:47:22.954Z] [Mon Dec 13 22:47:23 UTC 2021 DEBUG]: TESTTYPES accepted shellcheck
...
[2021-12-13T22:47:26.615Z] ============================================================================
[2021-12-13T22:47:26.615Z] ============================================================================
[2021-12-13T22:47:26.615Z] Determining needed tests
[2021-12-13T22:47:26.615Z] ============================================================================
[2021-12-13T22:47:26.615Z] ============================================================================
...
[2021-12-13T22:47:26.615Z] [Mon Dec 13 22:47:27 UTC 2021 DEBUG]: Testing if shellcheck has been enabled by user
[2021-12-13T22:47:26.615Z] [Mon Dec 13 22:47:27 UTC 2021 DEBUG]: Post-parsing: shellcheck enabled
[2021-12-13T22:47:26.615Z] [Mon Dec 13 22:47:27 UTC 2021 DEBUG]: NEEDED_TESTS accepted shellcheck
[2021-12-13T22:47:26.615Z] [Mon Dec 13 22:47:27 UTC 2021 DEBUG]: SHELLCHECK_FILTERFILES accepted bin/hbase-config.sh
```
Yet in the build artifacts, all of the shellcheck output files are empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org