[GitHub] [doris] zhannngchen commented on a diff in pull request #14722: [fix](vec) VMergeIterator add key same label for agg table

[GitBox <gi...@apache.org>]

zhannngchen commented on code in PR #14722:
URL: https://github.com/apache/doris/pull/14722#discussion_r1049269315


##########
be/src/vec/core/block.h:
##########
@@ -63,6 +63,7 @@ class Block {
 
     Container data;
     IndexByName index_by_name;
+    std::vector<uint64_t> row_same_bit;

Review Comment:
   Using a vector of uint64_t is kind of waste of space, can we use a roaringbitmap instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org