You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/02/17 07:25:19 UTC
[GitHub] [camel-kafka-connector] tadayosi opened a new pull request #1019: Add tests to camel-kafka-connector-generator-maven-plugin
tadayosi opened a new pull request #1019:
URL: https://github.com/apache/camel-kafka-connector/pull/1019
Fix #166
Initial attempt at introducing maven it to ckc maven plugin. Running the tests is time consuming, so it's intentionally not integrated with the `integration-test` build cycle by default. You can run them by:
```
mvn clean verify -Pmaven-it
```
at this moment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd commented on pull request #1019: Add tests to camel-kafka-connector-generator-maven-plugin
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #1019:
URL: https://github.com/apache/camel-kafka-connector/pull/1019#issuecomment-780371659
I believe you should add an exclusion at maven checkstyle plugin configuration level
Here:
```
<executions>
<execution>
<id>default-cli</id>
<phase>validate</phase>
<configuration>
<includeResources>false</includeResources>
<configLocation>camel-checkstyle.xml</configLocation>
<consoleOutput>true</consoleOutput>
<failsOnError>${checkstyle.failOnViolation}</failsOnError>
<linkXRef>false</linkXRef>
<suppressionsLocation>camel-checkstyle-suppressions.xml</suppressionsLocation>
<encoding>UTF-8</encoding>
<sourceDirectories>
<sourceDirectory>${basedir}/src</sourceDirectory>
</sourceDirectories>
<headerLocation>header-java.txt</headerLocation>
<includes>**/*.java,**/*.groovy,**/*.scala,**/*.xml,**/*.xsd</includes>
**<excludes>
**/archetype-resources/**/*.java,**/archetype-resources/**/*.groovy,**/archetype-resources/**/*.scala,**/archetype-resources/**/*.xml,**/org/json/simple/**/*.java,**/camel-checkstyle.xml
</excludes>**
</configuration>
<goals>
<goal>checkstyle</goal>
</goals>
</execution>
</executions>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] tadayosi commented on pull request #1019: Add tests to camel-kafka-connector-generator-maven-plugin
Posted by GitBox <gi...@apache.org>.
tadayosi commented on pull request #1019:
URL: https://github.com/apache/camel-kafka-connector/pull/1019#issuecomment-780369603
@oscerd And great idea for creating a gh action to run the tests nightly. I'll follow up with it after the pull req.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd commented on pull request #1019: Add tests to camel-kafka-connector-generator-maven-plugin
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #1019:
URL: https://github.com/apache/camel-kafka-connector/pull/1019#issuecomment-780432740
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] tadayosi commented on pull request #1019: Add tests to camel-kafka-connector-generator-maven-plugin
Posted by GitBox <gi...@apache.org>.
tadayosi commented on pull request #1019:
URL: https://github.com/apache/camel-kafka-connector/pull/1019#issuecomment-780395723
Thanks. Style issues fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd merged pull request #1019: Add tests to camel-kafka-connector-generator-maven-plugin
Posted by GitBox <gi...@apache.org>.
oscerd merged pull request #1019:
URL: https://github.com/apache/camel-kafka-connector/pull/1019
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd commented on pull request #1019: Add tests to camel-kafka-connector-generator-maven-plugin
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #1019:
URL: https://github.com/apache/camel-kafka-connector/pull/1019#issuecomment-780365332
Can you please fix this? Error: /home/runner/work/camel-kafka-connector/camel-kafka-connector/tooling/camel-kafka-connector-generator-maven-plugin/src/test/resources-its/org/apache/camel/kafkaconnector/maven/GenerateCamelKafkaConnectorsMojoIT/test_generate/pom.xml:1: Line does not match expected header line of '^<\?xml.*>'. [RegexpHeader]
Error: /home/runner/work/camel-kafka-connector/camel-kafka-connector/tooling/camel-kafka-connector-generator-maven-plugin/src/test/resources/template-connector-package.xml:1: Line does not match expected header line of '^<\?xml.*>'. [RegexpHeader]
Error: /home/runner/work/camel-kafka-connector/camel-kafka-connector/tooling/camel-kafka-connector-generator-maven-plugin/src/test/java/org/apache/camel/kafkaconnector/maven/GenerateCamelKafkaConnectorsMojoIT.java:45:17: Name 'test_generate' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd commented on pull request #1019: Add tests to camel-kafka-connector-generator-maven-plugin
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #1019:
URL: https://github.com/apache/camel-kafka-connector/pull/1019#issuecomment-780365525
I think we can also think about creating a gh action testing this stuff during the night or maybe more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] tadayosi commented on pull request #1019: Add tests to camel-kafka-connector-generator-maven-plugin
Posted by GitBox <gi...@apache.org>.
tadayosi commented on pull request #1019:
URL: https://github.com/apache/camel-kafka-connector/pull/1019#issuecomment-780368948
@oscerd Thanks for your catch-up. I can fix the pom.xml part, but for the method name `test_generate` it's the recommendation by the maven-it-extension plugin because it relies on convention over configuration for resolving the test resource folder `GenerateCamelKafkaConnectorsMojoIT/test_generate` from the class name & method name combo and tries to avoid problems with case-insensitive filesystems. Maybe should I just add some annotation to the method to explicitly ignore the stylecheck?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org