You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2014/04/22 15:23:52 UTC
Review Request 20554: Unit tests for number_utils, string_utils,
validator and misc files.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20554/
-----------------------------------------------------------
Review request for Ambari and Alexandr Antonenko.
Bugs: AMBARI-5524
https://issues.apache.org/jira/browse/AMBARI-5524
Repository: ambari
Description
-------
Create unit tests for following files:
utils/misc.js
utils/number_utils.js
utils/string_utils.js
utils/validator.js
Diffs
-----
ambari-web/app/controllers/wizard/step10_controller.js 2e6860e
ambari-web/app/messages.js cae4da6
ambari-web/app/utils/number_utils.js bc6e577
ambari-web/app/utils/validator.js 9978e77
ambari-web/test/utils/misc_test.js fd5696d
ambari-web/test/utils/number_utils_test.js 42fcb1f
ambari-web/test/utils/string_utils_test.js 9fb5095
ambari-web/test/utils/validator_test.js 1561dc3
Diff: https://reviews.apache.org/r/20554/diff/
Testing
-------
3679 tests complete (4 seconds)
Thanks,
Oleg Nechiporenko
Re: Review Request 20554: Unit tests for number_utils, string_utils,
validator and misc files.
Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20554/#review41010
-----------------------------------------------------------
Ship it!
Ship It!
- Alexandr Antonenko
On April 22, 2014, 1:23 p.m., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20554/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 1:23 p.m.)
>
>
> Review request for Ambari and Alexandr Antonenko.
>
>
> Bugs: AMBARI-5524
> https://issues.apache.org/jira/browse/AMBARI-5524
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create unit tests for following files:
> utils/misc.js
> utils/number_utils.js
> utils/string_utils.js
> utils/validator.js
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/wizard/step10_controller.js 2e6860e
> ambari-web/app/messages.js cae4da6
> ambari-web/app/utils/number_utils.js bc6e577
> ambari-web/app/utils/validator.js 9978e77
> ambari-web/test/utils/misc_test.js fd5696d
> ambari-web/test/utils/number_utils_test.js 42fcb1f
> ambari-web/test/utils/string_utils_test.js 9fb5095
> ambari-web/test/utils/validator_test.js 1561dc3
>
> Diff: https://reviews.apache.org/r/20554/diff/
>
>
> Testing
> -------
>
> 3679 tests complete (4 seconds)
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>