You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "yaooqinn (via GitHub)" <gi...@apache.org> on 2025/03/10 10:04:57 UTC
[PR] [SPARK-51452][UI] Improve Thread dump table search [spark]
yaooqinn opened a new pull request, #50225:
URL: https://github.com/apache/spark/pull/50225
### What changes were proposed in this pull request?
This PR improves thread dump search by:
- query with pattern `tr[id^="thread_"]` w/o further patten matching
- short-circuit the searching loop if found
-
### Why are the changes needed?
code refactoring for perf & cost
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51452][UI] Improve Thread dump table search [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #50225: [SPARK-51452][UI] Improve Thread dump table search
URL: https://github.com/apache/spark/pull/50225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51452][UI] Improve Thread dump table search [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #50225:
URL: https://github.com/apache/spark/pull/50225#issuecomment-2712330972
Thank you @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51452][UI] Improve Thread dump table search [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #50225:
URL: https://github.com/apache/spark/pull/50225#discussion_r1986979930
##########
core/src/main/resources/org/apache/spark/ui/static/table.js:
##########
@@ -82,31 +82,27 @@ function onMouseOverAndOut(threadId) {
}
function onSearchStringChange() {
- var searchString = $('#search').val().toLowerCase();
+ const searchString = $('#search').val().toLowerCase();
//remove the stacktrace
collapseAllThreadStackTrace(false);
- if (searchString.length == 0) {
- $('tr').each(function() {
+ $('tr[id^="thread_"]').each(function() {
+ if (searchString.length === 0) {
$(this).removeClass('d-none')
- })
- } else {
- $('tr').each(function(){
- if($(this).attr('id') && $(this).attr('id').match(/thread_[0-9]+_tr/) ) {
- var children = $(this).children();
- var found = false;
- for (var i = 0; i < children.length; i++) {
- if (children.eq(i).text().toLowerCase().indexOf(searchString) >= 0) {
- found = true;
- }
- }
- if (found) {
- $(this).removeClass('d-none')
+ } else {
+ let found = false;
+ const children = $(this).children();
+ let i = 0;
+ while(!found && i < children.length) {
+ if (children.eq(i).text().toLowerCase().indexOf(searchString) >= 0) {
+ console.log(children.eq(i).text());
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51452][UI] Improve Thread dump table search [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #50225:
URL: https://github.com/apache/spark/pull/50225#issuecomment-2711437716
I also built and verified manually this PR.
Merged to master for Apache Spark 4.1.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org