You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/03/01 01:08:03 UTC

[kudu-CR] server negotiation: improve error handling

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6154

to look at the new patch set (#3).

Change subject: server_negotiation: improve error handling
......................................................................

server_negotiation: improve error handling

Unlike in the client negotiator, the server negotiator should send an
error response back to the client on authentication failure.  We were
missing this in a few cases, notably around token and cert
authentication failures. This also adds a new token-specific rpc error
code which is used when the client should discard its token and request
a new one from the master.

Change-Id: I64f9c0f59aa608bf5078d65883a7d9a6fb186c04
---
M src/kudu/rpc/rpc_header.proto
M src/kudu/rpc/server_negotiation.cc
M src/kudu/security/token_verifier.cc
M src/kudu/security/token_verifier.h
4 files changed, 71 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/6154/3
-- 
To view, visit http://gerrit.cloudera.org:8080/6154
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I64f9c0f59aa608bf5078d65883a7d9a6fb186c04
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>