[GitHub] [arrow-rs] Cheappie commented on a diff in pull request #1634: expose row-group flush in public api

[GitBox <gi...@apache.org>]

Cheappie commented on code in PR #1634:
URL: https://github.com/apache/arrow-rs/pull/1634#discussion_r862818489


##########
parquet/src/arrow/arrow_writer.rs:
##########
@@ -113,22 +113,26 @@ impl<W: 'static + ParquetWriter> ArrowWriter<W> {
         }
 
         self.buffered_rows += batch.num_rows();
-
-        self.flush_completed()?;
+        self.flush_excess()?;
 
         Ok(())
     }
 
     /// Flushes buffered data until there are less than `max_row_group_size` rows buffered
-    fn flush_completed(&mut self) -> Result<()> {
+    fn flush_excess(&mut self) -> Result<()> {

Review Comment:
   sure thing



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org