You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/03/23 12:29:09 UTC

[GitHub] [orc] pgaref opened a new pull request #666: ORC-771: ORC timestamp consistency Test for sql.Timestamps close to epoch

pgaref opened a new pull request #666:
URL: https://github.com/apache/orc/pull/666


   ### What changes were proposed in this pull request?
   ORC-763 has a long discussion about the sql.Timestamp bug and how ORC goes around it.
   
   ### Why are the changes needed?
   This ticket introduces a Test to ensure consistency with the expected behaviour – as we have on C++ side of things.
   
   
   ### How was this patch tested?
   TestVectorOrcFile.testTimestampBug
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] dongjoon-hyun commented on pull request #666: ORC-771: ORC timestamp consistency Test for sql.Timestamps close to epoch

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #666:
URL: https://github.com/apache/orc/pull/666#issuecomment-804867329


   Thank you for working on this, @pgaref .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] pgaref commented on pull request #666: ORC-771: ORC timestamp consistency Test for sql.Timestamps close to epoch

Posted by GitBox <gi...@apache.org>.
pgaref commented on pull request #666:
URL: https://github.com/apache/orc/pull/666#issuecomment-805200113


   Thanks! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] dongjoon-hyun merged pull request #666: ORC-771: ORC timestamp consistency Test for sql.Timestamps close to epoch

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #666:
URL: https://github.com/apache/orc/pull/666


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] dongjoon-hyun commented on pull request #666: ORC-771: ORC timestamp consistency Test for sql.Timestamps close to epoch

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #666:
URL: https://github.com/apache/orc/pull/666#issuecomment-804888066


   cc @wgtmac 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] dongjoon-hyun commented on pull request #666: ORC-771: ORC timestamp consistency Test for sql.Timestamps close to epoch

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #666:
URL: https://github.com/apache/orc/pull/666#issuecomment-805191514


   Merged to master/1.6.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org