You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "mimihom (GitHub)" <gi...@apache.org> on 2019/01/21 11:53:37 UTC

[GitHub] [incubator-dubbo-website] mimihom opened pull request #256: fix wrong class name

## What is the purpose of the change

fix wrong class name

## Brief changelog

docs/en-us/dev/SPI.md
docs/zh-cn/dev/SPI.md

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo-website/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Test your code locally by running `docsite start`, and make sure it works as expected.
- [ ] Make sure no files under build directory is added.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/256 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-website] ralf0131 closed pull request #256: fix wrong class name

Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
[ pull request closed by ralf0131 ]

[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/256 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-website] lixiaojiee commented on pull request #256: fix wrong class name

Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.
> I also fixed some punctuation errors in this file.

well,I will have a look later

[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/256 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-website] lixiaojiee commented on pull request #256: fix wrong class name

Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.
```suggestion
when`ExtensionLoader` loads `CarMaker`'s  implementation `RaceCarMaker` ，the method `setWheelMaker` needs paramType `WheelMaker` which is also a SPI, It will be automatically loaded .
```

[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/256 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-website] mimihom commented on pull request #256: fix wrong class name

Posted by "mimihom (GitHub)" <gi...@apache.org>.
No need for `please`

[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/256 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-website] mimihom commented on pull request #256: fix wrong class name

Posted by "mimihom (GitHub)" <gi...@apache.org>.
The `Key` represent for `Key` in `Dubbo use URL (containing Key-Value) to pass the configuration.`, so it should be `Key`.

[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/256 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-website] lixiaojiee commented on pull request #256: fix wrong class name

Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.
```suggestion
With Wrapper class, you will be able to move same logics into Wrapper for all SPIs. Newly added Wrapper class add external logics for all SPIs, looks like AOP, Wrapper acts as a proxy for SPI.
```

[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/256 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-website] lixiaojiee commented on pull request #256: fix wrong class name

Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.
```suggestion
[^1]: Note: The config file here is in you own jar file, not in dubbo release jar file, Dubbo will scan all jar files with the same filename in classpath and then merge them together
```

[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/256 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-website] mimihom commented on pull request #256: fix wrong class name

Posted by "mimihom (GitHub)" <gi...@apache.org>.
I also fixed some punctuation errors in this file.

[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/256 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-website] lixiaojiee commented on pull request #256: fix wrong class name

Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.
> The `Key` represent for `Key` in `Dubbo use URL (containing Key-Value) to pass the configuration.`, so it should be `Key`.

I am very sorry I was careless, thank you for correcting

[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/256 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-website] lixiaojiee commented on pull request #256: fix wrong class name

Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.
```suggestion
* The standard JDK SPI will load and instantize all the implementations at once. It will be a waste of resources if one implementation is timecosted, but never be used.
```

[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/256 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-website] lixiaojiee commented on pull request #256: fix wrong class name

Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.
```suggestion
For the method `bind()`, Adaptive will firstly search `server` key, if no key was found, it will search `transport` key, to determine the implementation which proxy represent for.
```

[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/256 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-website] lixiaojiee commented on pull request #256: fix wrong class name

Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.
```suggestion
In this way depended SPI can get configuration from URL, after config all SPI key needed, configuration information will be passed from outer by URL. URL acts as a bus when passing the config information.
```

[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/256 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-website] lixiaojiee commented on pull request #256: fix wrong class name

Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.
```suggestion
* We can't accquire the SPI name, if loading the SPI implementation is failed.For example: standard JDK ScriptEngine, get script type by invoking method getName(). RubyScriptEngine class will load failed if the depenency jar jruby.jar is missing, and the real error info will be lost. When user executes ruby scripts, the program throws exception that doesn't support ruby, but it is not the real cause.
```

[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/256 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-website] lixiaojiee commented on pull request #256: fix wrong class name

Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.
```suggestion
The depency SPI that `ExtensionLoader` injects is an instance of `Adaptive`, the real spi implementation is known until the adaptive instance is executed.
```

[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/256 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-website] lixiaojiee commented on pull request #256: fix wrong class name

Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.
```suggestion
To extend Dubbo Protocol, please place a text file in the extension jar file: `META-INF/dubbo/org.apache.dubbo.rpc.Protocol`, content:
```

[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/256 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-website] lixiaojiee commented on pull request #256: fix wrong class name

Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.
> No need for `please`

ok

[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/256 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org