[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #23374: Fix NPM on Oracle 12.2 when load column metadata(#23013)

[GitBox <gi...@apache.org>]

strongduanmu commented on code in PR #23374:
URL: https://github.com/apache/shardingsphere/pull/23374#discussion_r1063342666


##########
infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/loader/dialect/OracleSchemaMetaDataLoader.java:
##########
@@ -121,7 +121,7 @@ private ColumnMetaData loadColumnMetaData(final Map<String, Integer> dataTypeMap
         boolean primaryKey = primaryKeys.contains(columnName);
         boolean generated = versionContainsIdentityColumn(databaseMetaData) && "YES".equals(resultSet.getString("IDENTITY_COLUMN"));
         // TODO need to support caseSensitive when version < 12.2.
-        boolean caseSensitive = versionContainsCollation(databaseMetaData) && resultSet.getString("COLLATION").endsWith("_CS");
+        boolean caseSensitive = versionContainsCollation(databaseMetaData) && resultSet.getString("COLLATION") != null && resultSet.getString("COLLATION").endsWith("_CS");

Review Comment:
   Please put the null value on the left condition.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org