You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/29 09:25:15 UTC
[GitHub] [incubator-seatunnel] Yves-yuan opened a new pull request #1187: [SeaTunnel#1186] [seatunnel-config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Yves-yuan opened a new pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[SeaTunnel #XXXX] [component] Title of the pull request", where *SeaTunnel #XXXX* should be replaced by the actual issue number.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
This pull request fix the #1186 bug.It add a seatunnel-config-shade module and rename package name of code in seatunnel-config to avoid code conflict when running SeatunnelFlink in Intellij Idea with local mode.
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in you PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Yves-yuan commented on pull request #1187: [SeaTunnel#1186] [seatunnel-config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
Yves-yuan commented on pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187#issuecomment-1024875908
@garyelephant Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1187: [Feature] [config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187#discussion_r802419090
##########
File path: LICENSE
##########
@@ -209,8 +209,8 @@ The text of each license is the standard Apache 2.0 license.
tools/dependencies/checkLicense.sh files from https://github.com/apache/skywalking
mvnw files from https://github.com/apache/maven-wrapper Apache 2.0
-seatunnel-config/src/main/java/com/typesafe/config/impl/ConfigNodePath.java from https://github.com/lightbend/config
-seatunnel-config/src/main/java/com/typesafe/config/impl/ConfigParser.java from https://github.com/lightbend/config
-seatunnel-config/src/main/java/com/typesafe/config/impl/Path.java from https://github.com/lightbend/config
-seatunnel-config/src/main/java/com/typesafe/config/impl/PathParser.java from https://github.com/lightbend/config
-seatunnel-config/src/main/java/com/typesafe/config/ConfigParseOptions.java from https://github.com/lightbend/config
\ No newline at end of file
+seatunnel-config/seatunnel-config-shade/src/main/java/com/typesafe/config/impl/ConfigNodePath.java from https://github.com/lightbend/config
+seatunnel-config/seatunnel-config-shade/src/main/java/com/typesafe/config/impl/ConfigParser.java from https://github.com/lightbend/config
+seatunnel-config/seatunnel-config-shade/src/main/java/com/typesafe/config/impl/Path.java from https://github.com/lightbend/config
+seatunnel-config/seatunnel-config-shade/src/main/java/com/typesafe/config/impl/PathParser.java from https://github.com/lightbend/config
+seatunnel-config/seatunnel-config-shade/src/main/java/com/typesafe/config/ConfigParseOptions.java from https://github.com/lightbend/config
Review comment:
please check file path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Yves-yuan closed pull request #1187: [Feature] [config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
Yves-yuan closed pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 edited a comment on pull request #1187: [Feature] [config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
leo65535 edited a comment on pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187#issuecomment-1032231465
you can try following statements to trigger the ci again.
```
git commit --allow-empty -m 'trigger rebuild'
git push
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1187: [Feature] [config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187#issuecomment-1032269603
hi @Yves-yuan, can you check this page https://github.com/Yves-yuan/incubator-seatunnel/actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1187: [Feature] [config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187#issuecomment-1032221247
> > @CalvinKirs Hello,code conflict is resolved,can you help rerunning workflow.
>
> > Looks has some errors need resolve, you can look at the log.
> > 
>
> The log shows that `Error creating assembly archive bin: /home/runner/work/incubator-seatunnel/incubator-seatunnel/seatunnel-dist/../seatunnel-config/target/seatunnel-config-2.0.5-SNAPSHOT.jar` `To see the full stack trace of the errors, re-run Maven with the -e switch.`
>
> I have tested mvn -T 2C -B clean verify -Dmaven.test.skip=false -Dgpg.skip=true in my local env,it works well. Can you rerun maven with -e switch ? @CalvinKirs
rerun~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1187: [Feature] [config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187#issuecomment-1032231465
you can try following statements
```
git commit --allow-empty -m 'trigger rebuild'
git push
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1187: [SeaTunnel#1186] [seatunnel-config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187#discussion_r800075382
##########
File path: seatunnel-config-shade/pom.xml
##########
@@ -0,0 +1,116 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review comment:
Please add a license header here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1187: [Feature] [config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187#issuecomment-1033479165
> You need to refer to this PR to modify the corresponding license, because there are changes to the package name.
https://github.com/apache/incubator-seatunnel/pull/1177/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Yves-yuan commented on pull request #1187: [Feature] [config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
Yves-yuan commented on pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187#issuecomment-1032273938
> hi @Yves-yuan, can you check this page https://github.com/Yves-yuan/incubator-seatunnel/actions
Ok,I checked this page just now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Yves-yuan commented on pull request #1187: [Feature] [config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
Yves-yuan commented on pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187#issuecomment-1032178459
> @CalvinKirs Hello,code conflict is resolved,can you help rerunning workflow.
> Looks has some errors need resolve, you can look at the log.
The log shows that `Error creating assembly archive bin: /home/runner/work/incubator-seatunnel/incubator-seatunnel/seatunnel-dist/../seatunnel-config/target/seatunnel-config-2.0.5-SNAPSHOT.jar`
`To see the full stack trace of the errors, re-run Maven with the -e switch.`
I have tested mvn -T 2C -B clean verify -Dmaven.test.skip=false -Dgpg.skip=true in my local env,it works well.
Can you rerun maven with -e switch ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Yves-yuan commented on pull request #1187: [Feature] [config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
Yves-yuan commented on pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187#issuecomment-1032252062
> you can try following statements to trigger the ci again.
>
> ```
> git commit --allow-empty -m 'trigger rebuild'
> git push
> ```
I have ran these commands,but the workflow didn't start running.
@leo65535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Yves-yuan commented on pull request #1187: [Feature] [config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
Yves-yuan commented on pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187#issuecomment-1032219905
Hello leo65535,
It seems that the workflow was canceled after 30 minutes.I see that you opened the similar issue in https://github.com/apache/incubator-seatunnel/issues/1202#issue-1126677161.So how can i solve this problem? @leo65535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1187: [Feature] [config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187#issuecomment-1032159761
> @CalvinKirs Hello,code conflict is resolved,can you help rerunning workflow.
Looks has some errors need resolve, you can look at the log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 edited a comment on pull request #1187: [SeaTunnel#1186] [seatunnel-config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
leo65535 edited a comment on pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187#issuecomment-1031263482
hi @Yves-yuan, everything is ok in my local env.
if you want to test some case, you can use `LocalFlinkExample`. it seems not necessary to introduce a new config module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Yves-yuan commented on pull request #1187: [Feature] [config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
Yves-yuan commented on pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187#issuecomment-1033533985
> Well done Looking forward to your next contribution
Thx,be willing to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Yves-yuan commented on pull request #1187: [SeaTunnel#1186] [seatunnel-config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
Yves-yuan commented on pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187#issuecomment-1031302197
>
I have tested LocalFlinkExample just now ,it won't throw the error because the order of jar com.typesafe.config is in the front of seatunnel-config\target\classes in classpath.
When I run SeatunnelFlink directly,the order of jar com.typesafe.config is after seatunnel-config\target\classes,so it will throw the error.
So I think it's more reliable to fix this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Yves-yuan edited a comment on pull request #1187: [Feature] [config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
Yves-yuan edited a comment on pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187#issuecomment-1032178459
> @CalvinKirs Hello,code conflict is resolved,can you help rerunning workflow.
> Looks has some errors need resolve, you can look at the log.
The log shows that `Error creating assembly archive bin: /home/runner/work/incubator-seatunnel/incubator-seatunnel/seatunnel-dist/../seatunnel-config/target/seatunnel-config-2.0.5-SNAPSHOT.jar`
`To see the full stack trace of the errors, re-run Maven with the -e switch.`
I have tested mvn -T 2C -B clean verify -Dmaven.test.skip=false -Dgpg.skip=true in my local env,it works well.
Can you rerun maven with -e switch ? @CalvinKirs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Yves-yuan commented on pull request #1187: [Feature] [config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
Yves-yuan commented on pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187#issuecomment-1033488926
> > You need to refer to this PR to modify the corresponding license, because there are changes to the package name.
>
> https://github.com/apache/incubator-seatunnel/pull/1177/files
@CalvinKirs
Hi CalvinKirs,
I have changed the path of seatunnel-conf classes in LICENSE file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #1187: [Feature] [config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Yves-yuan commented on pull request #1187: [Feature] [config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
Yves-yuan commented on pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187#issuecomment-1033441122
@CalvinKirs
Hi CalvinKirs,
the checks of workflow is canceled cause to timeout,can you help rerunning it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Yves-yuan edited a comment on pull request #1187: [Feature] [config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
Yves-yuan edited a comment on pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187#issuecomment-1032277722
@asdf2014
Hi asdf2014,
the checks is passed,can you help reviewing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 edited a comment on pull request #1187: [SeaTunnel#1186] [seatunnel-config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
leo65535 edited a comment on pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187#issuecomment-1031263482
hi @Yves-yuan,
if you want to test some case, you can use `LocalFlinkExample`. it seems not necessary to introduce a new config module.
`seatunnel-example` module will run successfully in local env.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Yves-yuan commented on pull request #1187: [Feature] [config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
Yves-yuan commented on pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187#issuecomment-1032277722
@asdf2014
Hi asdf2014,
the checks finally passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Yves-yuan commented on pull request #1187: [Feature] [config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
Yves-yuan commented on pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187#issuecomment-1032139526
@CalvinKirs Hello,code conflict is resolved,can you help rerunning workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1187: [SeaTunnel#1186] [seatunnel-config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187#issuecomment-1031263482
hi @Yves-yuan, everything is ok in my local env.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Yves-yuan edited a comment on pull request #1187: [SeaTunnel#1186] [seatunnel-config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
Yves-yuan edited a comment on pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187#issuecomment-1031302197
>
Hello,leo65536,
I have tested LocalFlinkExample just now ,it won't throw the error because the order of jar com.typesafe.config is in the front of seatunnel-config\target\classes in classpath.
When I run SeatunnelFlink directly,the order of jar com.typesafe.config is after seatunnel-config\target\classes,so it will throw the error.
So I think it's more reliable to fix this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1187: [Feature] [config] Fix dependency conflict in seatunnel config when running SeatunnelFlink in idea with local mode#1186
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #1187:
URL: https://github.com/apache/incubator-seatunnel/pull/1187#issuecomment-1033555389
Thanks @CalvinKirs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org