You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by ss...@apache.org on 2022/11/21 15:27:06 UTC
[sling-org-apache-sling-testing-osgi-mock] branch master updated: SLING-11691 osgi-mock: Implement MockServiceReference.getProperties
This is an automated email from the ASF dual-hosted git repository.
sseifert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-testing-osgi-mock.git
The following commit(s) were added to refs/heads/master by this push:
new 88e8f0d SLING-11691 osgi-mock: Implement MockServiceReference.getProperties
88e8f0d is described below
commit 88e8f0d518ccfcaee973ca529048ac2be365ae9f
Author: Stefan Seifert <st...@users.noreply.github.com>
AuthorDate: Mon Nov 21 16:26:58 2022 +0100
SLING-11691 osgi-mock: Implement MockServiceReference.getProperties
---
.../apache/sling/testing/mock/osgi/MockServiceReference.java | 10 +++++-----
.../sling/testing/mock/osgi/MockServiceReferenceTest.java | 4 ++++
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/core/src/main/java/org/apache/sling/testing/mock/osgi/MockServiceReference.java b/core/src/main/java/org/apache/sling/testing/mock/osgi/MockServiceReference.java
index 7d286ba..f08e920 100644
--- a/core/src/main/java/org/apache/sling/testing/mock/osgi/MockServiceReference.java
+++ b/core/src/main/java/org/apache/sling/testing/mock/osgi/MockServiceReference.java
@@ -64,6 +64,11 @@ class MockServiceReference<T> implements ServiceReference<T> {
this.comparable = buildComparable();
}
+ @Override
+ public Dictionary<String, Object> getProperties() {
+ return this.serviceRegistration.getProperties();
+ }
+
@Override
public Object getProperty(final String key) {
return this.serviceRegistration.getProperties().get(key);
@@ -129,9 +134,4 @@ class MockServiceReference<T> implements ServiceReference<T> {
throw new UnsupportedOperationException();
}
- @Override
- public Dictionary<String, Object> getProperties() {
- throw new UnsupportedOperationException();
- }
-
}
diff --git a/core/src/test/java/org/apache/sling/testing/mock/osgi/MockServiceReferenceTest.java b/core/src/test/java/org/apache/sling/testing/mock/osgi/MockServiceReferenceTest.java
index 23d8a55..d9aed78 100644
--- a/core/src/test/java/org/apache/sling/testing/mock/osgi/MockServiceReferenceTest.java
+++ b/core/src/test/java/org/apache/sling/testing/mock/osgi/MockServiceReferenceTest.java
@@ -68,6 +68,10 @@ public class MockServiceReferenceTest {
// mandatory properties set by the container
assertNotNull(this.serviceReference.getProperty(Constants.SERVICE_ID));
assertArrayEquals((String[]) this.serviceReference.getProperty(Constants.OBJECTCLASS), new String[] { String.class.getName() });
+
+ // via dictionary
+ assertEquals(3, this.serviceReference.getProperties().size());
+ assertEquals("value1", this.serviceReference.getProperties().get("customProp1"));
}
}