You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/07 15:58:43 UTC

[GitHub] [arrow] alamb opened a new pull request #9127: ARROW-11165: [Rust][DataFusion] Document Postgres as standard SQL dialect

alamb opened a new pull request #9127:
URL: https://github.com/apache/arrow/pull/9127


   Document the target dialect and rationale for its choice. I will also send an email to the dev mailing list soliciting feedback 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] seddonm1 commented on pull request #9127: ARROW-11165: [Rust][DataFusion] Document Postgres as standard SQL dialect

Posted by GitBox <gi...@apache.org>.
seddonm1 commented on pull request #9127:
URL: https://github.com/apache/arrow/pull/9127#issuecomment-756374744


   @alamb thanks for organising this!
   
   > I agree. Another advantage is that it focus development towards implementing that dialect. :)
   
   Yes, I was hoping once we reach a decision we can do a comparison between what we have and what Postgres has then just work through the list.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on pull request #9127: ARROW-11165: [Rust][DataFusion] Document Postgres as standard SQL dialect

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9127:
URL: https://github.com/apache/arrow/pull/9127#issuecomment-757134768


   I plan to merge this on Monday Jan 11 2021 unless I hear any objections


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorgecarleitao commented on pull request #9127: ARROW-11165: [Rust][DataFusion] Document Postgres as standard SQL dialect

Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #9127:
URL: https://github.com/apache/arrow/pull/9127#issuecomment-756215072


   I agree. Another advantage is that it focus development towards implementing that dialect. :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] paddyhoran commented on a change in pull request #9127: ARROW-11165: [Rust][DataFusion] Document Postgres as standard SQL dialect

Posted by GitBox <gi...@apache.org>.
paddyhoran commented on a change in pull request #9127:
URL: https://github.com/apache/arrow/pull/9127#discussion_r554549874



##########
File path: rust/datafusion/README.md
##########
@@ -91,6 +91,13 @@ This library currently supports the following SQL constructs:
 * `GROUP BY` together with one of the following aggregations: `MIN`, `MAX`, `COUNT`, `SUM`, `AVG`
 * `ORDER BY` together with an expression and optional `ASC` or `DESC` and also optional `NULLS FIRST` or `NULLS LAST`
 
+## Supported Functions
+
+DataFusion implements a subset of the [PostgreSQL SQL dialect](https://www.postgresql.org/docs/current/functions.html) where possible. We explicitly choose a single dialect to maximize interoperability with other tools and allow reuse of the PostgreSQL documents and tutorials as much as possible.
+
+Currently, only a subset of the PosgreSQL dialect is implemented, and we will document any deviations.

Review comment:
       Do we have a list or table somewhere that show what we currently support?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on pull request #9127: ARROW-11165: [Rust][DataFusion] Document Postgres as standard SQL dialect

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9127:
URL: https://github.com/apache/arrow/pull/9127#issuecomment-756713282


   > Yes, I was hoping once we reach a decision we can do a comparison between what we have and what Postgres has then just work through the list.
   
   Sounds like a good plan @seddonm1  -- given that postgres has more than 20 years of official releases I suspect the list will be long and distinguished :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on pull request #9127: ARROW-11165: [Rust][DataFusion] Document Postgres as standard SQL dialect

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9127:
URL: https://github.com/apache/arrow/pull/9127#issuecomment-756713282






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb closed pull request #9127: ARROW-11165: [Rust][DataFusion] Document Postgres as standard SQL dialect

Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9127:
URL: https://github.com/apache/arrow/pull/9127


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] codecov-io commented on pull request #9127: ARROW-11165: [Rust][DataFusion] Document Postgres as standard SQL dialect

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9127:
URL: https://github.com/apache/arrow/pull/9127#issuecomment-757497398


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/9127?src=pr&el=h1) Report
   > Merging [#9127](https://codecov.io/gh/apache/arrow/pull/9127?src=pr&el=desc) (0b60268) into [master](https://codecov.io/gh/apache/arrow/commit/3622a2ef1abe96bc21b178eaad66c34df73f67c6?el=desc) (3622a2e) will **decrease** coverage by `0.79%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9127/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9127?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9127      +/-   ##
   ==========================================
   - Coverage   82.59%   81.80%   -0.80%     
   ==========================================
     Files         204      214      +10     
     Lines       50526    51383     +857     
   ==========================================
   + Hits        41732    42033     +301     
   - Misses       8794     9350     +556     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9127?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/datafusion/src/datasource/csv.rs](https://codecov.io/gh/apache/arrow/pull/9127/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL2Nzdi5ycw==) | `65.00% <0.00%> (-16.25%)` | :arrow_down: |
   | [rust/datafusion/src/datasource/parquet.rs](https://codecov.io/gh/apache/arrow/pull/9127/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL3BhcnF1ZXQucnM=) | `94.77% <0.00%> (-1.44%)` | :arrow_down: |
   | [rust/datafusion/src/physical\_plan/expressions.rs](https://codecov.io/gh/apache/arrow/pull/9127/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zLnJz) | `83.77% <0.00%> (-0.71%)` | :arrow_down: |
   | [rust/datafusion/src/sql/utils.rs](https://codecov.io/gh/apache/arrow/pull/9127/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9zcWwvdXRpbHMucnM=) | `53.92% <0.00%> (-0.68%)` | :arrow_down: |
   | [rust/datafusion/src/optimizer/utils.rs](https://codecov.io/gh/apache/arrow/pull/9127/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9vcHRpbWl6ZXIvdXRpbHMucnM=) | `58.18% <0.00%> (-0.54%)` | :arrow_down: |
   | [rust/arrow/src/ipc/writer.rs](https://codecov.io/gh/apache/arrow/pull/9127/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvaXBjL3dyaXRlci5ycw==) | `83.21% <0.00%> (-0.05%)` | :arrow_down: |
   | [rust/arrow-flight/src/utils.rs](https://codecov.io/gh/apache/arrow/pull/9127/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy1mbGlnaHQvc3JjL3V0aWxzLnJz) | `0.00% <0.00%> (ø)` | |
   | [rust/arrow/src/ipc/gen/Schema.rs](https://codecov.io/gh/apache/arrow/pull/9127/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvaXBjL2dlbi9TY2hlbWEucnM=) | `39.71% <0.00%> (ø)` | |
   | [rust/arrow/src/array/equal/boolean.rs](https://codecov.io/gh/apache/arrow/pull/9127/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvZXF1YWwvYm9vbGVhbi5ycw==) | `100.00% <0.00%> (ø)` | |
   | [rust/arrow/src/ipc/gen/SparseTensor.rs](https://codecov.io/gh/apache/arrow/pull/9127/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvaXBjL2dlbi9TcGFyc2VUZW5zb3IucnM=) | `0.00% <0.00%> (ø)` | |
   | ... and [22 more](https://codecov.io/gh/apache/arrow/pull/9127/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9127?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9127?src=pr&el=footer). Last update [3622a2e...0b60268](https://codecov.io/gh/apache/arrow/pull/9127?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on a change in pull request #9127: ARROW-11165: [Rust][DataFusion] Document Postgres as standard SQL dialect

Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #9127:
URL: https://github.com/apache/arrow/pull/9127#discussion_r554583182



##########
File path: rust/datafusion/README.md
##########
@@ -91,6 +91,13 @@ This library currently supports the following SQL constructs:
 * `GROUP BY` together with one of the following aggregations: `MIN`, `MAX`, `COUNT`, `SUM`, `AVG`
 * `ORDER BY` together with an expression and optional `ASC` or `DESC` and also optional `NULLS FIRST` or `NULLS LAST`
 
+## Supported Functions
+
+DataFusion implements a subset of the [PostgreSQL SQL dialect](https://www.postgresql.org/docs/current/functions.html) where possible. We explicitly choose a single dialect to maximize interoperability with other tools and allow reuse of the PostgreSQL documents and tutorials as much as possible.

Review comment:
       ```suggestion
   DataFusion strives to implement a subset of the [PostgreSQL SQL dialect](https://www.postgresql.org/docs/current/functions.html) where possible. We explicitly choose a single dialect to maximize interoperability with other tools and allow reuse of the PostgreSQL documents and tutorials as much as possible.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] Dandandan commented on pull request #9127: ARROW-11165: [Rust][DataFusion] Document Postgres as standard SQL dialect

Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #9127:
URL: https://github.com/apache/arrow/pull/9127#issuecomment-756230265


   Makes sense to me, seems a strategy more are following lately? I would suggest to strive for _compatibility_ with the PostgreSQL dialect, but also allow for some extensions such as functions that are not in PostgreSQL but still a valuable addition to DataFusion.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #9127: ARROW-11165: [Rust][DataFusion] Document Postgres as standard SQL dialect

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9127:
URL: https://github.com/apache/arrow/pull/9127#issuecomment-756205851


   https://issues.apache.org/jira/browse/ARROW-11165


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on pull request #9127: ARROW-11165: [Rust][DataFusion] Document Postgres as standard SQL dialect

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9127:
URL: https://github.com/apache/arrow/pull/9127#issuecomment-757888032


   Given no other comments or opinions to the contrary I am merging this in


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] paddyhoran commented on a change in pull request #9127: ARROW-11165: [Rust][DataFusion] Document Postgres as standard SQL dialect

Posted by GitBox <gi...@apache.org>.
paddyhoran commented on a change in pull request #9127:
URL: https://github.com/apache/arrow/pull/9127#discussion_r554549874



##########
File path: rust/datafusion/README.md
##########
@@ -91,6 +91,13 @@ This library currently supports the following SQL constructs:
 * `GROUP BY` together with one of the following aggregations: `MIN`, `MAX`, `COUNT`, `SUM`, `AVG`
 * `ORDER BY` together with an expression and optional `ASC` or `DESC` and also optional `NULLS FIRST` or `NULLS LAST`
 
+## Supported Functions
+
+DataFusion implements a subset of the [PostgreSQL SQL dialect](https://www.postgresql.org/docs/current/functions.html) where possible. We explicitly choose a single dialect to maximize interoperability with other tools and allow reuse of the PostgreSQL documents and tutorials as much as possible.
+
+Currently, only a subset of the PosgreSQL dialect is implemented, and we will document any deviations.

Review comment:
       Do we have a list or table somewhere that shows what we currently support?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on a change in pull request #9127: ARROW-11165: [Rust][DataFusion] Document Postgres as standard SQL dialect

Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #9127:
URL: https://github.com/apache/arrow/pull/9127#discussion_r554583277



##########
File path: rust/datafusion/README.md
##########
@@ -91,6 +91,13 @@ This library currently supports the following SQL constructs:
 * `GROUP BY` together with one of the following aggregations: `MIN`, `MAX`, `COUNT`, `SUM`, `AVG`
 * `ORDER BY` together with an expression and optional `ASC` or `DESC` and also optional `NULLS FIRST` or `NULLS LAST`
 
+## Supported Functions
+
+DataFusion implements a subset of the [PostgreSQL SQL dialect](https://www.postgresql.org/docs/current/functions.html) where possible. We explicitly choose a single dialect to maximize interoperability with other tools and allow reuse of the PostgreSQL documents and tutorials as much as possible.

Review comment:
       updating per @Dandandan  to say we strive to implement. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] seddonm1 commented on pull request #9127: ARROW-11165: [Rust][DataFusion] Document Postgres as standard SQL dialect

Posted by GitBox <gi...@apache.org>.
seddonm1 commented on pull request #9127:
URL: https://github.com/apache/arrow/pull/9127#issuecomment-757456900


   I was planning to put one together in the next few days
   
   On Sun, 10 Jan 2021, 10:00 pm Paddy Horan, <no...@github.com> wrote:
   
   > *@paddyhoran* commented on this pull request.
   > ------------------------------
   >
   > In rust/datafusion/README.md
   > <https://github.com/apache/arrow/pull/9127#discussion_r554549874>:
   >
   > > @@ -91,6 +91,13 @@ This library currently supports the following SQL constructs:
   >  * `GROUP BY` together with one of the following aggregations: `MIN`, `MAX`, `COUNT`, `SUM`, `AVG`
   >  * `ORDER BY` together with an expression and optional `ASC` or `DESC` and also optional `NULLS FIRST` or `NULLS LAST`
   >
   > +## Supported Functions
   > +
   > +DataFusion implements a subset of the [PostgreSQL SQL dialect](https://www.postgresql.org/docs/current/functions.html) where possible. We explicitly choose a single dialect to maximize interoperability with other tools and allow reuse of the PostgreSQL documents and tutorials as much as possible.
   > +
   > +Currently, only a subset of the PosgreSQL dialect is implemented, and we will document any deviations.
   >
   > Do we have a list or table somewhere that show what we currently support?
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/arrow/pull/9127#pullrequestreview-564852303>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AA2O2UGHFZBNA72B6OJIAZLSZGCEHANCNFSM4VZFOD2A>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org