You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2015/11/07 23:38:18 UTC

svn commit: r1713193 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/Constants.java

Author: markt
Date: Sat Nov  7 22:38:18 2015
New Revision: 1713193

URL: http://svn.apache.org/viewvc?rev=1713193&view=rev
Log:
Remove unused constant.
Reported by UC Detector

Modified:
    tomcat/trunk/java/org/apache/tomcat/websocket/server/Constants.java

Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/Constants.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/server/Constants.java?rev=1713193&r1=1713192&r2=1713193&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/websocket/server/Constants.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/websocket/server/Constants.java Sat Nov  7 22:38:18 2015
@@ -31,8 +31,6 @@ public class Constants {
     // Executor configuration
     public static final String EXECUTOR_CORE_SIZE_INIT_PARAM =
             "org.apache.tomcat.websocket.executorCoreSize";
-    public static final String EXECUTOR_MAX_SIZE_INIT_PARAM =
-            "org.apache.tomcat.websocket.executorMaxSize";
     public static final String EXECUTOR_KEEPALIVETIME_SECONDS_INIT_PARAM =
             "org.apache.tomcat.websocket.executorKeepAliveTimeSeconds";
 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1713193 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/Constants.java

Posted by Mark Thomas <ma...@apache.org>.
On 07/11/2015 23:00, Konstantin Kolinko wrote:
> 2015-11-08 1:38 GMT+03:00  <ma...@apache.org>:
>> Author: markt
>> Date: Sat Nov  7 22:38:18 2015
>> New Revision: 1713193
>>
>> URL: http://svn.apache.org/viewvc?rev=1713193&view=rev
>> Log:
>> Remove unused constant.
>> Reported by UC Detector
>>
>> Modified:
>>     tomcat/trunk/java/org/apache/tomcat/websocket/server/Constants.java
>>
>> Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/Constants.java
>> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/server/Constants.java?rev=1713193&r1=1713192&r2=1713193&view=diff
>> ==============================================================================
>> --- tomcat/trunk/java/org/apache/tomcat/websocket/server/Constants.java (original)
>> +++ tomcat/trunk/java/org/apache/tomcat/websocket/server/Constants.java Sat Nov  7 22:38:18 2015
>> @@ -31,8 +31,6 @@ public class Constants {
>>      // Executor configuration
>>      public static final String EXECUTOR_CORE_SIZE_INIT_PARAM =
>>              "org.apache.tomcat.websocket.executorCoreSize";
>> -    public static final String EXECUTOR_MAX_SIZE_INIT_PARAM =
>> -            "org.apache.tomcat.websocket.executorMaxSize";
>>      public static final String EXECUTOR_KEEPALIVETIME_SECONDS_INIT_PARAM =
>>              "org.apache.tomcat.websocket.executorKeepAliveTimeSeconds";
> 
> 
> Deprecate in 8.0.x ?

Done. Tx.

Mark


> For a reference:
> This parameter was removed (hard-coded as Integer.MAX_VALUE) as the
> fix for BZ 56577.
> https://bz.apache.org/bugzilla/show_bug.cgi?id=56577
> http://svn.apache.org/r1600743
> 
> Documentation is OK, this parameter is not mentioned there.:
> web-socket-howto.xml was updated by BZ 56577 fix/
> 
> Best regards,
> Konstantin Kolinko
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1713193 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/Constants.java

Posted by Konstantin Kolinko <kn...@gmail.com>.
2015-11-08 1:38 GMT+03:00  <ma...@apache.org>:
> Author: markt
> Date: Sat Nov  7 22:38:18 2015
> New Revision: 1713193
>
> URL: http://svn.apache.org/viewvc?rev=1713193&view=rev
> Log:
> Remove unused constant.
> Reported by UC Detector
>
> Modified:
>     tomcat/trunk/java/org/apache/tomcat/websocket/server/Constants.java
>
> Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/Constants.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/server/Constants.java?rev=1713193&r1=1713192&r2=1713193&view=diff
> ==============================================================================
> --- tomcat/trunk/java/org/apache/tomcat/websocket/server/Constants.java (original)
> +++ tomcat/trunk/java/org/apache/tomcat/websocket/server/Constants.java Sat Nov  7 22:38:18 2015
> @@ -31,8 +31,6 @@ public class Constants {
>      // Executor configuration
>      public static final String EXECUTOR_CORE_SIZE_INIT_PARAM =
>              "org.apache.tomcat.websocket.executorCoreSize";
> -    public static final String EXECUTOR_MAX_SIZE_INIT_PARAM =
> -            "org.apache.tomcat.websocket.executorMaxSize";
>      public static final String EXECUTOR_KEEPALIVETIME_SECONDS_INIT_PARAM =
>              "org.apache.tomcat.websocket.executorKeepAliveTimeSeconds";


Deprecate in 8.0.x ?

For a reference:
This parameter was removed (hard-coded as Integer.MAX_VALUE) as the
fix for BZ 56577.
https://bz.apache.org/bugzilla/show_bug.cgi?id=56577
http://svn.apache.org/r1600743

Documentation is OK, this parameter is not mentioned there.:
web-socket-howto.xml was updated by BZ 56577 fix/

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org