You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by HeartSaVioR <gi...@git.apache.org> on 2015/12/22 05:26:05 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-527 Fix NPE while retrie...
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/562
ZEPPELIN-527 Fix NPE while retrieving job status from notebook
### What is this PR for?
Fix NPE while retrieving job status from notebook which contains "never run" / "first run but not finished".
### What type of PR is it?
Bug Fix
### Todos
* [ ] -
### Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-527
### How should this be tested?
1. Create a new notebook (```but don't run notebook!```)
2. Open ```http://<zeppelin host>:<zeppelin port>/api/notebook/job/<new notebook id>
3. You can see HTTP STATUS 500 before this PR, but you can see HTTP STATUS 200 after this PR.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? (No)
* Is there breaking changes for older versions? (No)
* Does this needs documentation? (No)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/incubator-zeppelin ZEPPELIN-527
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/562.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #562
----
commit f296406b920d7374f821f46d873b54e718137153
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2015-12-22T04:15:32Z
ZEPPELIN-527 Fix NPE while retrieving job status from notebook
* Paragraph.getDateStarted() and Paragraph.getDateFinished() could be null
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-527 Fix NPE while retrie...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/562#issuecomment-166504216
The fix looks good to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-527 Fix NPE while retrie...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/562#issuecomment-167029970
LGTM and merge if there're no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-527 Fix NPE while retrie...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/562#issuecomment-166504962
@Leemoonsoo
Thanks for the review!
Regarding preference, do you think we should include null field to JSON, or leave as it is?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-527 Fix NPE while retrie...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/562#issuecomment-166802602
@bzz Addressed your comment.
@Leemoonsoo @bzz Ready for another round of review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-527 Fix NPE while retrie...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/562#issuecomment-166507478
I think it's okay to leave it as is. But which do you think better?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-527 Fix NPE while retrie...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/562#issuecomment-166502717
There seems to some preference, representing null value.
If we think it would be better to represent null value as below,
```
{
"status":"OK",
"body":[
{
"id":"20151222-132414_1405594849",
"status":"READY",
"started":null,
"finished":null
}
]
}
```
I'll take care of it.
Please review and comment. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-527 Fix NPE while retrie...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/562
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-527 Fix NPE while retrie...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/562#issuecomment-166507936
At first I expect that null value from Map could be represented as null value to JSON, but it is not represented as I expected.
Anyway, it is just a preference so I'm okay to leave it as is.
Maybe some other contributors / committers could comment their preferences.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---