You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "lrbarber (via GitHub)" <gi...@apache.org> on 2023/04/05 13:02:07 UTC
[GitHub] [daffodil-vscode] lrbarber opened a new issue, #568: Click upon seperator space in Logical window
lrbarber opened a new issue, #568:
URL: https://github.com/apache/daffodil-vscode/issues/568
It is possible to click on the space inserted between characters in the Logical window. This results in an unmoved and empty Edit widget and if you were previously in the Physical window, the widget remains there...
You can see the outline shows that the Logical window was clicked in, but the Edit widget is still in the Physical, but is now empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] lrbarber commented on issue #568: Click upon seperator space in Logical window
Posted by "lrbarber (via GitHub)" <gi...@apache.org>.
lrbarber commented on issue #568:
URL: https://github.com/apache/daffodil-vscode/issues/568#issuecomment-1497807330
With single clicks, the Data View window seems to work correctly -- so the algorithm works, but somehow that information doesn't get fed to the ephemeral window.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stricklandrbls closed issue #568: Click upon seperator space in Logical window
Posted by "stricklandrbls (via GitHub)" <gi...@apache.org>.
stricklandrbls closed issue #568: Click upon seperator space in Logical window
URL: https://github.com/apache/daffodil-vscode/issues/568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stricklandrbls commented on issue #568: Click upon seperator space in Logical window
Posted by "stricklandrbls (via GitHub)" <gi...@apache.org>.
stricklandrbls commented on issue #568:
URL: https://github.com/apache/daffodil-vscode/issues/568#issuecomment-1497794142
@lrbarber So in regards to _this_ issue, this happens because there is an algorithm in place to determine is the user has clicked on whitespace in either viewport while making a selection. It then corrects the selection range, cross-references the byte at the _intended_ selection location, then presents the window.
### Current "_Workaround_"
In order to prevent this from happening:
1. The user must click precisely in the middle of the whitespace character, which is significantly more difficult to do without the correct `Latin1StandinChar` rendering.
2. The user must click / drag over a singular byte in the Logical view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] lrbarber commented on issue #568: Click upon seperator space in Logical window
Posted by "lrbarber (via GitHub)" <gi...@apache.org>.
lrbarber commented on issue #568:
URL: https://github.com/apache/daffodil-vscode/issues/568#issuecomment-1497460509
This can also occur when clicking in the Physical window.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stricklandrbls commented on issue #568: Click upon seperator space in Logical window
Posted by "stricklandrbls (via GitHub)" <gi...@apache.org>.
stricklandrbls commented on issue #568:
URL: https://github.com/apache/daffodil-vscode/issues/568#issuecomment-1497657764
@lrbarber are you on the latest branch? That Latin-1 character standin is not what is currently implemented as the standin.
**Your branch's standin**
_should_ look like
I see that the empty spaces are actually `0x20` or an ascii space character but I'm not sure why your standin looks different unless it's OS / font related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stricklandrbls closed issue #568: Click upon seperator space in Logical window
Posted by "stricklandrbls (via GitHub)" <gi...@apache.org>.
stricklandrbls closed issue #568: Click upon seperator space in Logical window
URL: https://github.com/apache/daffodil-vscode/issues/568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] lrbarber commented on issue #568: Click upon seperator space in Logical window
Posted by "lrbarber (via GitHub)" <gi...@apache.org>.
lrbarber commented on issue #568:
URL: https://github.com/apache/daffodil-vscode/issues/568#issuecomment-1497516615
Interestingly, the Data View **does** update (offset & values)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] lrbarber commented on issue #568: Click upon seperator space in Logical window
Posted by "lrbarber (via GitHub)" <gi...@apache.org>.
lrbarber commented on issue #568:
URL: https://github.com/apache/daffodil-vscode/issues/568#issuecomment-1497666871
I update yesterday morning. It used to show a diamond so I thought this was the new standin. I'm running on Rocky 9.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stricklandrbls commented on issue #568: Click upon seperator space in Logical window
Posted by "stricklandrbls (via GitHub)" <gi...@apache.org>.
stricklandrbls commented on issue #568:
URL: https://github.com/apache/daffodil-vscode/issues/568#issuecomment-1497828363
So the Data View is based off the cursor position of where the user clicks and registers a start index for a selection. This is done prior to the whitespace detection alignment so the Data View will serve information based on that info.
I believe that the whitespace alignment is eventually calculating a null value and that's why no data is being populated into the edit byte window's input field. Fixing this would require altering how the whitespace determination takes place.
I'll continue to look into this for a solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org