[PR] perf: Use react-router to toggle fullscreen mode on dashboard [superset]

["kgabryje (via GitHub)" <gi...@apache.org>]

kgabryje opened a new pull request, #34857:
URL: https://github.com/apache/superset/pull/34857

   ### SUMMARY
   This PR replaces window.location.replace call with react-router `history.replace` in order to stay within SPA context when toggling full screen mode on a dashboard. The operation is much quicker now + we avoid a white flash when in dark mode.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   1. Open a dashboard
   2. Click on dashboard menu -> "Enter fullscreen"/"Exit fullscreen"
   3. Verify that fullscreen mode works like before (but quicker)
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] perf: Use react-router to toggle fullscreen mode on dashboard [superset]

["kgabryje (via GitHub)" <gi...@apache.org>]

kgabryje merged PR #34857:
URL: https://github.com/apache/superset/pull/34857


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org