You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/04/21 09:27:54 UTC
[GitHub] zeppelin pull request #2273: [ZEPPELIN-2439] Use babel-preset-env to specify...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2273
[ZEPPELIN-2439] Use babel-preset-env to specify browser compatibility explicitly
### What is this PR for?
Use babel-preset-env to specify browser compatibility explicitly.
This will help to resolve some IE browser issues.
- last 5 versions of major browsers
- `> %5` in the world
- IE 9+
- safari 7+
- chrome 47+
- firefox 31+ (due to travis CI)
See also - [Browser Compatibility Table](https://kangax.github.io/compat-table/es6/)
### What type of PR is it?
[Improvement]
### Todos
* [x] - Setup babel-preset-env for web
* [x] - Setup babel-preset-env for helium
### What is the Jira issue?
[ZEPPELIN-2439](https://issues.apache.org/jira/browse/ZEPPELIN-2439)
### How should this be tested?
1. should be able to bundle existing helium packages
2. execute `npm run build` in `zeppelin-web`
3. should be able to see message like
```
babel-preset-env: `DEBUG` option
Using targets:
{
"chrome": 47,
"edge": 12,
"firefox": 31,
"ie": 7,
"ios": 8,
"safari": 7
}
Modules transform: commonjs
Using plugins:
check-es2015-constants {"chrome":47,"edge":12,"firefox":31,"ie":7,"ios":8,"safari":7}
transform-es2015-arrow-functions {"edge":12,"firefox":31,"ie":7,"ios":8,"safari":7}
transform-es2015-block-scoped-functions {"firefox":31,"ie":7,"ios":8,"safari":7}
transform-es2015-block-scoping {"chrome":47,"edge":12,"firefox":31,"ie":7,"ios":8,"safari":7}
transform-es2015-classes {"edge":12,"firefox":31,"ie":7,"ios":8,"safari":7}
transform-es2015-computed-properties {"firefox":31,"ie":7,"safari":7}
transform-es2015-destructuring {"chrome":47,"edge":12,"firefox":31,"ie":7,"ios":8,"safari":7}
transform-es2015-duplicate-keys {"firefox":31,"ie":7,"ios":8,"safari":7}
transform-es2015-for-of {"chrome":47,"edge":12,"firefox":31,"ie":7,"ios":8,"safari":7}
transform-es2015-function-name {"chrome":47,"edge":12,"firefox":31,"ie":7,"ios":8,"safari":7}
transform-es2015-literals {"firefox":31,"ie":7,"ios":8,"safari":7}
transform-es2015-object-super {"edge":12,"firefox":31,"ie":7,"ios":8,"safari":7}
transform-es2015-parameters {"chrome":47,"edge":12,"firefox":31,"ie":7,"ios":8,"safari":7}
transform-es2015-shorthand-properties {"firefox":31,"ie":7,"ios":8,"safari":7}
transform-es2015-spread {"edge":12,"firefox":31,"ie":7,"ios":8,"safari":7}
transform-es2015-sticky-regex {"chrome":47,"edge":12,"ie":7,"ios":8,"safari":7}
transform-es2015-template-literals {"edge":12,"firefox":31,"ie":7,"ios":8,"safari":7}
transform-es2015-typeof-symbol {"firefox":31,"ie":7,"ios":8,"safari":7}
transform-es2015-unicode-regex {"chrome":47,"edge":12,"firefox":31,"ie":7,"ios":8,"safari":7}
transform-regenerator {"chrome":47,"edge":12,"firefox":31,"ie":7,"ios":8,"safari":7}
transform-exponentiation-operator {"chrome":47,"edge":12,"firefox":31,"ie":7,"ios":8,"safari":7}
transform-async-to-generator {"chrome":47,"edge":12,"firefox":31,"ie":7,"ios":8,"safari":7}
syntax-trailing-function-commas {"chrome":47,"edge":12,"firefox":31,"ie":7,"ios":8,"safari":7}
```
### Screenshots (if appropriate)
NONE
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2439/use-babel-preset-env
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2273.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2273
----
commit 244468d0e1bfbd8ca1a4f89e0cf237371801b475
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-21T08:26:20Z
feat: Apply preset env to zeppelin-web
commit a62d9b35fcccdbcfb0ea2aec2a594319a46c5565
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-21T09:15:28Z
feat: Apply preset env to helium
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2273: [ZEPPELIN-2439] Use babel-preset-env to specify browse...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2273
LGTM.
Merge to master if no further comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2273: [ZEPPELIN-2439] Use babel-preset-env to specify...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2273
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---