You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Phil Steitz (JIRA)" <ji...@apache.org> on 2011/05/14 18:40:47 UTC
[jira] [Created] (MATH-575) Exceptions in genetics package or not
consistent with the rest of [math]
Exceptions in genetics package or not consistent with the rest of [math]
------------------------------------------------------------------------
Key: MATH-575
URL: https://issues.apache.org/jira/browse/MATH-575
Project: Commons Math
Issue Type: Bug
Affects Versions: 2.2, 2.1, 2.0
Reporter: Phil Steitz
Assignee: Phil Steitz
Priority: Minor
Fix For: 3.0
InvalidRepresentationException is checked and non-localized. This exception should be placed in the [math] hierarchy. The AbstractListChromosome constructor also throws a non-localised IAE, which should be replaced by an appropriate [math] exception.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-575) Exceptions in genetics package or not
consistent with the rest of [math]
Posted by "Thomas Neidhart (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192047#comment-13192047 ]
Thomas Neidhart commented on MATH-575:
--------------------------------------
Fixed in r1235197.
Thanks for your suggestions!
> Exceptions in genetics package or not consistent with the rest of [math]
> ------------------------------------------------------------------------
>
> Key: MATH-575
> URL: https://issues.apache.org/jira/browse/MATH-575
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 2.0, 2.1, 2.2
> Reporter: Phil Steitz
> Priority: Minor
> Fix For: 3.0
>
>
> InvalidRepresentationException is checked and non-localized. This exception should be placed in the [math] hierarchy. The AbstractListChromosome constructor also throws a non-localised IAE, which should be replaced by an appropriate [math] exception.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-575) Exceptions in genetics package or not
consistent with the rest of [math]
Posted by "Gilles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191602#comment-13191602 ]
Gilles commented on MATH-575:
-----------------------------
Thanks for working on this, but before you do start to make modifications, please assign the issue to yourself!
For the changes themselves, I don't agree with the creation of those many localized messages: We have been trying to rationalize and reduce the number of those, by removing duplicates and combining several ones to convey the full explanation of the problem. See my reply to the commit message.
> Exceptions in genetics package or not consistent with the rest of [math]
> ------------------------------------------------------------------------
>
> Key: MATH-575
> URL: https://issues.apache.org/jira/browse/MATH-575
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 2.0, 2.1, 2.2
> Reporter: Phil Steitz
> Priority: Minor
> Fix For: 3.0
>
>
> InvalidRepresentationException is checked and non-localized. This exception should be placed in the [math] hierarchy. The AbstractListChromosome constructor also throws a non-localised IAE, which should be replaced by an appropriate [math] exception.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MATH-575) Exceptions in genetics package or not
consistent with the rest of [math]
Posted by "Thomas Neidhart (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Neidhart resolved MATH-575.
----------------------------------
Resolution: Fixed
Ah ok, that makes it clear. When reading hierarchy I was just thinking in terms of packages rather than class hierarchy.
Thus, I resolve this issue.
> Exceptions in genetics package or not consistent with the rest of [math]
> ------------------------------------------------------------------------
>
> Key: MATH-575
> URL: https://issues.apache.org/jira/browse/MATH-575
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 2.0, 2.1, 2.2
> Reporter: Phil Steitz
> Assignee: Thomas Neidhart
> Priority: Minor
> Fix For: 3.0
>
>
> InvalidRepresentationException is checked and non-localized. This exception should be placed in the [math] hierarchy. The AbstractListChromosome constructor also throws a non-localised IAE, which should be replaced by an appropriate [math] exception.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MATH-575) Exceptions in genetics package or not
consistent with the rest of [math]
Posted by "Phil Steitz (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phil Steitz updated MATH-575:
-----------------------------
Assignee: (was: Phil Steitz)
> Exceptions in genetics package or not consistent with the rest of [math]
> ------------------------------------------------------------------------
>
> Key: MATH-575
> URL: https://issues.apache.org/jira/browse/MATH-575
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 2.0, 2.1, 2.2
> Reporter: Phil Steitz
> Priority: Minor
> Fix For: 3.0
>
>
> InvalidRepresentationException is checked and non-localized. This exception should be placed in the [math] hierarchy. The AbstractListChromosome constructor also throws a non-localised IAE, which should be replaced by an appropriate [math] exception.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-575) Exceptions in genetics package or not
consistent with the rest of [math]
Posted by "Thomas Neidhart (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191560#comment-13191560 ]
Thomas Neidhart commented on MATH-575:
--------------------------------------
Phil started to work on this issue in r1135025.
In r1235038 additional cleanups have been performed:
- add localized messages for all exceptions
- add @throws to javadoc where appropriate
- add final to method parameters
What is missing:
- Phil mentioned that InvalidRepresentationException should be placed into [math], although I am not sure why, as it is not used outside the genetics package
- add more custom exception classes specific to the genetics package (optional). By now mostly MathIllegalArgumentException or other appropriate ones have been used.
> Exceptions in genetics package or not consistent with the rest of [math]
> ------------------------------------------------------------------------
>
> Key: MATH-575
> URL: https://issues.apache.org/jira/browse/MATH-575
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 2.0, 2.1, 2.2
> Reporter: Phil Steitz
> Priority: Minor
> Fix For: 3.0
>
>
> InvalidRepresentationException is checked and non-localized. This exception should be placed in the [math] hierarchy. The AbstractListChromosome constructor also throws a non-localised IAE, which should be replaced by an appropriate [math] exception.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MATH-575) Exceptions in genetics package or not
consistent with the rest of [math]
Posted by "Gilles (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gilles updated MATH-575:
------------------------
Assignee: Thomas Neidhart
Thomas,
Could please check whether this issue is resolved? And if it is, mark it so? Thanks.
> Exceptions in genetics package or not consistent with the rest of [math]
> ------------------------------------------------------------------------
>
> Key: MATH-575
> URL: https://issues.apache.org/jira/browse/MATH-575
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 2.0, 2.1, 2.2
> Reporter: Phil Steitz
> Assignee: Thomas Neidhart
> Priority: Minor
> Fix For: 3.0
>
>
> InvalidRepresentationException is checked and non-localized. This exception should be placed in the [math] hierarchy. The AbstractListChromosome constructor also throws a non-localised IAE, which should be replaced by an appropriate [math] exception.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-575) Exceptions in genetics package or not
consistent with the rest of [math]
Posted by "Thomas Neidhart (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198680#comment-13198680 ]
Thomas Neidhart commented on MATH-575:
--------------------------------------
As from the original issue description, Phil intended to move the InvalidRepresentationException to the general o.a.c.m.exceptions package. I am not sure about this, that's why I kept it aside for the time being. If we agree on keeping it in the genetics package we can resolve this issue.
> Exceptions in genetics package or not consistent with the rest of [math]
> ------------------------------------------------------------------------
>
> Key: MATH-575
> URL: https://issues.apache.org/jira/browse/MATH-575
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 2.0, 2.1, 2.2
> Reporter: Phil Steitz
> Assignee: Thomas Neidhart
> Priority: Minor
> Fix For: 3.0
>
>
> InvalidRepresentationException is checked and non-localized. This exception should be placed in the [math] hierarchy. The AbstractListChromosome constructor also throws a non-localised IAE, which should be replaced by an appropriate [math] exception.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-575) Exceptions in genetics package or not
consistent with the rest of [math]
Posted by "Gilles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198689#comment-13198689 ]
Gilles commented on MATH-575:
-----------------------------
Phil had always been opposed to having all exceptions grouped in their own package; so I doubt that he meant to move that one over there... ;-)
Here, the description just indicates that the exception should become _unchecked_ and that the "detailed message" should be an element from the "LocalizedFormats" enum (i.e. derive from one of the base CM exceptions).
> Exceptions in genetics package or not consistent with the rest of [math]
> ------------------------------------------------------------------------
>
> Key: MATH-575
> URL: https://issues.apache.org/jira/browse/MATH-575
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 2.0, 2.1, 2.2
> Reporter: Phil Steitz
> Assignee: Thomas Neidhart
> Priority: Minor
> Fix For: 3.0
>
>
> InvalidRepresentationException is checked and non-localized. This exception should be placed in the [math] hierarchy. The AbstractListChromosome constructor also throws a non-localised IAE, which should be replaced by an appropriate [math] exception.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira