You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/10/04 20:49:16 UTC

[GitHub] [camel-kamelets] MelissaFlinn opened a new pull request #538: kamelets-doc-template-edit

MelissaFlinn opened a new pull request #538:
URL: https://github.com/apache/camel-kamelets/pull/538


   I have made some copy edits to the Kamelets doc template. 
   I also made some minor structure changes (for example, moved the dependencies into a higher level section). 
   And I tried to add an adoc variable (containercmd) to use for kubectl (upstream) and oc (downstream). I am not sure that this will work - might need to add a separate attributes.adoc file to handle the value for this and any future adoc variables.
   I welcome all feedback.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-kamelets] MelissaFlinn commented on pull request #538: kamelets-doc-template-edit

Posted by GitBox <gi...@apache.org>.
MelissaFlinn commented on pull request #538:
URL: https://github.com/apache/camel-kamelets/pull/538#issuecomment-934406855


   I removed the containercmd variable in the second commit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-kamelets] oscerd commented on pull request #538: kamelets-doc-template-edit

Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #538:
URL: https://github.com/apache/camel-kamelets/pull/538#issuecomment-936059364


   Thanks, the docs have been regenerated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-kamelets] oscerd merged pull request #538: kamelets-doc-template-edit

Posted by GitBox <gi...@apache.org>.
oscerd merged pull request #538:
URL: https://github.com/apache/camel-kamelets/pull/538


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-kamelets] MelissaFlinn commented on pull request #538: kamelets-doc-template-edit

Posted by GitBox <gi...@apache.org>.
MelissaFlinn commented on pull request #538:
URL: https://github.com/apache/camel-kamelets/pull/538#issuecomment-934503767


   Thank you @oscerd - I do not have permission to merge this PR. Can you merge it or is there someone else that I should ask?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-kamelets] oscerd commented on pull request #538: kamelets-doc-template-edit

Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #538:
URL: https://github.com/apache/camel-kamelets/pull/538#issuecomment-934512368


   I'll do that but first i need to Regen the docs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org