You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2021/08/09 21:32:18 UTC

[GitHub] [thrift] fishy opened a new pull request #2435: THRIFT-5453: Defer DNS from NewTSocketConf to TSocket.Open

fishy opened a new pull request #2435:
URL: https://github.com/apache/thrift/pull/2435


   Client: go
   
   We used to do DNS lookups in NewTSocketConf, without any timeout checks.
   Stop doing that and do DNS lookups in TSocket.Open instead, which
   already checks for ConnectTimeout set in TConfiguration.
   
   This will be cherry-picked into 0.15.0 branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] fishy merged pull request #2435: THRIFT-5453: Defer DNS from NewTSocketConf to TSocket.Open

Posted by GitBox <gi...@apache.org>.
fishy merged pull request #2435:
URL: https://github.com/apache/thrift/pull/2435


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] fishy commented on pull request #2435: THRIFT-5453: Defer DNS from NewTSocketConf to TSocket.Open

Posted by GitBox <gi...@apache.org>.
fishy commented on pull request #2435:
URL: https://github.com/apache/thrift/pull/2435#issuecomment-896153657


   I'm going to test this on our system for a bit to see what's the implications before merging it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] fishy commented on pull request #2435: THRIFT-5453: Defer DNS from NewTSocketConf to TSocket.Open

Posted by GitBox <gi...@apache.org>.
fishy commented on pull request #2435:
URL: https://github.com/apache/thrift/pull/2435#issuecomment-896331260


   The test looks good, but I realized that since `NewTSocketConf` can never return an error now, I'd remove that from the function signature while I'm here.
   
   Also updated some of the tests to stop using deprecated functions and switch to use the -Conf versions.
   
   @dcelasun please take another look :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org