You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Siyao Meng (Jira)" <ji...@apache.org> on 2020/10/20 21:54:00 UTC
[jira] [Created] (RATIS-1102) Fix typo in
MetricRegistriesImpl#create warning message
Siyao Meng created RATIS-1102:
---------------------------------
Summary: Fix typo in MetricRegistriesImpl#create warning message
Key: RATIS-1102
URL: https://issues.apache.org/jira/browse/RATIS-1102
Project: Ratis
Issue Type: Bug
Reporter: Siyao Meng
The warning message in {{MetricRegistriesImpl#create}} should read {{addReport*er*Registration}}. It was missing the "er". It confused me for a bit when I'm trying to follow the message.
{code}
@Override
public RatisMetricRegistry create(MetricRegistryInfo info) {
return registries.put(info, () -> {
if (reporterRegistrations.isEmpty()) {
LOG.warn(
"First MetricRegistry has been created without registering reporters. You may need to call" +
" MetricRegistries.global().addReporterRegistration(...) before.");
}
RatisMetricRegistry registry = factory.create(info);
reporterRegistrations.forEach(reg -> reg.accept(registry));
return registry;
});
}
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)